Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2024-06-13] [Payment card / Subscription] Implement “Subscription size” screen (UI) #38632

Closed
MitchExpensify opened this issue Mar 19, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Mar 19, 2024

Drafting cc @fabioh8010

From this section in the Design Doc:

Route for page - /settings/subscription/subscription-size
Before we can start building the actual screen content we have to create an empty SubscriptionsSizePage screen and add it to the navigation. The screen needs to be added to the SCREENS.RIGHT_MODAL.SETTINGS object and SettingsModalStackNavigator to be displayed in the correct way.

Implement the first step

image

To implement the header we are going to use . We will also use to handle form submitting and render the “Next” button. We will create a new form ID - SUBSCRIPTION_SIZE_FORM in ONYXKEYS.ts and pass it as a prop (formID) to the .

Subtitle

image

To implement this part we will use a basic component with some styles.

“Subscription size” input

image

To build this input field we are going to use component in a similar way to how it’s done in .

Info section

image

This is going to be a basic component.

“Next” button

This button is going to be rendered by , we will pass the text through the submitButtonText property. When this button is clicked, the user will be redirected to the second step.

Implement the second step (the default variant)

image

This is called “the default variant” because it describes the scenario where a user either increases the number of members or decreases it and is allowed to do that (replicating this logic). If a user tries to downgrade from an annual subscription, an alternative variant will be shown (described in next section).

Subtitle

image

This is going to be a simple component with the updated number of members (20 in this case).

Info section

image

This section is going to be built using disabled
components with proper subscription details (number of members, price, end date).

“Save” button

image

We are going to use the component wrapped in to place it on the bottom, similar to how it’s done in ContactMethodsPage.tsx.

Implement the second step (the alternative variant)

image

It will be shown if a user is not allowed to make a change to his subscription (workspace owner tries to downgrade from an annual subscription, either by switching to pay-per-use or lowering subscription size).

Subtitle

image

We are going to use a simple component to build this.

Info section

image

Once again, a simple component.

“Close” button

image

We are going to use the

component wrapped in to place it on the bottom, similar to how it’s done in ContactMethodsPage.tsx.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01501e6915435e5aa7
  • Upwork Job ID: 1798871381768029421
  • Last Price Increase: 2024-06-07
Issue OwnerCurrent Issue Owner: @

@fabioh8010
Copy link
Contributor

Hi, I'm Fábio from Callstack - expert agency - and I would like to work on this issue.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 5, 2024
@trjExpensify trjExpensify moved this from Release 2: Summer 2024 (Aug) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 17, 2024
@MrMuzyk
Copy link
Contributor

MrMuzyk commented May 27, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

Copy link

melvin-bot bot commented May 29, 2024

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@amyevans amyevans assigned amyevans and MrMuzyk and unassigned fabioh8010 and marcaaron May 29, 2024
@shawnborton
Copy link
Contributor

When creating these placeholder GH issues, can you include more information @MitchExpensify like linking to the Design Doc, adding Figma mocks, etc? Thanks!

@amyevans
Copy link
Contributor

amyevans commented Jun 3, 2024

PR merged

Copy link

melvin-bot bot commented Jun 4, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@MitchExpensify
Copy link
Contributor Author

When creating these placeholder GH issues, can you include more information @MitchExpensify like linking to the Design Doc, adding Figma mocks, etc? Thanks!

Sorry about that @shawnborton ; yes, I'll update them all.

@MrMuzyk I'm not 100% sure how much of the Subscription size section of the detailed portion is covered here. Please let me know what I should cut!

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Jun 6, 2024

@MitchExpensify whole UI for the subscription size flow was completed here so I think description that was added covers it 👍

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 6, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] Implement “Subscription size” screen (UI) [HOLD for payment 2024-06-13] [Payment card / Subscription] Implement “Subscription size” screen (UI) Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

  • @MrMuzyk does not require payment (Contractor)

@amyevans amyevans added the NewFeature Something to build that is a new item. label Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@amyevans
Copy link
Contributor

amyevans commented Jun 6, 2024

@ikevin127 reviewed the PR as C+ so will be due payment

@jliexpensify jliexpensify added the External Added to denote the issue can be worked on by a contributor label Jun 7, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01501e6915435e5aa7

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-13] [Payment card / Subscription] Implement “Subscription size” screen (UI) [$250] [HOLD for payment 2024-06-13] [Payment card / Subscription] Implement “Subscription size” screen (UI) Jun 7, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 7, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 7, 2024
@jliexpensify jliexpensify added Weekly KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jun 7, 2024
@jliexpensify
Copy link
Contributor

Payment Summary

UPWORKS JOB

Do we need a competed checklist as well?

@amyevans
Copy link
Contributor

amyevans commented Jun 7, 2024

Nope no checklist needed

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 12, 2024
@jliexpensify
Copy link
Contributor

Paid and job closed!

@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

8 participants