[HOLD for payment 2024-06-20] [Payment card / Subscription] Subscription size "Save" button has no margin

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

issue found when validating #42683
Version Number: 1.4.79-2
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Open the New Expensify App
2. Go to /settings/subscription/subscription-size and send in any chat
3. Deeplink it by tapping on the link
4. Input any value and click on "Next"
5. Observe the bottom "Save button"

Expected Result:

User expects a bottom margin

Actual Result:

There is no Bottom Margin

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6502103_1717536171994.No_bottom_margin_on_Save_button.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@chiragsalian FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[amyevans]

Taking over since it's coming from #42683. Not a deploy blocker since this is a new feature and can't be reached without a direct URL, but we should clean it up @MrMuzyk

[MrMuzyk]

@amyevans I thought that this feature should only be accessible on web platform. How do we want to handle this? Should we also block access to these screens via direct link? Or should we leave it accessible and fix the margin issue?

cc @JKobrynski

[amyevans]

@MrMuzyk sorry I missed this earlier. We should just block access via direct link for native

[greg-schroeder]

Adding to #wave-collect

[MrMuzyk]

@amyevans I will handle this the same we've handled DisableAutoRenewSurveyPage - will display FullPageNotFoundView component

[greg-schroeder]

PR is up/in review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: display FullPageNotFoundView on mobile for subscription size page #43345

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @MrMuzyk does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@amyevans] The PR that introduced the bug has been identified. Link to the PR:
• [@amyevans] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@amyevans] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@MrMuzyk] Determine if we should create a regression test for this bug.
• [@MrMuzyk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[amyevans]

No payment required here, and regression tests will be added once the feature is fully rolled out, so I'm going to close this out.