[HOLD for payment 2024-04-05] App crashes trying to render QAB

[rafecolton]

Introduced in #38669

cc @Gonals @marcaaron

Version Number: Tested on main@1b0fe6d2ee
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: me
Slack conversation: https://expensify.slack.com/archives/C03TQ48KC/p1711407644753289 (Expensify internal)

Action Performed:

Break down in numbered steps

1. Create a new chat from one new user to another new user
2. App crashes

Expected Result:

App doesn't crash

Actual Result:

App crashes due to empty string being passed to translate()

There's also a proptypes warning which is likely due to the wrong type being passed from the API

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Check quickAction.action is set before trying to display in popover #38973

If no regressions arise, payment will be issued on 2024-04-05. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] Determine if we should create a regression test for this bug.
• [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[paultsimura]

@rafecolton could you please assign me to this issue as a C+?

[paultsimura]

• The PR that introduced the bug has been identified. Link to the PR: Display Quick Action Button #38669
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/38669/files#r1551298920
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: No – it was a new feature and the translation keys shouldn't change.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[rafecolton]

Hi @paultsimura, I'm new to working with contributors, so asked in Slack here (internal) to confirm the process. Thanks for your patience.

[rafecolton]

Assigned! Added @Christinadobrzyn to handle payment

[Christinadobrzyn]

Payouts due:

• Contributor+: $500 @paultsimura (Upwork offer - https://www.upwork.com/nx/wm/offer/101740503)

Upwork job is here

@paultsimura can you accept the upwork offer? Thanks!

[paultsimura]

Thanks, accepted😌

[Christinadobrzyn]

Awesome! I paid this out based on this payment summary.

Closing this our since there's no regression test.