[HOLD for payment 2024-04-09] [$500] Infinite skeleton loader appears when manually changing URL to an invalid report

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-6
Reproducible in staging?: yes
Reproducible in production?: not currently, but we're not treating this as a blocker so it will be soon.
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1711496796142069?thread_ts=1711394610.825829&cid=C01GTK53T8Q

Action Performed:

1. Open any chat in NewDot web
2. Manually change the reportID in the URL to a random number (not the ID of a report you have access to).
3. Alternatively, manually change the reportID in the URL to 0. It's the same bug.

Expected Result:

After a brief loading period, you should see a 404 "not found" page.

Actual Result:

you see an infinite skeleton indicator

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0113ef219591bbf681
• Upwork Job ID: 1772775589885202432
• Last Price Increase: 2024-03-27
• Automatic offers:
• ishpaul777 | Reviewer | 0
• alitoshmatov | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0113ef219591bbf681

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[roryabraham]

no help needed here, @ishpaul777 is going to complete the PR and I will act as C+ and reviewer

[roryabraham]

also, no additional payment needs to be due here, because this was technically a regression from Comment Linking.

[ishpaul777]

PR is ready ☝️ @roryabraham

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[roryabraham]

our automation got confused here. @ishpaul777 is in the contributor role and @alitoshmatov is in the C+ role on this one.

[roryabraham]

update: I realize I said above that I'd act as C+. It's a pretty simple PR, so I'll follow through on that an waive @alitoshmatov's C+ services here. Thanks

[joekaufmanexpensify]

Withdrew @alitoshmatov's offer.

[roryabraham]

PR merged, just awaiting deploy and QA, no payments due

[joekaufmanexpensify]

Awesome. I closed the upwork job too.

[roryabraham]

PR was merged, closing this out since no additional payments are due

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fixes "Skeleton is displayed when navigating to a transaction thread created offline" #38955

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment automatic offer (Reviewer)
• @ishpaul777 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cristipaval]

The fix for this issue was reverted, correct? Should we reopen it?

[shahinyan11]

I had a proposal, but I deleted it because the issue was assigned to another contributor. Does it make sense to publish my proposal again ?

[roryabraham]

requested retest: https://expensify.slack.com/archives/C9YU7BX5M/p1713202486899949

[kavimuru]

Issue reproduced

Recording.809.mp4

RPReplay_Final1713204176.MP4

Record_2024-04-15-20-55-58.mp4