[$500] Share code - Tapping reply in thread share code URL directs to page loading infinitely

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open a report
3. Send a message
4. Long press the message and select reply in thread
5. Send a message
6. Tap header
7. Copy share code
8. Login app with different account
9. Open a report
10. Paste copied URL and send the message
11. Tap URL link

Expected Result:

Tapping reply in thread share code URL must not direct to page loading infinitely

Actual Result:

Tapping reply in thread share code URL directs to page loading infinitely

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435622_1712066286508.repl.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012acca0fb0a485001
• Upwork Job ID: 1775461423696654336
• Last Price Increase: 2024-04-03
• Automatic offers:
• hungvu193 | Reviewer | 0

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping reply in thread share code URL directs to page loading infinitely

What is the root cause of that problem?

We wrap the condition to show not found page with the check !shouldShowSkeleton so the not found page will not show if shouldShowSkeleton is true.

App/src/pages/home/ReportScreen.tsx

Line 363 in c550afd

!shouldShowSkeleton &&

When we open the report which we cannot access, OpenReport API only returns the errorFields so isCurrentReportLoadedFromOnyx is false that leads shouldShowSkeleton is always true and then infinite skeleton appears

App/src/pages/home/ReportScreen.tsx

Line 346 in c550afd

const isCurrentReportLoadedFromOnyx = useMemo((): boolean => {

What changes do you think we should make in order to solve the problem?

We should remove !shouldShowSkeleton from this check

App/src/pages/home/ReportScreen.tsx

Line 363 in c550afd

!shouldShowSkeleton &&

and to fix the issue not found page appears briefly after signing, we can replace reportActionIDFromRoute here to the current reportID param of the route

currentReportIDFormRoute = route.params?.reportID
(!! currentReportIDFormRoute && !ReportUtils.isValidReportIDFromPath(currentReportIDFormRoute))), 

App/src/pages/home/ReportScreen.tsx

Line 371 in c550afd

(!!reportIDFromRoute && !ReportUtils.isValidReportIDFromPath(reportIDFromRoute))),

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012acca0fb0a485001

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

It was originally fixed here, however it caused this DB, so it was revert here

Ideally, we should implement #38955 again with the suggestion fix in this discussion

cc @roryabraham @ishpaul777

[hungvu193]

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hungvu193]

@cristipaval Can you take a look at my comment here, if this issue is not treated as regression, I think we can go with @nkdengineer's proposal

[cristipaval]

Let's wait for the resolution of the issue where the fix was reverted. Asked about it here.

[ishpaul777]

Sorry i missed the ping here Tomorrow I'll create a new PR as author of closed issue.

[cristipaval]

WIP.

[ishpaul777]

Hey all! i did invested sometime but i couldn't get to satisfactory solution, suggested fix in #38955 (comment) causing a weird bug to show Not-found page when chat is swiched, can we please keep it open for more proposals, i really apologize and will continue my investigation but letting you all know so we aren't blocked by me.

[nkdengineer]

@cristipaval My proposal here #39415 (comment) can fix the issue without regression and C+ was approved it.

[hungvu193]

@cristipaval My proposal here #39415 (comment) can fix the issue without regression and C+ was approved it.

I think we will need to confirm #39415 (comment) first then I will need to test your proposal again carefully before processing any further step 😄

[cristipaval]

Let me know when you're done with the re-evaluation, @hungvu193

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@hungvu193 The PR is here.

[laurenreidexpensify]

Deployed to Prod a week ago on 22 April and no regressions, eligible for payment

[laurenreidexpensify]

Payment Summary:

C+ @hungvu193 $500 - payment issued in upwork
Contributor @nkdengineer $500 - please accept offer in upwork

[laurenreidexpensify]

@hungvu193 pls advise on any regression steps etc here thanks

[hungvu193]

As I mentioned above:

It was originally fixed here, however it caused this DB, so it was revert here

Regression test:

1. Open a report
2. Send an invalid report url and click on it.
3. Verify that NotFoundPage will show.

Do we 👍 or 👎 ?

[nkdengineer]

Contributor @nkdengineer $500 - please accept offer in upwork

@laurenreidexpensify Offer accepted, thanks!

[nkdengineer]

Sorry @laurenreidexpensify It seems I wasn't paid here, could you please reopen the issue to help with this?

TIA

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[cristipaval]

Applied the Bug label again to get another bug-zero member, since @laurenreidexpensify is OOO

[cristipaval]

@slafortune could you please verify whether @nkdengineer was paid? 🙏

[slafortune]

@nkdengineer sorry that happened! Paid now ✅