[HOLD for payment 2024-05-02] [Wave Collect][QBO] Create a HOC to call OpenAccountingPage and then pass the report.connections

[hayata-suenaga]

Based on the discussion, implement a Higher-Order Component (HOC) that uses useOnyx to subscribe to policy data, then passes this data to the component it wraps. The HOC should inspect the connections field of the policy. If this field lacks a value in the policy data, the HOC should call OpenAccountingPage.

The HOC also should render the loading indicator or offline screen if necessary.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019f138fc4382cdf6a
• Upwork Job ID: 1773765815925579776
• Last Price Increase: 2024-03-29

[melvin-bot]

Triggered auto assignment to @strepanier03 (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[hayata-suenaga]

changing priority back to daily as this has the high priority

[strepanier03]

@hayata-suenaga - I am holding off labeling this Internal unless you give the go-ahead. I don't want to assign a C+ to do PR review if it's not needed.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019f138fc4382cdf6a

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[hayata-suenaga]

I decided to have a C+ review the PR just in case 😄

[hayata-suenaga]

I realized that a C+ is already assigned to the PR. I'll assign them to this issue.

[strepanier03]

Thank you @hayata-suenaga 🙌

[trjExpensify]

Is the PR for this now on hold for #39652, @hayata-suenaga? If so, let's have that reflected in the title.

[strepanier03]

PR is deployed to staging.

[hayata-suenaga]

The PR is actually still being worked on 🙇

[strepanier03]

@hayata-suenaga - sorry for the confusion, I meant the PR that this was on hold for is deployed to staging, not the PR for fixing for this issue 🤦‍♀️

[hayata-suenaga]

ah haha sorry for my misunderstanding 🙇 🙈

[trjExpensify]

#39132 is deployed to staging, follow-up PR for a bug here.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Swap from withPolicy to withPolicyConnections for Export Quickbooks pages #40713

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[strepanier03]

@hayata-suenaga - I was having a hard time figuring out the price here based on the PR that's linked. Is this a $500 payment or a $250 PR review payment?

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mollfpr owed $250 via NewDot

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1773765815925579776/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[strepanier03]

nvm, @hayata-suenaga - payment summary finally posted and I got my answer.

[strepanier03]

Payment summary

• $250 to @mollfpr via Manual Request in Newdot

@JmillsExpensify - Payment request incoming!

[JmillsExpensify]

$250 approved for @mollfpr