-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-05-03] [$250] Chat - Text in the composer is highlighted after adding an emoji to text with mark down #39237
Comments
Triggered auto assignment to @cristipaval ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #vip-vsb |
Not a blocker - added to the tracking issue |
Opening this to external contributors! |
Job added to Upwork: https://www.upwork.com/jobs/~012f7f1b9abead474c |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 ( |
I am Michał from Callstack - expert contributor group. I’d like to work on this job. |
@kbecciv Hey, can you try to reproduce this again? I wasn't able to do that. 39237_no_repro.mp4 |
@MrMuzyk Checking |
@thienlnam, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
@tomekzaw, @thienlnam, @eh2077 Eep! 4 days overdue now. Issues have feelings too... |
Hi, to confirm my Expensify/react-native-live-markdown#313 in |
Here is the PR with the fix |
I've checked on latest main and issue is no longer reproducible. @kbecciv Can you confirm that? selection_after_emoji_fixed.mp4 |
@MrMuzyk Issue is fixed now. |
Yes, this is fixed by @Skalakid 's PR #40923 which was merged yesterday |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-03. 🎊 For reference, here are some details about the assignees on this issue:
|
Issue is ready for payment but no BZ is assigned. @laurenreidexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks! |
@tomekzaw, @thienlnam, @laurenreidexpensify, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@laurenreidexpensify This is an edge case, so I don't think it's necessary to add a regression test for it. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.58-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The text in the composer will not be highlighted.
Actual Result:
The entire text in the composer is highlighted after adding an emoji to text with mark down.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
bandicam.2024-03-29.11-21-01-144.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: