Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-03] [$250] Chat - Text in the composer is highlighted after adding an emoji to text with mark down #39237

Closed
4 of 6 tasks
kbecciv opened this issue Mar 29, 2024 · 34 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Mar 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Go to any chat.
  3. Enter a text in bold mark down.
  4. Create a new line.
  5. Open emoji picker.
  6. Select an emoji.

Expected Result:

The text in the composer will not be highlighted.

Actual Result:

The entire text in the composer is highlighted after adding an emoji to text with mark down.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bandicam.2024-03-29.11-21-01-144.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012f7f1b9abead474c
  • Upwork Job ID: 1776300079521869824
  • Last Price Increase: 2024-04-12
  • Automatic offers:
    • eh2077 | Reviewer | 0
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Mar 29, 2024

We think that this bug might be related to #vip-vsb

@thienlnam
Copy link
Contributor

Not a blocker - added to the tracking issue

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@thienlnam thienlnam added the External Added to denote the issue can be worked on by a contributor label Apr 5, 2024
@thienlnam
Copy link
Contributor

Opening this to external contributors!

@melvin-bot melvin-bot bot changed the title Chat - Text in the composer is highlighted after adding an emoji to text with mark down [$250] Chat - Text in the composer is highlighted after adding an emoji to text with mark down Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012f7f1b9abead474c

@melvin-bot melvin-bot bot added Help Wanted Apply this label when an issue is open to proposals by contributors and removed Overdue labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
@MrMuzyk
Copy link
Contributor

MrMuzyk commented Apr 8, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Apr 8, 2024

@kbecciv Hey, can you try to reproduce this again? I wasn't able to do that.

39237_no_repro.mp4

@kbecciv
Copy link
Author

kbecciv commented Apr 8, 2024

@MrMuzyk Checking

Copy link

melvin-bot bot commented Apr 8, 2024

@thienlnam, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Apr 16, 2024

📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot melvin-bot bot added the Overdue label Apr 19, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

@tomekzaw, @thienlnam, @eh2077 Eep! 4 days overdue now. Issues have feelings too...

@Skalakid
Copy link
Contributor

Hi, to confirm my Expensify/react-native-live-markdown#313 in react-native-live-markdown library, fixes this issue. I will create the PR that bumps the version of the library in our App

@Skalakid
Copy link
Contributor

Here is the PR with the fix

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Apr 25, 2024

I've checked on latest main and issue is no longer reproducible. @kbecciv Can you confirm that?

selection_after_emoji_fixed.mp4

@kavimuru
Copy link

@MrMuzyk Issue is fixed now.
image

@eh2077
Copy link
Contributor

eh2077 commented Apr 25, 2024

Hi, to confirm my Expensify/react-native-live-markdown#313 in react-native-live-markdown library, fixes this issue. I will create the PR that bumps the version of the library in our App

Yes, this is fixed by @Skalakid 's PR #40923 which was merged yesterday

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 26, 2024
@melvin-bot melvin-bot bot changed the title [$250] Chat - Text in the composer is highlighted after adding an emoji to text with mark down [HOLD for payment 2024-05-03] [$250] Chat - Text in the composer is highlighted after adding an emoji to text with mark down Apr 26, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 26, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-03. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 3, 2024
Copy link

melvin-bot bot commented May 3, 2024

Issue is ready for payment but no BZ is assigned. @laurenreidexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@melvin-bot melvin-bot bot added the Overdue label May 6, 2024
Copy link

melvin-bot bot commented May 7, 2024

@tomekzaw, @thienlnam, @laurenreidexpensify, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@laurenreidexpensify
Copy link
Contributor

Payment Summary:

Contributor: @tomekzaw agency worker - no payment
C+: @eh2077 $250 paid in Upwork

@eh2077 pls confirm if a regression test is required

@melvin-bot melvin-bot bot removed the Overdue label May 7, 2024
@eh2077
Copy link
Contributor

eh2077 commented May 7, 2024

@laurenreidexpensify This is an edge case, so I don't think it's necessary to add a regression test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

9 participants