Deploy Checklist: New Expensify 2024-03-29

[github-actions]

Release Version: 1.4.58-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [WAVE7] Hold Requests: Approving/Paying expense reports with held requests #33124
• Display total and money request in offline #36657
• [No QA] Migrate 'OptionsListUtilsTest.js', 'DateUtilsTest.js', 'SidebarLinks.perf-test.js', 'markdown.js' and 'ReportUtilsTest.js' to Typescript #37206
• [No QA][TS migration] Migrate multiple test to typescript #37396
• Create Group Chats + Splits. #37458
• feat: Upgrade VisionCamera to V4 #37483
• Fix immediately prompt for Camera permission in scan request flow #37817
• [No QA] [TS migration] Migrate 'test.test.js', 'reviewerChecklist.test.js', 'preDeploy.test.js', 'platformDeploy.test.js', 'lockDeploys.test.js' workflow test to TypeScript #38045
• [No QA] [TS migration] Migrate 'validateReassureOutput.js', 'createDocsRoutes.js', 'reopenIssueWithComment.js', 'postTestBuildComment.js' and 'isStagingDeployLocked.js' .github files to TypeScript #38144
• Enable Live Markdown Preview on web #38152
• Update Workspace Creation in NewDot to Create Collect Workspaces #38191
• [TS migration] Migrate cla.test to typescript #38393
• Use policy achAccount instead of reimbursementAccount in WorkspaceWorkflow #38395
• Fix video sharing #38407
• [NoQA] [Audit][Implementation] - Increase max cache keys count and use waitForCollectionCallback #38464
• [No QA][TS migration] Migrate remaining GitHub actions to TypeScript #38576
• Fix: Debug console always scrolls to new data position #38607
• Correctly update thread ancestors reply count #38658
• Feat: Redesign thread ancestry #38722
• Disable keyboard suggestion on money request amount input #38728
• Fix opening FullScreenNavigator from the Home page #38734
• Performance: Store personalDetails loading state in personalDetailsMetadata key #38756
• Feat/38772/update UI for completed task #38802
• Open the iou debit card page when clicking on pay with debit card #38885
• Fix/last option is not selected when pressing up arrow key #38886
• Add the Connections section on the More Features page #38900
• Fix: A new line is added after backticks when saving unchanged task description with code fence #38908
• [No QA][TS migration] Restore migrate workflow_tests, adjust utils migration #38934
• fix: broken login page when refreshing #38940
• Make sort tag consistent with oldDot #38949
• fixes "Skeleton is displayed when navigating to a transaction thread created offline" #38955
• Fix can not focus on the main composer after going back from thread #38978
• fix left side bar remains as chat when clicking on invitation #38984
• Auto scroll fix #38999
• [Fix]: Expand video button isn't highlighted when hovered on #39001
• Fix composer focus is lost when clicking the edit composer of a thread parent message #39002
• Add Stripe ACH IDs and CorPay IDs #39003
• fix admin badge not crossed out when removing admin offline #39010
• 38483 - fix edit message draft reappearing #39027
• #39005 - Polish items for Transfer owner flow  #39035
• [Taxes] Change max tax value length #39037
• fix: no invalid amount error if lasts digit are 0 #39039
• Blinking on chat switching #39040
• fix: update distance rates when changing currency offline #39046
• Add status messages in money request previews #39048
• Fix user's time being displayed above compose box in policy expense chat reports #39058
• [NoQA] chore: rename critical to isCritical #39062
• perf: Reduce heavy operations in Request Money flow #39063
• [No QA] The deploy workflows fails to comment on deployed PR #39069
• Transfer owner - Typing error in "You're now the owner if this workspace" #39073
• Extract WorkspaceSettingsModalStackNavigator #39084
• [No QA] Add logs to investigate awaitStagingDeploys action #39088
• Update redirects.csv for budgets, tags and reimbursing report #39100
• Delete docs/articles/expensify-classic/workspaces/Domains-Overview.md #39103
• Revert "[No QA] Migrate 'OptionsListUtilsTest.js', 'DateUtilsTest.js', 'SidebarLinks.perf-test.js', 'markdown.js' and 'ReportUtilsTest.js' to Typescript" #39140
• [CP Staging] Fix crash for unknown action type when getting quick action title #39149
• Fix opening workspace settings on small screen #39150
• Use document icon for enabling the rates #39157
• fix: Position of offline message on workspaceReimburse on web #39160
• [CP Staging] Fix Split Scan flow for Group Chats #39276
• [CP Stag] Fix app crashing when selecting an emoji #39282
• Revert using comment linking in threads #39302
• Revert "feat: Upgrade VisionCamera to V4" #39367
• [CP Staging] Revert "fixes "Skeleton is displayed when navigating to a transaction thread created offline"" #39377
• [CP Staging] fix: Split btn for single contact became inactive when returned from final review #39383

Deploy Blockers:

• [HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] [$500] Shortcut - Error shows up when creating second self-assigned task via Assign task shortcut #39049
• [HOLD for payment 2024-06-21] [$500] mweb - Chat - App crashes when selecting an emoji #39234
• Chat - Three empty lines are pasted when pasting a text with an empty line #39235
• [HOLD for payment 2024-04-15] Mark down - App crashes when entering an emoji inside three backticks code block #39236
• [HOLD for payment 2024-05-03] [$250] Chat - Text in the composer is highlighted after adding an emoji to text with mark down #39237
• [$250] [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Android - Scan - Camera shutter sound still goes off despite device and app sound profile #39241
• [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] [$250] Thread - New message does not appear in main chat after returning from thread and sending text #39242
• [HOLD for payment 2024-04-15] [$500] Group Chat - Selected contacts appear on the confirmation page with a delay #39245
• [HOLD #39982] Thread - Gray "Replies" does not disappear together with reply when reply is deleted #39246
• [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Thread - Group chat thread header shows unavailable workspace icon #39247
• Thread - Group chat thread header shows unavailable workspace icon #39248
• [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Group chat - Group chat avatar leads to not here page #39249
• Thread - Parent message with reply is highlighted in main chat after returning from thread #39250
• [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Task - Not here page shows up when opening room link under header subtitle in deleted task #39251
• [$250] Web - Chat - Composer is expanded briefly when returning to chat after creating new workspace #39252
• [Hold for payment 2024-04-29] [$500] Video - Console error shows up when playing video #39253
• [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Split Scan - Group created from split scan does not use the same avatar style as manual split #39254
• [PAID] [HOLD for payment 2024-06-18] [$500] Unable to undo copy and pasted text #39255
• [$500] Workspaces - Tapping on any workspace does not lead to ws settings #39256
• Taxes - App does not allow user to enter any digit after dot when there are 6 zeros before it #39257
• Chat - Composer flickers when using header markdown #39258
• Web - Chat - Top of the highlight is not even when highlight emojis #39261
• [HOLD 10414]mWeb - Chat - Device keyboard does not auto appear when editing a message #39263
• [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Thread - App shows skeleton loading when clicking on parent/ancestor message offline #39264
• Web - Chat - Console error shows up when creating a new line on italic mark down #39265
• Mark down - Different colour of strikethrough on email depending on bold mark down position #39266
• [HOLD for payment 2024-05-08] Web - Chat - Composer jumps when entering first emoji #39267
• [Hold for #39597] [$500] Web - Chat - Text in composer is enlarged after removing emoji from text and sending it #39269
• iOS - Chat - Emojis are cut off at the top in compose box #39270
• Mark down - Position of text with header and line changes after collapsing the composer #39271
• [$500] Chat - The cursor appears before the last letter in the compose box when pasting #39272
• Web – Chat - The font is changed in the compose box upon completing a code block markdown #39273
• Emojis displayed are cut off in top in composer #39274
• [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Chat - Parent msgs disappear after back from thread by clicking header/browser back button #39277
• Web - Mark down - Send button is disabled and console error when pasting text with MD image #39284
• [HOLD for payment 2024-04-25] [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Scan - Camera is seen as black screen and error occurs after tap capture icon #39285
• [$500] Workspace - Web - Unable to go to Workspace setting when open member chat page #39288
• [$500] IOU - Chat reloads when clicking Message <user> after returning from IOU thread #39289
• [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Report - 'New message' button is not displayed when navigating to parent report #39291
• Workspace - Unable to delete workspace #39294
• [HOLD for payment 2024-04-15] [$500] Web - Group chat - Unable to create a group chat via search input after deselecting members #39295
• [HOLD PR #39343][$250] Thread-Cursor is hand cursor instead of text cursor when hovering over edit composer in thread #39301
• [$250] Chat - Size of text cursor is smaller when returning to any chat via browser back button #39303
• Web - Request Money - Category Not Automatically Added When Requesting Money in Distance Mode #39304
• [HOLD for payment 2024-04-15] [$250] mWeb - Send money-In send money report page, an extra skeleton preview is displayed #39306
• [$250] mweb - IOU - Tapping pay elsewhere button in header grey out IOU preview for few seconds #39314
• [$250] [MEDIUM] [Groups] - Group chat with one user is allowed in confirmation page, but not in contact list #39317
• [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] IOU - Split btn for single contact became inactive when returned from final review #39320
• Android - Workspace- Workspace altered name is not saved #39322
• [HOLD for payment 2024-04-25] [$250] Group chat - User can proceed without Start group button via CMD+Enter shortcut #39323
• [MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat #39331
• Thread - Unable to invite user to thread when the thread originates from group chat #39332
• Thread - "Report no longer exists" when sending message in thread as invited user #39333
• [HOLD for payment 2024-06-20] [$500] [Held requests] No confirmation prompt when approving held request via the report preview #39335
• #wave-collect - [Hold on 378314][Held requests] Confirmation to pay is still shown after approving all the requests #39336
• Expense- "you" is missing in next step message when submitting report in new workspace offline #39337
• [HOLD on #378314][$500] [Held requests] Request on hold becomes unheld when approving only unheld request #39338
• [$500] [Held requests] Expense preview turns to skeleton after approving & paying request offline #39339
• [$500] Workspace - Some of the new worspace chats name is "Chat Report" #39340
• Can't set distance rate on a new workspace, Oops... something went wrong error appears #39341
• [Pay meow][$500] [Held requests] Pay with Expensify button does not include amount after approving held request #39342
• [$250] Chat - Text in compose box blends with background when theme was changed in device settings #39348
• RBR disappears from 'amount' field when adding merchant value #39354
• [HOLD for payment 2024-04-25] [$500] IOU - Missing green checkmark next to Total amount after paying request offline #39357
• [$500] Web - Chat - Composer with emoji is expanded with an empty line after expanding the composer #39361
• [HOLD for payment 2024-04-25] [$500] Chats are not loading in the LHN with Most Recent mode #39380
• Sending quote message markdown with > drops after sending the message #39381

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[yuwenmemon]

Hey @kavimuru @isabelastisser @mvtglobally, there are a couple of new features here in this staging release we'd like testers to be aware of.

1. Live Markdown - Before we start testing Enable Live Markdown Preview on web #38152, keep in mind we also upgraded the version of the Live Markdown package. So, it would be best to also make sure that everything is working properly not only on Web, but also on Android/iOS where the package has already been in use since January.

2. Group Chats + Splits - @marcaaron would like to try to resolve any issues with Create Group Chats + Splits. #37458 unless there is something crazy major like features breaking left and right. So please do ping him if you see issues that could be related to it. We tested it pretty well - but it’s one of those foundational things that could lead to weird stuff (but hopefully not...).

[yuwenmemon]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version 1.4.58-0

[amyevans]

Checked off #39235, not a blocker and a PR is already in review

[tgolen]

Checked off #39245 because I don't think it's severe enough to be a blocker. Marked it as external

[blimpich]

Demoting #39250 because its fairly minor and might even be intended behavior.

[rlinoz]

Demoting #39257

[thienlnam]

Demoted a bunch of ones related to live markdown, here are the current actual blockers related to it

• [HOLD for payment 2024-04-15] Mark down - App crashes when entering an emoji inside three backticks code block #39236
• [HOLD for payment 2024-06-21] [$500] mweb - Chat - App crashes when selecting an emoji #39234
• Maybe [HOLD 10414]mWeb - Chat - Device keyboard does not auto appear when editing a message #39263

[mountiny]

Demoted #39306 its not really blocker for users

[marcaaron]

Checking off Demoting #39303

[francoisl]

#39304 will be a backend fix, checked off.

[kavimuru]

Regression is 9% left in the TR
#37817 failing with #39285
#38191 failing with #38114 (comment)
#38722 failing with #39264
#38940 blocked in desktop with this #25790 (comment) - checking it off
#38984 failing with #39256
#38999 failing with #38935
#39001 failing with #39253
#39063 failing with #39320

[kavimuru]

Regression is completed in TestRail.
Unchecked PRs:
#37817 failing with #39285
#38191 failing with #38114 (comment)
#38722 failing with #39264
#38940 blocked in desktop with this #25790 (comment)
#38984 failing with #39256
#38999 failing with #38935
#39001 failing with #39253
#39063 failing with #39320
#33124 failing with #39335 and #39338
#36657 failing with #39363 repro in PROD, checking it off.

[luacmartins]

Demoted #39289

[blimpich]

Demoted #39323

[marcaaron]

Checking off #39333 because DMs on production are affected by the same bug (maybe feature request)

[marcaaron]

Checking off #39317 since it's minor and I need to confirm the correct behavior.

[kavimuru]

Regression completed.

Unchecked PRs:
#37817 failing with #39285
#38191 failing with #38114 (comment)
#38722 failing with #39264
#38940 blocked in desktop with this #25790 (comment)
#38984 failing with #39256
#38999 failing with #38935
#39001 failing with #39253
#39063 failing with #39320
#33124 failing with #39335 and #39338

Open Blockers:
#39241
#39242
#39247
#39249
#39251
#39264
#39285
#39291
#39294
#39320
#39322
#39331
#39336
#39338
#39340
#39341
#39348
#39354
#39357
#39361

[tgolen]

Checking off #39294 as not a blocker.

[tgolen]

Checking off #39341 because it cannot be reproduced.

[marcaaron]

Checking off #39242 as it was fixed and CP'd

[marcaaron]

Same for #39251, #39264, #39291

[marcaaron]

Removing #39336 based on this comment

[marcaaron]

Checking off #39247, #39249 - fixed with a CP

[marcaaron]

Checking off #39357 as it looks relatively minor.

[marcaaron]

Demoting #39354 as it is edge case

[marcaaron]

Checking off #39331. The correct behavior needs to be discussed further

[marcaaron]

Demoting #39322 as we can't reproduce

[marcaaron]

#39380 has to do with the API and not App so the blocker was removed.

[marcaaron]

Five blockers remain...

#39320
#39338
#39340
#39348
#39361

We will hopefully deploy early tomorrow 🤞

[yuwenmemon]

Checking off #39340 as it's an API issue.

[Beamanator]

Checking off #39361 and #39377 as the revert PR was CP'd and confirmed fixed on staging

[Beamanator]

Checking off #39348 b/c it was marked NAB here

Same with #39338, marked NAB here

• [WAVE7] Hold Requests: Approving/Paying expense reports with held requests #33124 can now be checked off, because the issues we created related to that PR are not blockers

[Beamanator]

So looks like the remaining checklist PR items are...:

• Fix immediately prompt for Camera permission in scan request flow #37817
  • Supposedly fixed by Revert "feat: Upgrade VisionCamera to V4" #39367
• Update Workspace Creation in NewDot to Create Collect Workspaces #38191
  • Supposedly failed here, I wonder if this was never addressed cuz it was written in a potentially unrelated PR instead of in a new issue? And it wasn't linked to the originating PR?
• Feat: Redesign thread ancestry #38722
  • Looks like this was supposed to be fixed by Revert using comment linking in threads #39302
• fix left side bar remains as chat when clicking on invitation #38984
  • Was failing with [$500] Workspaces - Tapping on any workspace does not lead to ws settings #39256, which was supposedly fixed by Fix opening workspace settings on small screen #39150?
• Auto scroll fix #38999
  • Was failing with [HOLD for payment 2024-04-09] [$500] Expense - Page scrolls back down when dismissing add receipt RHP in transaction thread #38935, which is the original issue the PR was supposed to fix 😅 so seems like the PR didn't fix the issue, maybe it just didn't cause any new bugs so can be checked off?
• [Fix]: Expand video button isn't highlighted when hovered on #39001
  • Failed with [Hold for payment 2024-04-29] [$500] Video - Console error shows up when playing video #39253, which was marked NAB cuz it's just a console error, so maybe we can check this off now
• perf: Reduce heavy operations in Request Money flow #39063
  • Failed with [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] IOU - Split btn for single contact became inactive when returned from final review #39320, which had [CP Staging] fix: Split btn for single contact became inactive when returned from final review #39383 fix CP'd to staging

And 1 remaining open blocker #39320 which has a fix PR #39383 on staging, which is waiting to be tested

And these PRs that were CP'd to staging to fix blockers:

• [CP Staging] Fix Split Scan flow for Group Chats #39276
• Revert "feat: Upgrade VisionCamera to V4" #39367
  • Note: About an hour ago, someone noted this may not have fixed this blocker: [HOLD for payment 2024-04-25] [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Scan - Camera is seen as black screen and error occurs after tap capture icon #39285 (comment)

[mountiny]

checking off:

• perf: Reduce heavy operations in Request Money flow #39063 as the failing QA was unrelated
• [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] IOU - Split btn for single contact became inactive when returned from final review #39320 fixed in staging
• Revert "feat: Upgrade VisionCamera to V4" #39367 this revert has fixed on deploy blocker and other most likely too, although there might be some uncertainty if the issue persists still, I dont think we have to block though

[mountiny]

Checking off #38191 as the linked fail is not related

[mountiny]

checking off #38722 as it was fixed with the partial revert #39302

[mountiny]

checking off #37817 as the v4 camera pr was reverted

[mountiny]

checking off #38984 as I could not repro the linked blocker anymore #39256

[mountiny]

#38999
Was failing with #38935, which is the original issue the PR was supposed to fix 😅 so seems like the PR didn't fix the issue, maybe it just didn't cause any new bugs so can be checked off?

Did not cause a new bug/ blocker so we can check it off

[mountiny]

checking off #39001 - failing issue marked as NAB

[mountiny]

Checking off #39276 - tested in staging and it was a pass

[Beamanator]