-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taxes - App does not allow user to enter any digit after dot when there are 6 zeros before it #39257
Comments
Triggered auto assignment to @rlinoz ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsp |
Looks like regression from this PR |
Since every other input works fine, I don't we should hold this as a blocker, so removing demoting it. |
Also, I think the bug is that we allow more than four 0s since we limit the field for every other input to 4 characters. |
I don't think this is worth fixing, the field only has a problem if we add more than 4 leading zeroes before the decimal symbol, so I am closing it. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
App will allow user to enter any digit since there are only 6 digits in the input
Actual Result:
App does not allow user to enter any digit after the dot when there are 6 zeros before it
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6431601_1711719933898.tax_input.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: