[No QA][TS migration] Restore migrate workflow_tests, adjust utils migration #38934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioh8010
reviewed
Mar 25, 2024
workflow_tests/lint.test.ts
Outdated
| import {MockGithub} from '@kie/mock-github'; | ||
| import path from 'path'; | ||
| import assertions from './assertions/lintAssertions'; | ||
| import LINT__LINT__STEP_MOCKS from './mocks/lintMocks'; |
There was a problem hiding this comment.
Suggested change
| import LINT__LINT__STEP_MOCKS from './mocks/lintMocks'; | |
| import mocks from './mocks/lintMocks'; |
Merge with main first
| import {MockGithub} from '@kie/mock-github'; | ||
| import path from 'path'; | ||
| import assertions from './assertions/createNewVersionAssertions'; | ||
| import * as mocks from './mocks/createNewVersionMocks'; |
There was a problem hiding this comment.
Suggested change
| import * as mocks from './mocks/createNewVersionMocks'; | |
| import mocks from './mocks/createNewVersionMocks'; |
Merge with main first
workflow_tests/deploy.test.ts
Outdated
| import {MockGithub} from '@kie/mock-github'; | ||
| import path from 'path'; | ||
| import assertions from './assertions/deployAssertions'; | ||
| import * as mocks from './mocks/deployMocks'; |
There was a problem hiding this comment.
Suggested change
| import * as mocks from './mocks/deployMocks'; | |
| import mocks from './mocks/deployMocks'; |
Merge with main first
workflow_tests/deployBlocker.test.ts
Outdated
| import {MockGithub} from '@kie/mock-github'; | ||
| import path from 'path'; | ||
| import assertions from './assertions/deployBlockerAssertions'; | ||
| import * as mocks from './mocks/deployBlockerMocks'; |
There was a problem hiding this comment.
Suggested change
| import * as mocks from './mocks/deployBlockerMocks'; | |
| import mocks from './mocks/deployBlockerMocks'; |
Merge with main first
| import {MockGithub} from '@kie/mock-github'; | ||
| import path from 'path'; | ||
| import assertions from './assertions/finishReleaseCycleAssertions'; | ||
| import * as mocks from './mocks/finishReleaseCycleMocks'; |
There was a problem hiding this comment.
Suggested change
| import * as mocks from './mocks/finishReleaseCycleMocks'; | |
| import mocks from './mocks/finishReleaseCycleMocks'; |
Merge with main first
50 tasks
fabioh8010
approved these changes
Mar 26, 2024
…32051-23055-tests
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #32051 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
jjcoffee
approved these changes
Mar 27, 2024
francoisl
approved these changes
Mar 27, 2024
|
🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.58-0 🚀
|
This was referenced Apr 2, 2024
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #32051
$ #32052
$ #32053
$ #32054
$ #32055
PROPOSAL:
Tests
npm run workflow-testOffline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop