[No QA][TS migration] Migrate workflow_tests, adjust utils migration #38363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation/32051-23055-tests
…ation/32051-23055-tests
blazejkustra
suggested changes
Mar 20, 2024
workflow_tests/lint.test.ts
Outdated
Comment on lines
114
to
125
| try { | ||
| const result = await act.runEvent(event, { | ||
| workflowFile: path.join(repoPath, '.github', 'workflows', 'lint.yml'), | ||
| mockSteps: testMockSteps, | ||
| actor, | ||
| logFile: utils.getLogFilePath('lint', expect.getState().currentTestName), | ||
| }); | ||
|
|
||
| assertions.assertLintJobExecuted(result); | ||
| } catch (error) { | ||
| console.error(error); | ||
| } |
There was a problem hiding this comment.
Why do we suppress the error here?
workflow_tests/lint.test.ts
Outdated
Comment on lines
84
to
95
| try { | ||
| const result = await act.runEvent(event, { | ||
| workflowFile: path.join(repoPath, '.github', 'workflows', 'lint.yml'), | ||
| mockSteps: testMockSteps, | ||
| actor: testActor, | ||
| logFile: utils.getLogFilePath('lint', expect.getState().currentTestName), | ||
| }); | ||
|
|
||
| assertions.assertLintJobExecuted(result); | ||
| } catch (error) { | ||
| console.error(error); | ||
| } |
workflow_tests/lint.test.ts
Outdated
Comment on lines
60
to
71
| try { | ||
| const result = await act.runEvent(event, { | ||
| workflowFile: path.join(repoPath, '.github', 'workflows', 'lint.yml'), | ||
| mockSteps: testMockSteps, | ||
| actor, | ||
| logFile: utils.getLogFilePath('lint', expect.getState().currentTestName), | ||
| }); | ||
|
|
||
| assertions.assertLintJobExecuted(result); | ||
| } catch (error) { | ||
| console.error(error); | ||
| } |
There was a problem hiding this comment.
I remember having some errors pop up in there, but apparently I've handled them along the way. I'll get rid of it
Comment on lines
+3
to
+14
| declare module '@kie/act-js' { | ||
| // eslint-disable-next-line rulesdir/no-inline-named-export | ||
| export declare type StepIdentifier = { | ||
| id?: string; | ||
| name: string; | ||
| run?: string; | ||
| mockWith?: string; | ||
| with?: string; | ||
| envs?: string[]; | ||
| inputs?: string[]; | ||
| } & Omit<ActStepIdentifier, 'name' | 'id' | 'run' | 'mockWith'>; | ||
| } |
There was a problem hiding this comment.
Why is this change necessary?
There was a problem hiding this comment.
some of the steps are passing additional data and since StepIdentifier is defined under the hood as
export declare type StepIdentifier = StepIdentifierUsingName | StepIdentifierUsingId | StepIdentifierUsingUses | StepIdentifierUsingRun | StepIdentifierUsingIndex | StepIdentifierUsingBefore | StepIdentifierUsingAfter;
those steps had more restrictive subtypes of StepIdentifier assigned to them, so to avoid changing the content I made the type a tiny bit more general on the module level
BrtqKr
changed the title
blazejkustra
approved these changes
Mar 20, 2024
VickyStash
approved these changes
Mar 20, 2024
| @@ -71,7 +72,7 @@ describe('test workflow finishReleaseCycle', () => { | |||
| updateProduction: mocks.FINISHRELEASECYCLE__UPDATEPRODUCTION__STEP_MOCKS, | |||
| updateStaging: mocks.FINISHRELEASECYCLE__UPDATESTAGING__STEP_MOCKS, | |||
| }; | |||
| const testMockJobs = { | |||
| const testMockJobs: Record<string, MockJob> = { | |||
There was a problem hiding this comment.
Suggested change
| const testMockJobs: Record<string, MockJob> = { | |
| const testMockJobs: MockJobs = { |
50 tasks
BrtqKr
changed the title
roryabraham
approved these changes
Mar 23, 2024
|
No C+ needed here and Reassure is unrelated / has been fixed on main. Not going to block - going to merge this. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
not an emergency - reassure is unrelated |
|
This is causing TS to fail on main, going to revert for now. Not sure why it was passing on the PR but not after merge. Revert PR here: #38857 |
|
@roryabraham looks like it's because #38288 was merged AFTER the last commit was added on this PR, and BEFORE this PR was merged 🤷 |
|
New PR being worked on here -> #38934 |
This was referenced Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #32051
$ #32052
$ #32053
$ #32054
$ #32055
PROPOSAL:
Tests
npm run workflow-testOffline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop