Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Android - Scan - Camera shutter sound still goes off despite device and app sound profile #39241

Closed
1 of 6 tasks
lanitochka17 opened this issue Mar 29, 2024 · 30 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition

  • Device sound mode is silent and app sound is disabled
  1. Launch New Expensify app
  2. Go to FAB > Request money > Scan
  3. Take a photo

Expected Result:

There will be no camera shutter sound in app when the device is in silent mode (iOS app behavior)

Actual Result:

The camera shutter sound still goes off when device is in silent mode and app sound is disabled. The shutter sound is also very loud compared to iOS app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431594_1711719923715.camera.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014944bc05e2176f43
  • Upwork Job ID: 1785436799448760320
  • Last Price Increase: 2024-04-30
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@johnmlee101
Copy link
Contributor

I think its due to #37483

@johnmlee101
Copy link
Contributor

cc @mrousavy

@mrousavy
Copy link
Contributor

Ok gotcha - I'll see if this can be reproduced in ShadowLens

@johnmlee101
Copy link
Contributor

Let me know when you have an update!

@marcaaron
Copy link
Contributor

CP'd the revert. Asked for a re-test here

@marcaaron marcaaron removed the DeployBlockerCash This issue or pull request should block deployment label Apr 1, 2024
@kavimuru
Copy link

kavimuru commented Apr 1, 2024

Issue is not repro anymore.

Repro_39241.mp4

@mrousavy
Copy link
Contributor

mrousavy commented Apr 2, 2024

Hey! Sorry for the regression.

Two things:

  1. I just fixed this on the VisionCamera V4 Beta branch (21220c) by not playing the shutter sound when the device is in SILENT or VIBRATE mode.
  2. We can also additionally disable enableShutterSound in the takePhoto(...) options when the Expensify app is configured to mute all sounds. How do I get that prop from state/preferences? I can quickly add that.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 Weekly KSv2 labels Apr 2, 2024
@melvin-bot melvin-bot bot changed the title Android - Scan - Camera shutter sound still goes off despite device and app sound profile [HOLD for payment 2024-04-09] Android - Scan - Camera shutter sound still goes off despite device and app sound profile Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 2, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

@johnmlee101 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@johnmlee101
Copy link
Contributor

Closing this out

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2024
@c3024
Copy link
Contributor

c3024 commented Apr 23, 2024

@johnmlee101

I reviewed the PR #39400 that fixed this issue. Could you reopen this and pay? Thanks.

PS: This issue was created before the reduction of standard price to $250. 😃

@johnmlee101 johnmlee101 reopened this Apr 23, 2024
@johnmlee101 johnmlee101 added the Bug Something is broken. Auto assigns a BugZero manager. label Apr 23, 2024
@johnmlee101
Copy link
Contributor

adding a bugzero member!

Copy link

melvin-bot bot commented Apr 23, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Overdue label Apr 25, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

@johnmlee101, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Apr 30, 2024

@johnmlee101, @kevinksullivan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@c3024
Copy link
Contributor

c3024 commented Apr 30, 2024

@kevinksullivan could you please check this and pay?

@kevinksullivan kevinksullivan added the External Added to denote the issue can be worked on by a contributor label Apr 30, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Android - Scan - Camera shutter sound still goes off despite device and app sound profile [$250] [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Android - Scan - Camera shutter sound still goes off despite device and app sound profile Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014944bc05e2176f43

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@kevinksullivan
Copy link
Contributor

Hi @c3024 can you apply to the job above and let me know when you've done so? I am not sure what your name/handle is in upwork. Thanks! Also, what are you expecting this price to be?

@c3024
Copy link
Contributor

c3024 commented May 1, 2024

@kevinksullivan Thanks. Applied for the job. $250 is good.

Here is my Upwork profile as well for info
https://www.upwork.com/freelancers/~0105555e2f227dbf47

@melvin-bot melvin-bot bot added the Overdue label May 3, 2024
Copy link

melvin-bot bot commented May 8, 2024

@johnmlee101, @kevinksullivan Still overdue 6 days?! Let's take care of this!

@kevinksullivan
Copy link
Contributor

offer sent back to ya @c3024 . Let me know when you accept and we can get this wrapped up. Feel free to slack me to @kevin and I can knock this out quickly.

@melvin-bot melvin-bot bot removed the Overdue label May 9, 2024
@kevinksullivan
Copy link
Contributor

All set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

8 participants