Revert "Revert "feat: Upgrade VisionCamera to V4"" #39396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mountiny
approved these changes
Apr 2, 2024
|
@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@Beamanator looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Not emergency, we merged w/out checklists b/c it's a straight revert |
87 tasks
|
follow up fix for shutter sound: #39400 |
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.59-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39367
Should fix #39285
Will probably break #39241
cc @mrousavy @mountiny
Is anyone else seeing that this revert commit is from @cead22 ? 😅 🤷 I guess that's ... fine?