Deploy Checklist: New Expensify 2024-04-02

[github-actions]

Release Version: 1.4.59-9
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [TS migration] Migrate 'IOU' page to TypeScript #35253
• remove MoneyRequestConfirmPage #35461
• Remove NewRequestAmountPage #35833
• Add One Transaction Report View #36934
• Item in report list is not highlighted and list cannot be navigated with keyboard #37081
• [TS migration] Migrate awaitStagingDeploysTest to Typescript #37084
• Feature: Empty state UI for LHN #37361
• [No QA] [TS migration] Migrate 'Config' files to TypeScript #37718
• [TS migration] Migrate 'NewChatSelector' page to TypeScript... #38441
• Add getPolicyIDFromNavigationState method #38490
• [No QA][TS migration] migrate workflow tests #38491
• Update and rename Tags.md to Create-tags.md #38650
• Replace Image.getSize with react-native-image-size #38746
• [TS migration] Migrate 'CustomStatus' page to TypeScript #38797
• fix: Room - WS is not selected when filtered from newdot. #38861
• Fix - Multilevel tags - "no longer valid" violation is shown after selecting all the tags #38881
• fix: draft message sync issue #38912
• update MentionUserRenderer.tsx display text #38957
• Fix anchor text can't show both underline (link style) and line through (delete style while offline) on iOS #38985
• Fix mark as complete button shows up on cancelled task report #38991
• Fix violation shows optimistically for a partial transaction #39034
• Fix hover issue with ButtonWithDropdownMenu #39054
• nested quote for editing message #39096
• Update dependencies to fix vulnerability #39131
• Update HOW_TO_BECOME_A_CONTRIBUTOR_PLUS.md #39134
• [No QA] Update type of employee list to indicate it's an array of PolicyMembers #39148
• Fix/39053: Distance- Blank space above waypoints when transitioning #39151
• Fix created action is duplicate when assigning a task #39152
• #39057 - Members list does not update to show the new admin and owner #39159
• fix company website field missing https #39162
• Fix LHN preview does not show request description for request with description #39208
• [Feature Request]: Update the @here text to change "Notify everyone online in this room" to "Notify everyone in this conversation" #39221
• Fix infinite loading on invite and task assignee page after refresh #39223
• fix: Description/Merchant does not show in request preview. #39228
• Fix pending delete room members are not strikethrough-ed #39231
• Fix exit survey page displays blank #39232
• [No QA] Fix GH staging deploy action #39233
• [Fix] App crashes when entering an emoji inside three backticks code block #39259
• [NoQA] fix: temporarily disable comment linking test (e2e) #39279
• Video playback speed change should not move to next video #39292
• improvement: Use Const for 'violation' everywhere we check for violation type. #39298
• fix: Task - No error of exceeding limit when changing title of existing task & system message posted #39310
• [No QA] Use one API call when receiving push notifications #39375
• [NoQA] Make sure the reassure tests are triggered on push to main #39392
• Revert "Revert "feat: Upgrade VisionCamera to V4"" #39396
• [CP Staging] Fix opening receipt page from IOU report leads to not found page #39419
• [CP Staging] Ensure we don't show optimistic preview action for one-transaction reports #39433
• [CP Staging] Show delete option for requests on one transaction view #39449
• Support markdown for description preview #39466
• [CP Staging] Filter out also Send money actions in the one expense view #39499
• Fix report preview LHN subtitle shown as multiline #39525
• [CP Staging] Remove the requestIdleCallback from silentComposer #39535
• Fix user can save address without zip code even when the country requires zip code #39486

Deploy Blockers:

• [HOLD for payment 2024-04-15] IOU - Skeleton IOU preview appears in IOU details page when there is one request #39403
• [HOLD for payment 2024-04-15] [$500] IOU - Opening IOU receipt leads to not here page #39404
• IOU - No option to delete IOU request when there is only one request #39405
• [$500] Unable to mark system message unread in one transaction view #39407
• Web - Scan receipt - Banner in header with Scanning and prompt are missing #39414
• [HOLD for payment 2024-04-15] IOU - Combined report appears briefly when navigating to IOU report from transaction thread #39418
• [HOLD for payment 2024-04-15] [$500] IOU - Unable to dismiss error message in combined report by clicking X button #39420
• [$500] Attachment - 'New message' button appears when deleting attachment #39421
• Task – Assignee custom name is not visible in the task #39426
• IOU - Add receipt thumbnail is grayed out in combined report but not in transaction thread #39427
• [HOLD for payment 2024-05-20] [$125] Workspace - Impossible to change workspace currency #39435
• [HOLD for payment 2024-04-15] [$500] IOU - Replace receipt option is available for requestee in combined IOU report #39436
• [HOLD for payment 2024-04-15] [$500] IOU - Multiline IOU description from 1:1 DM in LHN is not truncated #39437
• IOU-Comment from a deleted IOU disappears until a third IOU is created #39438
• [HOLD for Payment 2024-04-30] [$500] BA - Disconnected bank account is still displayed on bank account preview on Workflows page #39439
• [Awaiting Payment 23rd April] [$500] Web-Workspace -Number of announce room members does not update when remove workspace members #39446
• [$250] IOU - Green dot shows up in LHN briefly when requeting money from another user #39447
• [HOLD for payment 2024-06-05] [One expense reports] System message for request edit does not show up in LHN when there is a single request #39450
• [HOLD for payment 2024-04-15] IOU - IOU preview in the main chat does not support mark down, while IOU report supports it #39451
• [C+ Checklist Needs Completion] [$250] Distance - Transaction thread opens after saving distance edit when there is only one request #39457
• Expense - Missing react & reply in thread for system message in one transaction report view #39459
• [$250] Distance - Expense report turns blank when distance is requested offline and returning online #39461
• [Payment due April 30th] [$500] Expense - Request disappears when deleted offline and there are two requests #39462
• [HOLD for payment 2024-04-15] [$250] Send money - IOU preview appears in one transaction report view #39490
• [HOLD] IOU - Missing Hold request, Replace and Delete receipt option when there is one IOU request #39491
• [$250] Scan - Replace receipt option is present when request is still scanning in one transaction view #39494
• IOU - IOU preview briefly displayed when navigating via deeplink & blank space below transaction #39509
• IOU - Comment on a deleted IOU isn't opening from the combined report view #39512
• [$250] Web/Desktop - Conversation - The email is not displayed when observe from other devices #39554
• Group Chat - Second created group chat, doesn´t appear in the chats list #39561
• [$500] Web - Group Conversation - There are redundant lines in mention popup when mention @... #39564

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[luacmartins]

Demoted #39426.

[marcaaron]

Demoting #39427

[roryabraham]

reproduced #39447 in prod, demoting it

[kavimuru]

Regression is 5% left in the TR
#38797 failing with #39409 repro in PROD checking it off
#39259 failing with #39425 repro in PROD checking it off

[francoisl]

Demoted #39438, same behavior as in production.

[marcaaron]

Demoted #39462

[marcaaron]

Checking off #39404 as a fix was CP'd to staging.

[mountiny]

Demoted #39459 I dont think its a blocker for deploy

[kavimuru]

Regression is completed in TestRail.
unchecked PRs:
#35833 failing with #39403
#38985 failing with #39307
#39034 failing with #39416 repro in PROD checking it off
#39151 pending validation in Desktop
CPs validations #39433 and #39419 pending in Desktop platform.

[kavimuru]

Regression is completed.

unchecked PRs:
#35833 failing with #39403
#38985 failing with #39307

Open Blockers:
#39407
#39421
#39436
#39437
#39446
#39451
#39461
#39490
#39491
#39494
#39509
#39512

[jasperhuangg]

Checking off #39407 NAB

[jasperhuangg]

Checking off #39446 NAB

[amyevans]

Demoting #39494

[NikkiWines]

Demoting #39512

[jasperhuangg]

Checking off #39421 repro on prod

[chiragsalian]

I've checked off #39437. Reasoning.

[aldo-expensify]

Checked off #39451, the fix has been CPed

[luacmartins]

Checking off #39554. Demoted to NAB>

[aldo-expensify]

Checked #39561 off since it is expected behaviour

[jasperhuangg]

Demoting #39564 NAB

[jasperhuangg]

Checking off #39499 tested myself and QA'd successfully

[jasperhuangg]

Demoting #39461 it is a back-end issue

[jasperhuangg]

[jasperhuangg]

Hmm for whatever reason #39436 was checked off of the deploy blocker list when it wasn't handled yet

[jasperhuangg]

Checked off #39436 deemed NAB

[jasperhuangg]

[jasperhuangg]

[jasperhuangg]

[jasperhuangg]

[Beamanator]

Adding #39486 to checklist b/c it snuck into staging 😅

[Beamanator]

Ok we tested #39486 internally (here) & it's looking good 👍 checking it off!

[Beamanator]

[Beamanator]