[HOLD for payment 2024-04-15] [$500] IOU - Replace receipt option is available for requestee in combined IOU report

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Go to chat with User B that has no unsettled IOU.
3. [User A] Request money from User B and attach a receipt.
4. [User B] Go to combined IOU report with User A.
5. [User B] Click on the receipt.
6. [User B] Click 3-dot menu.

Expected Result:

There will be no Replace receipt option for User B (requestee).

Actual Result:

Replace receipt option is available for User B (requestee).
This issue only happens in combined IOU report.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435778_1712075771965.20240403_003243.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e259e1fb396c9678
• Upwork Job ID: 1775695048648724480
• Last Price Increase: 2024-04-04

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Replace receipt option is available for User B (requestee).
This issue only happens in combined IOU report.

What is the root cause of that problem?

When we open the receipt in combine report, the reportID in URL is the expense report so canEditReceipt check is wrong here because the parentReportAction now is the report preview action.

App/src/components/ReportActionItem/ReportActionItemImage.tsx

Lines 98 to 101 in 879378f

	{({report}) => (
	<PressableWithoutFocus
	style={[styles.w100, styles.h100, styles.noOutline as ViewStyle]}
	onPress={() => Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(report?.reportID ?? '', transaction?.transactionID ?? ''))}

App/src/pages/TransactionReceiptPage.tsx

Line 36 in 879378f

const canEditReceipt = ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.RECEIPT);

What changes do you think we should make in order to solve the problem?

We should get the transactionReportID and pass it as reportID param of getRoute function here. So all check in TransactionReceiptPage will work well even if we open the receipt in combine report.

App/src/components/ReportActionItem/ReportActionItemImage.tsx

Lines 98 to 101 in 879378f

	{({report}) => (
	<PressableWithoutFocus
	style={[styles.w100, styles.h100, styles.noOutline as ViewStyle]}
	onPress={() => Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(report?.reportID ?? '', transaction?.transactionID ?? ''))}

To do that we should store transactionThreadReport or transactionThreadReportID in ShowContextMenuContext.

1. Add transactionThreadReport in ShowContextMenuContextProps

type ShowContextMenuContextProps = {
    ...
    transactionThreadReport: OnyxEntry<Report>;
};

const ShowContextMenuContext = createContext<ShowContextMenuContextProps>({
    ...
    transactionThreadReport: null
});

App/src/components/ShowContextMenuContext.ts

Line 12 in 879378f

type ShowContextMenuContextProps = {

2. Store transactionThreadReport into contextValue here.

App/src/pages/home/report/ReportActionItem.tsx

Line 364 in 879378f

const contextValue = useMemo(

3. Here, get transactionThreadReport and pass transactionThreadReport.reportID to getRoute function

{({report, transactionThreadReport}) => (
    <PressableWithoutFocus
        style={[styles.w100, styles.h100, styles.noOutline as ViewStyle]}
        onPress={() => Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(transactionThreadReport?.reportID ?? report?.reportID ?? '', transaction?.transactionID ?? ''))}
        accessibilityLabel={translate('accessibilityHints.viewAttachment')}
        accessibilityRole={CONST.ROLE.BUTTON}
    >
        <ReceiptImage {...propsObj} />
    </PressableWithoutFocus>
)}

App/src/components/ReportActionItem/ReportActionItemImage.tsx

Lines 98 to 101 in 879378f

	{({report}) => (
	<PressableWithoutFocus
	style={[styles.w100, styles.h100, styles.noOutline as ViewStyle]}
	onPress={() => Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(report?.reportID ?? '', transaction?.transactionID ?? ''))}

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e259e1fb396c9678

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[jasperhuangg]

I don't think this is worth blocking deploy on this as we're marking other bugs related to the combined IOU report view as non-blockers.

[nkdengineer]

@jasperhuangg The PR is here

[abdulrahuman5196]

@jasperhuangg Wanted to check if C+ is needed here? Seems I was removed and deployment blocker is also removed?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix three-dot menu item display incorrectly when opening receipt in combine report #39572

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @alexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $500 via NewDot
• ROLE: @nkdengineer paid $500 via Upwork (LINK)

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1775695048648724480/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[alexpensify]

@nkdengineer - I've sent an offer via Upwork. Please accept and I can complete the payment process. Thanks!

[alexpensify]

Closing, I was able to complete the payment to @nkdengineer. @allroundexperts please submit a request in Chat. Thanks!

[JmillsExpensify]

$500 approved for @allroundexperts