[TS migration] Migrate 'NewChatSelector' page to TypeScript... #38441
Conversation
melvin-bot
bot
requested review from
sobitneupane
and removed request for
a team
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Hey @sobitneupane @blazejkustra. Why is CLA failing again? I did everything right. |
|
@MahmudjonToraqulov You are required to upload screen recordings for all the platforms. |
The issue should be resolved once internal engineer approves the workflow to run. |
src/pages/NewChatSelectorPage.tsx
Outdated
| > | ||
| <TopTab.Screen | ||
| name={CONST.TAB.NEW_CHAT} | ||
| // @ts-expect-error TODO: 'isGroupChat' is declared here. |
There was a problem hiding this comment.
Let's remove this ts expect error, instead let's make isGroupChat optional
| shouldEnableKeyboardAvoidingView={false} | ||
| includeSafeAreaPaddingBottom={false} | ||
| shouldShowOfflineIndicator={false} | ||
| shouldEnableMaxHeight | ||
| testID={NewChatSelectorPage.displayName} | ||
| > | ||
| <HeaderWithBackButton | ||
| title={props.translate('sidebarScreen.fabNewChat')} | ||
| onBackButtonPress={navigation.goBack} |
There was a problem hiding this comment.
Why was this removed?
There was a problem hiding this comment.
I copied and pasted last changes. Maybe this caused some issues. I'll fix them.
src/pages/NewChatSelectorPage.tsx
Outdated
| return ( | ||
| <ScreenWrapper | ||
| <ScreenWrapper |
There was a problem hiding this comment.
Is there a space added? 🤔
There was a problem hiding this comment.
I copied and pasted last changes. Maybe this caused some issues. I'll fix them.
src/pages/NewChatSelectorPage.tsx
Outdated
| tabBar={({state, navigation, position}) => ( | ||
| <TabSelector | ||
| state={state} | ||
| navigation={navigation} | ||
| position={position} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
| tabBar={({state, navigation, position}) => ( | |
| <TabSelector | |
| state={state} | |
| navigation={navigation} | |
| position={position} | |
| /> | |
| )} | |
| tabBar={TabSelector} |
There was a problem hiding this comment.
Ok. Will do it.
|
Hey @blazejkustra. I made requested changes. You could check it. |
|
@sobitneupane All yours! |
|
I'll upload screen recordings for all the platforms soon. |
|
@MahmudjonToraqulov In addition to this, there are some lint issues in the PR, you can check with |
|
@MahmudjonToraqulov bump |
Ok. |
Sorry for the delay. I'm having some issues while tryiing to run Android Native. |
I'm getting this error while trying " |
I have made commit to fix that. |
@MahmudjonToraqulov You can upload video for other platforms. I will test in android. |
I did it with Desktop and Macos Chrome. Right now I cannot with IOS and Android as I said, but I'm trying to solve it. |
Nope. You need to test it either on Simulator or on real device. |
|
Hey team. Screenshots for ios will bé ready till eod or tomorrow. I am on
it now.
…On Fri, Mar 22, 2024, 16:22 Sobit Neupane ***@***.***> wrote:
I did it with Desktop and Macos Chrome. Right now I cannot with IOS and
Android as I said, but I'm trying to solve it.
Can I test IOS chrome and Android chrome on my Macos browser?
Nope. You need to test it either on Simulator or on real device.
—
Reply to this email directly, view it on GitHub
<#38441 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV32OQ3AWWHYQQ53H27EQEDYZQH6HAVCNFSM6AAAAABEZNYXTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJUHA3TKOJVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
@MahmudjonToraqulov Looks like there are still some issues to be handled. Styling of tab selector is off.
|
@sobitneupane I commited new changes. Pls check it and tell me. And one more thing. I tried so many ways to test the App but didn't help yet. Could you help me testing it if you don't mind? |
What do you mean? It doesn't work? |
|
It is first time that I am trying to run ios or Android app. Só I am having
some troubles with installing necessary tools or packages. I need help to
solve the issues or some time to fix that. If you guide me or give help to
solve the problems I would appreciate it.
…On Tue, Mar 26, 2024, 22:15 Błażej Kustra ***@***.***> wrote:
And one more thing. I tried so many ways to test the App but didn't help
yet.
What do you mean? It doesn't work?
—
Reply to this email directly, view it on GitHub
<#38441 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV32OQ36YLDONCJA45TP6YTY2GNJTAVCNFSM6AAAAABEZNYXTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRRGAZDMMZUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Screenshots/Videos
Android: Native
Screen.Recording.2024-03-27.at.12.23.21.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2024-03-27.at.12.15.18.mov
iOS: mWeb Safari
Screen.Recording.2024-03-27.at.12.12.22.mov
MacOS: Chrome / Safari
MacOS: Desktop
Screen.Recording.2024-03-27.at.12.13.55.mov
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #31989 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
| @@ -34,6 +37,7 @@ export const TopTab = createMaterialTopTabNavigator(); | |||
| // except ID is now required, and it gets a `selectedTab` from Onyx | |||
| function OnyxTabNavigator({id, selectedTab = '', children, onTabSelected = () => {}, screenListeners, ...rest}: OnyxTabNavigatorProps) { | |||
| return ( | |||
| // @ts-expect-error: Types of property 'tabBar' are incompatible. | |||
There was a problem hiding this comment.
Why are we creating an exception here? Shouldn't we be fixing the actual issue?
There was a problem hiding this comment.
Ok. I'll fix it.
There was a problem hiding this comment.
You could try assertion here, instead of ts-expect-error
tabBar={tabBar as (props: MaterialTopTabBarProps) => React.ReactNode}There was a problem hiding this comment.
Or better, fix TabSelectorProps type 😄
There was a problem hiding this comment.
You could try assertion here, instead of ts-expect-error
You mean I should use it inside <TopTab.Navigator?
There was a problem hiding this comment.
It's giving me an error then like the pic.
There was a problem hiding this comment.
You didn't destruct tabBar from props 😅
There was a problem hiding this comment.
I think TabSelectorProps is broken, try this:
type TabSelectorProps = MaterialTopTabBarProps & {
/* Callback fired when tab is pressed */
onTabPress?: (name: string) => void;
};There was a problem hiding this comment.
With no changes in TabNavigator
|
@MahmudjonToraqulov You forgot to run prettier on the PR, files aren't formatted properly |
I'll do it. |
|
@stitesExpensify All yours again 😄 |
|
@MahmudjonToraqulov When was the last time you merged main here? 🙈 |
|
@stitesExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.59-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀
|
Details
Migrated 'NewChatSelector' page to TypeScript
Fixed Issues
$ #31989
PROPOSAL: #31989 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
2024-01-22.05-28-21.mp4
MacOS: Desktop
2024-01-22.05-35-14.mp4