Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - No option to delete IOU request when there is only one request #39405

Closed
6 tasks done
kbecciv opened this issue Apr 2, 2024 · 7 comments
Closed
6 tasks done

IOU - No option to delete IOU request when there is only one request #39405

kbecciv opened this issue Apr 2, 2024 · 7 comments
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Request money.
  3. Create a manual request from any user that has no unsettled IOU.
  4. In 1:1 DM, click on the IOU preview.
  5. Click 3-dot menu.

Expected Result:

There will be option to delete IOU request when there is only one request.

Actual Result:

There is no option to delete IOU request when there is only one request.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435484_1712058106879.delete_single_IOU.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Apr 2, 2024

We think that this bug might be related to #wave-collect - Release 1

@mountiny
Copy link
Contributor

mountiny commented Apr 2, 2024

cc @NikkiWines

I think this is coming from the one transaction view PR which hit staging #36934

@NikkiWines
Copy link
Contributor

Oh yeah, I don't think we considered this case actually 🤔 - this and holding requests won't be visible because we're displaying the MoneyReportHeader not the MoneyRequestHeader at this level. I'll spin up a fix

@NikkiWines NikkiWines self-assigned this Apr 2, 2024
@mountiny mountiny removed their assignment Apr 2, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 2, 2024

Nikki is handling ❤️ so unassigning

@NikkiWines
Copy link
Contributor

Works on staging now! 🚀

Screen.Recording.2024-04-02.at.16.32.41.mov

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants