Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - IOU preview briefly displayed when navigating via deeplink & blank space below transaction #39509

Closed
2 of 6 tasks
lanitochka17 opened this issue Apr 3, 2024 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 3, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.59-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4471359
Issue reported by: Applause - Internal Team

Action Performed:

precondition: user created one IOU and copied the link

  1. Log out of ND
  2. Using the deeplink navigate to the IOU report
  3. Log in with the account used to create the IOU

Expected Result:

The combined expense view is displayed

Actual Result:

IOU preview is displayed briefly. After the combined expense view is opened, there is a blank space below the transaction details (iOS). It disappears after scrolling

Workaround:

Unkn0wn

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6436775_1712152861881.IMG_6165.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 3, 2024
Copy link

melvin-bot bot commented Apr 3, 2024

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@bondydaa
Copy link
Contributor

bondydaa commented Apr 3, 2024

Trying to reproduce this, this is what I see after I create a new IOU report between 2 users:

image

copying this url https://staging.new.expensify.com/r/4716128617010173 then and logging into a new incognito browser: i see
image

Here's a video: https://github.com/Expensify/App/assets/4073354/f07008a1-40fb-49af-aff5-33f3497b92b6

But you're saying I should see this?
image

I am able to view that report if I use this url https://staging.new.expensify.com/r/6436117858044165 instead.

@bondydaa
Copy link
Contributor

bondydaa commented Apr 3, 2024

using that same url https://new.expensify.com/r/4716128617010173 for prod takes me to
image

@bondydaa bondydaa added the Bug Something is broken. Auto assigns a BugZero manager. label Apr 3, 2024
Copy link

melvin-bot bot commented Apr 3, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@bondydaa
Copy link
Contributor

bondydaa commented Apr 3, 2024

@lschurr can you help me out here and confirm if this happens on iOS? I don't have any iOS devices to test with.

I'm not exactly sure either on what the behavior is, as best I can tell depending on the link you use it seems to redirect properly after you sign in.

@lschurr
Copy link
Contributor

lschurr commented Apr 3, 2024

Hmmm I'm having a hard time reproducing. I grabbed the link from web via lschurr@expensifail.com and opened it on iOS and got this screen:

image

Seems correct to me?

@bondydaa bondydaa removed the DeployBlockerCash This issue or pull request should block deployment label Apr 3, 2024
@bondydaa
Copy link
Contributor

bondydaa commented Apr 3, 2024

Okay we've been discussing internally here https://expensify.slack.com/archives/C036QM0SLJK/p1712164922552349.

We've slightly updated how IOU reports work. If there is only 1 request then we show the details of that request when viewing the IOU report.
image (16)

If there are 2+ then we show more "chat style" rows
image (15)

Note that this reportID in the screenshots is both r/6436117858044165 which I believe is called the IOU Report (or possibly just a expense report 🤷 ).

reportID r/4716128617010173 from my previous screenshots is the "chat report" which will only ever contain a preview.

@bondydaa
Copy link
Contributor

bondydaa commented Apr 3, 2024

okay after figuring all of that out, i see now what your video is showing that the chat report with the preview opens very briefly first before showing the IOU / expense report view of the single expense. trying to test this again on browserstack

@bondydaa
Copy link
Contributor

bondydaa commented Apr 3, 2024

Hmm okay I can't reproduce this and @mountiny and @NikkiWines agreed this wasn't a blocker. I'm going to close it out but if others can reproduce it then feel free to reopen

@bondydaa bondydaa closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants