[Payment due April 30th] [$500] Expense - Request disappears when deleted offline and there are two requests

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by:

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace so there's no historical Money Requests.
3. Find the workspace chat in the LHN
4. Create two manual requests.
5. Go offline.
6. Delete one of the requests.

Expected Result:

The request preview will be crossed out when it is deleted offline.

Actual Result:

The request preview is not crossed out when it is deleted offline. The preview is completely gone and user lands in one transaction report view.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6436037_1712089830389.20240403_042404.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0183d791d32effd8ba
• Upwork Job ID: 1775340953844273152
• Last Price Increase: 2024-04-03

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[marcaaron]

This does not feel like a blocker to me.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Christinadobrzyn]

I can reproduce with the steps in the OP - I think this can be external and should be part of wave-collect.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0183d791d32effd8ba

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The request preview is not crossed out when it is deleted offline. The preview is completely gone and user lands in one transaction report view.

What is the root cause of that problem?

In here, we don't have condition to include pending delete money request. So when we delete the money request and set the IOUTransactionID to null here, getOneTransactionThreadReportID will return the reportID of the remaining money request and it will show the single transaction view.

What changes do you think we should make in order to solve the problem?

In here, add condition to include pending delete money request.

(action.originalMessage.IOUTransactionID || action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE),

Or we can include pending delete money request only if the user is offline (same condition to show the striked-through money request in the IOU report):

(action.originalMessage.IOUTransactionID || (action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && isOffline)),

(We'll need to pass isOffline to getOneTransactionThreadReportID, and add the isOffline to the memo list here so the report screen will be rerendered if the network status changes, to reflect the correct single transaction view immediately)

What alternative solutions did you explore? (Optional)

NA

[Christinadobrzyn]

@allroundexperts can you review the proposal for us? #39462 (comment)

Thanks!

[allroundexperts]

@nkdengineer's proposal looks good to me. Let's stick to the condition we are already using in the IOU report.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[NikkiWines]

Yep, looks good!!

[melvin-bot]

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@allroundexperts The PR is here.

[Christinadobrzyn]

PR in production. adding a payment date to the Title.

[Christinadobrzyn]

Whoops! Payouts due:

• Contributor: $500 @nkdengineer (Paid in Upwork - https://www.upwork.com/nx/wm/offer/102145438)
• Contributor+: $500 @allroundexperts (Paid through NewDot)

Upwork job is here.

@allroundexperts @nkdengineer can you please accept the above offers?

Can you let me know about a regression test?

[allroundexperts]

Hi @Christinadobrzyn!

I think a regression test would be helpful here. Here are the test steps:

1. Login and Create a workspace so there's no historical Money Requests.
2. Find the workspace chat in the LHN
3. Create two manual requests.
4. Go offline.
5. Delete one of the requests.

Verify that the request preview is crossed out when it is deleted offline.

Do we 👍 or 👎 ?

[nkdengineer]

@Christinadobrzyn I accepted the offer 🙏

[Christinadobrzyn]

Regression test here - https://github.com/Expensify/Expensify/issues/393728

@nkdengineer paid you in Upwork based on this payment summary - #39462 (comment)
@allroundexperts are you paid in NewDot or in Upwork (if Upwork can you accept this offer) TY!

[allroundexperts]

@Christinadobrzyn It's ND for me!

[Christinadobrzyn]

Awesome! Thanks for confirming!

Payment summary here - #39462 (comment)

This is ready to be closed. Let me know if I missed anything!

[JmillsExpensify]

$500 approved for @allroundexperts