[HOLD for payment 2024-04-15] IOU - Combined report appears briefly when navigating to IOU report from transaction thread

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Request money from a user that has no unsettled request.
3. Create another IOU with the same user.
4. Go to transaction details of one of the requests.
5. Add some comments.
6. Click on the header subtitle to return to IOU report.

Expected Result:

Combined report will not appear since there are more than one requests.

Actual Result:

Combined report appears briefly when navigating to IOU report from transaction thread.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6435642_1712067627162.20240402_221321.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@isabelastisser I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

Recording.2332.mp4

[NikkiWines]

Pretty sure this is tied to #39403 - seems like a similar bug. I'll work on a fix now 👍

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[NikkiWines]

This is at least improved on staging where it's a much shorter loading period but will still look into resolving this fully 🤔

Screen.Recording.2024-04-02.at.15.15.41.mov

[NikkiWines]

However, I think this can be a polish since it requires someone going through some niche steps to experience and won't be super easily found by users going through a normal flow

[NikkiWines]

I'm not seeing this behavior on staging any more - let's close this out and if it pops up again it's a good external issue:

Screen.Recording.2024-04-05.at.18.33.45.mov

Screen.Recording.2024-04-05.at.18.35.09.mov

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Ensure we don't show optimistic preview action for one-transaction reports #39433

If no regressions arise, payment will be issued on 2024-04-15. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@NikkiWines] The PR that introduced the bug has been identified. Link to the PR: [HOLD for payment 2024-04-15] IOU - Skeleton IOU preview appears in IOU details page when there is one request #39403
• [@NikkiWines] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A, it was a bug due to not modifying code, not code that the PR had changed. We missed that flow in the original PR.
• [@NikkiWines] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@NikkiWines] Determine if we should create a regression test for this bug. N/A
• [@NikkiWines] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: