Task – Assignee custom name is not visible in the task

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4468742
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Go to any chat
4. Create a task and assign it to a user with a custom name

Expected Result:

Assignee custom name is visible in the task

Actual Result:

Assignee custom name is not visible in the task

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435740_1712073273274.Name.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018a6cf192e2c42cc8
• Upwork Job ID: 1775237848166469632
• Last Price Increase: 2024-04-02

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[luacmartins]

Taking a look now

[luacmartins]

I believe this is caused by #38957

[luacmartins]

I'm gonna demote this as a blocker since it doesn't really affect the functionality that much and let the original contributor work on a fix.

[luacmartins]

@ahmedGaber93 could you please work on a fix for this regression since it comes from your PR? cc @sobitneupane @puneetlath

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018a6cf192e2c42cc8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[luacmartins]

Reassigning to @sobitneupane since they reviewed the offending PR.

[ahmedGaber93]

@ahmedGaber93 could you please work on a fix for this regression since it comes from your PR?

I will take a look, but about the expected behavior, we decide based on here #38079 (comment) and here #38079 (comment) to prioritize login over display name for all the mentions in the app including task preview.
@luacmartins

[luacmartins]

Hmm so is this the new expected behavior @puneetlath ?

[puneetlath]

Yes, this is expected. We decided to make mentions consistent and always look the same, including in task previews. We should update whatever testrail test is currently testing this for that. I'll post in #qa.

[luacmartins]

Thanks for confirming. Seems like we can just close this issue then!

[isagoico]

TC has been updated to reflect this new behavior🎉

[puneetlath]

Great, thanks @isagoico!