Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Scan receipt - Banner in header with Scanning and prompt are missing #39414

Closed
1 of 6 tasks
kbecciv opened this issue Apr 2, 2024 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4468880
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the App
  2. Navigate to the workspace chat as the employee
  3. Select the option to Request money > Scan receipt
  4. Select the option to upload a receipt
  5. Upload a receipt file
  6. Click on Request

Expected Result:

When opening request details, there's a banner in the header indicating the scan is in progress and "Only you can see this receipt when it's scanning. Check back later or enter the details now."

Actual Result:

When opening the request details, "NextStep" These expenses are scheduled to automatically submit on Sunday! No further action required! This report may be selected at random for manual approval. is displayed.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435553_1712061712632.missingbannerprompt.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Apr 2, 2024

Not reproducible in Production

prodscan.1.mp4

image

@kbecciv
Copy link
Author

kbecciv commented Apr 2, 2024

We think that this bug might be related to #wave-collect - Release 1

@NikkiWines
Copy link
Contributor

This is tied to #36934 and we'll need to have a larger discussion on how to handle the combined status header for the moneyReuqest and moneyReport for a one-transaction view

cc: @shawnborton

@NikkiWines
Copy link
Contributor

I don't think we should block on this personally but it'll definitely need to be updated.

@shawnborton
Copy link
Contributor

Sounds good - can you raise that discussion in the #vip-split room and we can discuss from there? I think we would just add the banner to the report view and add "Scanning in progress" in place of the amount, much like we do in the preview card. Thoughts?

@AndrewGable AndrewGable added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 2, 2024
@NikkiWines
Copy link
Contributor

NikkiWines commented Apr 2, 2024

Yep, currently fixing the blockers that can be resolved more quickly but will raise it afterwards.

@AndrewGable AndrewGable assigned NikkiWines and unassigned AndrewGable Apr 2, 2024
@NikkiWines
Copy link
Contributor

Posted here

@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
@NikkiWines NikkiWines added the Improvement Item broken or needs improvement. label Apr 6, 2024
@NikkiWines
Copy link
Contributor

Discussion is underway

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 6, 2024
@NikkiWines
Copy link
Contributor

Discussion is still ongoing, dropping to weekly until we get a consensus

@NikkiWines NikkiWines added Weekly KSv2 and removed Daily KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2024
@NikkiWines
Copy link
Contributor

Going to close this out in favour of #39989 that arose as part of the aforementioned slack discussion.

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants