-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - Scan receipt - Banner in header with Scanning and prompt are missing #39414
Comments
Triggered auto assignment to @AndrewGable ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #wave-collect - Release 1 |
This is tied to #36934 and we'll need to have a larger discussion on how to handle the combined status header for the moneyReuqest and moneyReport for a one-transaction view cc: @shawnborton |
I don't think we should block on this personally but it'll definitely need to be updated. |
Sounds good - can you raise that discussion in the #vip-split room and we can discuss from there? I think we would just add the banner to the report view and add "Scanning in progress" in place of the amount, much like we do in the preview card. Thoughts? |
Yep, currently fixing the blockers that can be resolved more quickly but will raise it afterwards. |
Posted here |
Discussion is underway |
Discussion is still ongoing, dropping to weekly until we get a consensus |
Going to close this out in favour of #39989 that arose as part of the aforementioned slack discussion. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4468880
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
When opening request details, there's a banner in the header indicating the scan is in progress and "Only you can see this receipt when it's scanning. Check back later or enter the details now."
Actual Result:
When opening the request details, "NextStep" These expenses are scheduled to automatically submit on Sunday! No further action required! This report may be selected at random for manual approval. is displayed.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6435553_1712061712632.missingbannerprompt.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: