[$250] Web/Desktop - Conversation - The email is not displayed when observe from other devices

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.59-4
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): nhut.nguyenminh.it+4@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-condition: Login account two 2 devices, which we call A and B

1. Open the app on two devices
2. At A, search new account and send a message to it
3. Next, send a message to another conversation or waiting for B's update

Expected Result:

The email display when observed from another device

Actual Result:

The email is not displayed when observe from other devices

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6436627_1712143125440.Screen_Recording_2024-04-03_at_18.09.05.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0178de70068aa79d6d
• Upwork Job ID: 1775663285261606912
• Last Price Increase: 2024-04-08

Issue Owner

Current Issue Owner: @aldo-expensify

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

Production

Staging

[luacmartins]

I'm gonna demote this to NAB since it's a bit of an edge case where users need to be online in 2 devices at the same time looking at the LHN.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0178de70068aa79d6d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[bernhardoj]

It's a BE issue, the pusher sends the report data but not the personal details.

[melvin-bot]

Current assignee @getusha is eligible for the Internal assigner, not assigning anyone new.

[garrettmknight]

@luacmartins pinged in the PR that might have caused this. I'll keep monitoring there.

[aldo-expensify]

After investigating a bit, I think it was the removal of ReportAPI:pushNewChat here: https://github.com/Expensify/Web-Expensify/pull/41492/files#diff-226c5d32da881d917aecc36ba4f92b77971699b9ed01f2962c14f05995b939d8L3779-L3809

I thought that function was just pushing the report, but I see now that it is really pushing onyxData which I think by that point already contain the personal details too.

[aldo-expensify]

@luacmartins I can take this from you if you want, since I think I caused it. I think the ideal fix would be to put the personal details push in Auth.

[luacmartins]

Go ahead, it seems like you're more familiar with that code than I am. Thanks!

[aldo-expensify]

I think this is fixing it: https://github.com/Expensify/Auth/pull/10461, I'll write some tests and make it ready for review after

[melvin-bot]

@garrettmknight, @luacmartins, @getusha, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[aldo-expensify]

Retested, it is working now