[$250] Scan - Replace receipt option is present when request is still scanning in one transaction view

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4468886
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat that has no unsettled request.
3. Create a scan request
4. While the scanning is ongoing, click on the receipt.
5. Click 3-dot menu.
6. Note that Replace option is present.
7. Create a second scan request.
8. Click 3-dot menu.
9. Note that Replace option is actually not present for request that is still scanning.

Expected Result:

In Step 5, there should not be Replace option for the request that is still scanning.

Actual Result:

In Step 5, Replace receipt option is available for the request that is still scanning. Clicking on it leads to not here page. This only happens when there is one transaction.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6436635_1712143969929.bandicam_2024-04-03_19-28-07-637.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d008a7eab4bb0c77
• Upwork Job ID: 1775595658777747456
• Last Price Increase: 2024-04-10
• Automatic offers:
• shubham1206agra | Contributor | 0

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[amyevans]

This seems like a rather minor bug coming out of the One Transaction View feature, so going to demote it to not block deploy and open it up for proposals. cc @NikkiWines though for visibility, in case you disagree or have any context to add!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d008a7eab4bb0c77

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Upwork job price has been updated to $250

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User can replace receipt while the request is scanning

What is the root cause of that problem?

The receipt replace action is not disabled if the request is scanning in the canEditFieldOfMoneyRequest function

What changes do you think we should make in order to solve the problem?

we need to move these vars on top in order to use the transaction and check whether the transaction is being scanned or not

App/src/libs/ReportUtils.ts

Lines 2391 to 2393 in 338aeff

	const iouMessage = reportAction?.originalMessage as IOUMessage;
	const moneyRequestReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${iouMessage?.IOUReportID}`] ?? ({} as Report);
	const transaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${iouMessage?.IOUTransactionID}`] ?? ({} as Transaction);

then add the following condition to return false if the transaction is being scanned:

    if (TransactionUtils.isReceiptBeingScanned(transaction)) {
        return false;
    }

POC

Screen.Recording.2024-04-03.at.9.00.31.PM.mov

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 5, Replace receipt option is available for the request that is still scanning. Clicking on it leads to not here page. This only happens when there is one transaction.

What is the root cause of that problem?

When there's one transaction in the IOU report, the MoneyRequestView that's being shown is actually the transactionThreadReport (can be seen here), this is because when there's only 1 transaction, we'll show the "single transaction view" in the IOU report.

However, when we're passing the contextValue down here, we're still passing the report as the iouReport, not the transactionThreadReport (see here).

This leads to this scanning check condition checking on an empty transaction, because it's getting transaction on the wrong report (the IOU report rather than transactionThreadReport)

What changes do you think we should make in order to solve the problem?

In contextValue here, use the transactionThreadReport as the report

<ShowContextMenuContext.Provider value={{
    ...contextValue,
    report: transactionThreadReport
}}>

The transactionThreadReport is the same report we passed to the wrapped MoneyRequestView here

What alternative solutions did you explore? (Optional)

We should also check other values in contextValue to make sure they are related to the correct report being shown (transactionThreadReport).

[twisterdotcom]

@Santhosh-Sellavel any of these proposals good to go?

[Santhosh-Sellavel]

@twisterdotcom This some how got missed from my radar. Can you reassign, I can't get to this quicker. Again sorry for the delay

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[shubham1206agra]

@twisterdotcom Can you ask QA to retest this?
This may have been fixed already.

[shubham1206agra]

But @nkdengineer solution is correct (in context passing sense) in some sense. We need to find the bug created if we don't apply the solution.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[izarutskaya]

Not reproduced in latest build
Build v1.4.62-0

bandicam.2024-04-11.13-37-45-106.mp4

[shubham1206agra]

Thanks for the confirmation.
@twisterdotcom We can close this.