[No QA][TS migration] migrate workflow tests #38491

SzymczakJ · 2024-03-18T16:42:48Z

Details

Fixed Issues

$ #32045
$ #32044
$ #32043
$ #32041
$ #32042
PROPOSAL: N/A

Tests

npm run workflow-test

Offline tests

QA Steps

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

BrtqKr · 2024-03-25T09:02:50Z

workflow_tests/mocks/testBuildMocks.ts

@@ -27,19 +27,19 @@ const TESTBUILD__VALIDATEACTOR__SET_HAS_READY_TO_BUILD_LABEL_FLAG__FALSE__STEP_M
 const TESTBUILD__VALIDATEACTOR__TEAM_MEMBER_HAS_FLAG__STEP_MOCKS = [
    TESTBUILD__VALIDATEACTOR__IS_TEAM_MEMBER__TRUE__STEP_MOCK,
    TESTBUILD__VALIDATEACTOR__SET_HAS_READY_TO_BUILD_LABEL_FLAG__TRUE__STEP_MOCK,
-] as const;


why remove as const? Those arrays aren't supposed to be modified, so that's fine in this file.

UPDATE: it's been causing erorrs, because it lacked satisfies StepIdentifier[]

BrtqKr · 2024-03-25T09:03:03Z

workflow_tests/mocks/validateGithubActionsMocks.ts

@@ -11,7 +11,7 @@ const VALIDATEGITHUBACTIONS__VERIFY__STEP_MOCKS = [
    VALIDATEGITHUBACTIONS__VERIFY__SETUP_NODE__STEP_MOCK,
    VALIDATEGITHUBACTIONS__VERIFY__VERIFY_JAVASCRIPT_ACTION_BUILDS__STEP_MOCK,
    VALIDATEGITHUBACTIONS__VERIFY__VALIDATE_ACTIONS_AND_WORKFLOWS__STEP_MOCK,
-] as const;


BrtqKr · 2024-03-25T09:03:12Z

workflow_tests/mocks/verifyPodfileMocks.ts

-    VERIFYPODFILE__VERIFY__SETUP_NODE__STEP_MOCK,
-    VERIFYPODFILE__VERIFY__VERIFY_PODFILE__STEP_MOCK,
-] as const;
+const VERIFYPODFILE__VERIFY__STEP_MOCKS = [VERIFYPODFILE__VERIFY__CHECKOUT__STEP_MOCK, VERIFYPODFILE__VERIFY__SETUP_NODE__STEP_MOCK, VERIFYPODFILE__VERIFY__VERIFY_PODFILE__STEP_MOCK];


BrtqKr · 2024-03-25T09:03:18Z

workflow_tests/mocks/verifySignedCommitsMocks.ts

@@ -9,7 +9,7 @@ const VERIFYSIGNEDCOMMITS__VERIFYSIGNEDCOMMITS__VERIFY_SIGNED_COMMITS__STEP_MOCK
    ['GITHUB_TOKEN'],
    [],
 );
-const VERIFYSIGNEDCOMMITS__VERIFYSIGNEDCOMMITS__STEP_MOCKS = [VERIFYSIGNEDCOMMITS__VERIFYSIGNEDCOMMITS__VERIFY_SIGNED_COMMITS__STEP_MOCK] as const;
+const VERIFYSIGNEDCOMMITS__VERIFYSIGNEDCOMMITS__STEP_MOCKS = [VERIFYSIGNEDCOMMITS__VERIFYSIGNEDCOMMITS__VERIFY_SIGNED_COMMITS__STEP_MOCK];


BrtqKr · 2024-03-25T09:10:42Z

workflow_tests/testBuild.test.ts

-const ExtendedAct = require('./utils/ExtendedAct').default;
+/* eslint-disable @typescript-eslint/naming-convention */
+
+/* eslint-disable @typescript-eslint/require-await */


why do you need this?

BrtqKr · 2024-03-25T09:12:10Z

workflow_tests/validateGithubActions.test.ts

-const assertions = require('./assertions/validateGithubActionsAssertions');
-const mocks = require('./mocks/validateGithubActionsMocks');
-const ExtendedAct = require('./utils/ExtendedAct').default;
+/* eslint-disable @typescript-eslint/require-await */


those functions didn't need async apparently, it didn't break the tests

BrtqKr · 2024-03-25T09:12:36Z

workflow_tests/verifyPodfile.test.ts

-const assertions = require('./assertions/verifyPodfileAssertions');
-const mocks = require('./mocks/verifyPodfileMocks');
-const ExtendedAct = require('./utils/ExtendedAct').default;
+/* eslint-disable @typescript-eslint/require-await */


BrtqKr · 2024-03-25T09:12:56Z

workflow_tests/verifySignedCommits.test.ts

-const assertions = require('./assertions/verifySignedCommitsAssertions');
-const mocks = require('./mocks/verifySignedCommitsMocks');
-const ExtendedAct = require('./utils/ExtendedAct').default;
+/* eslint-disable @typescript-eslint/require-await */


Skalakid

Added one small comment

Skalakid · 2024-03-25T09:12:04Z

workflow_tests/testBuild.test.ts

-const mocks = require('./mocks/testBuildMocks');
-const ExtendedAct = require('./utils/ExtendedAct').default;
+/* eslint-disable @typescript-eslint/naming-convention */
+


Remove new line here

fabioh8010 · 2024-03-25T17:01:05Z

@SzymczakJ Is this PR ready for cross-review?

SzymczakJ · 2024-03-26T17:21:41Z

@fabioh8010 sorry, a PR that I based on was reverted 😅 . Just fixed conflicts

fabioh8010

LGTM, but please merge with main and test if workflow tests are passing before opening (npm run workflow-test)

melvin-bot · 2024-03-27T15:36:03Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fabioh8010 · 2024-03-28T08:45:11Z

@mollfpr bump!

SzymczakJ · 2024-03-29T10:12:00Z

@mollfpr bump 😃

mollfpr · 2024-03-29T18:54:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

mollfpr

Sorry for the delay 🙏

melvin-bot · 2024-03-29T19:47:46Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #32045 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

mountiny · 2024-04-02T08:47:23Z

workflow_tests/assertions/validateGithubActionsAssertions.ts

@@ -19,4 +19,4 @@ function assertVerifyJobExecuted(workflowResult: Step[], didExecute = true) {
 }

 // eslint-disable-next-line import/prefer-default-export


Can we remove this eslint now?

mountiny · 2024-04-02T08:47:33Z

workflow_tests/assertions/verifyPodfileAssertions.ts

@@ -18,4 +18,4 @@ function assertVerifyJobExecuted(workflowResult: Step[], didExecute = true) {
 }

 // eslint-disable-next-line import/prefer-default-export


And all these pages too

mountiny

Thanks

OSBotify · 2024-04-02T11:14:18Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.59-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-08T10:54:38Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

SzymczakJ added 5 commits March 18, 2024 17:36

migrate jest.config

5d56fb0

migrate testBuild

94702fb

migrate validateGithubActions

d6aefab

migrate verifyPodfile

9c18645

migrate verifySignedCommits

fe4547d

SzymczakJ changed the title ~~@szymczak/migrate workflow tests~~ [TS migration] migrate workflow tests Mar 18, 2024

SzymczakJ added 3 commits March 19, 2024 17:05

fix babel not formatting test files

c6f9af1

Merge branch 'main' into @szymczak/migrate-workflow-tests

d886ff2

fix typescript errors

e80c43d

SzymczakJ changed the title ~~[TS migration] migrate workflow tests~~ [No QA][TS migration] migrate workflow tests Mar 25, 2024

Merge branch 'main' into @szymczak/migrate-workflow-tests

7d176db

BrtqKr reviewed Mar 25, 2024

View reviewed changes

Skalakid approved these changes Mar 25, 2024

View reviewed changes

SzymczakJ added 2 commits March 25, 2024 10:16

fix mock types

f0fe698

fix pr comments

fd2b2b5

BrtqKr approved these changes Mar 25, 2024

View reviewed changes

SzymczakJ added 2 commits March 26, 2024 18:05

merge main

56aca75

Merge branch 'main' into @szymczak/migrate-workflow-tests

ad69176

fabioh8010 approved these changes Mar 26, 2024

View reviewed changes

SzymczakJ added 2 commits March 27, 2024 16:29

Merge branch 'main' into @szymczak/migrate-workflow-tests

c45f367

fix type errors

6df0fe8

SzymczakJ marked this pull request as ready for review March 27, 2024 15:35

SzymczakJ requested a review from a team as a code owner March 27, 2024 15:35

melvin-bot bot removed the request for review from a team March 27, 2024 15:36

melvin-bot bot requested a review from mollfpr March 27, 2024 15:36

mollfpr approved these changes Mar 29, 2024

View reviewed changes

mountiny assigned SzymczakJ Apr 2, 2024

mountiny requested changes Apr 2, 2024

View reviewed changes

fix pr comments

95c70e8

SzymczakJ requested a review from mountiny April 2, 2024 10:38

mountiny approved these changes Apr 2, 2024

View reviewed changes

mountiny merged commit 5c3640f into Expensify:main Apr 2, 2024
15 checks passed

github-actions bot mentioned this pull request Apr 2, 2024

Deploy Checklist: New Expensify 2024-04-02 #39399

Closed

87 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA][TS migration] migrate workflow tests #38491

[No QA][TS migration] migrate workflow tests #38491

SzymczakJ commented Mar 18, 2024 •

edited

Loading

BrtqKr Mar 25, 2024

BrtqKr Mar 25, 2024

BrtqKr Mar 25, 2024

BrtqKr Mar 25, 2024

BrtqKr Mar 25, 2024

BrtqKr Mar 25, 2024

BrtqKr Mar 25, 2024

BrtqKr Mar 25, 2024

Skalakid left a comment •

edited

Loading

Skalakid Mar 25, 2024

fabioh8010 commented Mar 25, 2024

SzymczakJ commented Mar 26, 2024

fabioh8010 left a comment

melvin-bot bot commented Mar 27, 2024

fabioh8010 commented Mar 28, 2024

SzymczakJ commented Mar 29, 2024

mollfpr commented Mar 29, 2024 •

edited

Loading

mollfpr left a comment

melvin-bot bot commented Mar 29, 2024

mountiny Apr 2, 2024

mountiny Apr 2, 2024

mountiny left a comment

OSBotify commented Apr 2, 2024

OSBotify commented Apr 8, 2024

		@@ -19,4 +19,4 @@ function assertVerifyJobExecuted(workflowResult: Step[], didExecute = true) {
		}

		// eslint-disable-next-line import/prefer-default-export

		@@ -18,4 +18,4 @@ function assertVerifyJobExecuted(workflowResult: Step[], didExecute = true) {
		}

		// eslint-disable-next-line import/prefer-default-export

[No QA][TS migration] migrate workflow tests #38491

[No QA][TS migration] migrate workflow tests #38491

Conversation

SzymczakJ commented Mar 18, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Skalakid left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabioh8010 commented Mar 25, 2024

SzymczakJ commented Mar 26, 2024

fabioh8010 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 27, 2024

fabioh8010 commented Mar 28, 2024

SzymczakJ commented Mar 29, 2024

mollfpr commented Mar 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 2, 2024

OSBotify commented Apr 8, 2024

SzymczakJ commented Mar 18, 2024 •

edited

Loading

Skalakid left a comment •

edited

Loading

mollfpr commented Mar 29, 2024 •

edited

Loading