[HOLD for Payment 2024-04-30] [$500] BA - Disconnected bank account is still displayed on bank account preview on Workflows page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4469599
Issue reported by: Applause - Internal Team

Action Performed:

Pre-requisite: user must be logged in, have created a collect workspace and have connected a bank account.

1. Go to Workspace > Workflows > Bank account.
2. Tap on "Disconnect bank account" and confirm.
3. Tap on the back arrow.
4. Verify the bank account is still displayed on the bank account preview.
5. Go to Settings > Wallet.
6. Delete the bank account.
7. Go to Workspace > Workflows.
8. Verify the bank account is still displayed on the bank account preview.

Expected Result:

The bank account should not be displayed on the preview after the account has been disconnected.

Actual Result:

The bank account is still displayed on the preview after the account has been disconnected.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435967_1712085957572.Aokm2842_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018935ae4d1df3ea3c
• Upwork Job ID: 1775552022142980096
• Last Price Increase: 2024-04-10
• Automatic offers:
• rayane-djouah | Reviewer | 0

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

Linking closed and fixed KI #38200

[hayata-suenaga]

@kbecciv, am I correct to understand that the fix for this issue has been deployed to production in the PR you linked and the issue is no longer reproducible both on staging or production?

The linked PR appears to have been deployed to production about 11 hours ago. I don't know why this issue was detected on staging about 2 hours ago.

[hayata-suenaga]

confirmed that the issue is not reproducible

[kavimuru]

@hayata-suenaga Tester reproduced this bug.

bandicam.2024-04-02.20-09-26-330.mp4

[hayata-suenaga]

I'll reopen this issue as the QA team was able to reproduce this.

However, we cannot confirm if this issue exists in production or not as we don't have a test bank account that we can use on production. So, I'll treat this as a normal bug issue.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018935ae4d1df3ea3c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Disconnected bank account is still displayed on bank account preview on Workflows page

What is the root cause of that problem?

When we disconnect bank account and get on the workflow page, we do not fetch the latest data as we only call it once when we load the page at the start:

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Lines 81 to 84 in 7177173

	useEffect(() => {
	fetchData();
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, []);

What changes do you think we should make in order to solve the problem?

Add a dependency of policy so that it will fetch the latest details everytime there is a change in policy settings

What alternative solutions did you explore? (Optional)

N/A

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The bank account is still displayed on the preview after the account has been disconnected.

What is the root cause of that problem?

The workspace workflows page relies on the policy?.achAccount here do decide whether to show the bank name in the bank account preview part.

However, when we disconnect the bank account, we're not setting achAccount to null in optimistic data here.

So the bank account preview will still show.

What changes do you think we should make in order to solve the problem?

Set achAccount of the policy to null in optimistic data here, and potentially restore it in failureData.

Sample code:

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
    value: {
        achAccount: null,
    },
}

What alternative solutions did you explore? (Optional)

If we only want the bank account preview to disappear after the API request to disconnect is successful, we can set achAccount of the policy to null in successData.

We might need to set achAccount to null when deleting the bank account (like in Wallet) too.

We can consider optimistically update the achAccount when we're at the final step of connecting the bank account too.

[melvin-bot]

Current assignee @hayata-suenaga is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[rayane-djouah]

Bump @nkdengineer

[nkdengineer]

Will open PR today.

[nkdengineer]

@rayane-djouah The PR is here.

[rayane-djouah]

Deployed to production #40226 (comment)

[rayane-djouah]

@sakluger, please remove the Reviewing label and bump to Daily as payment is due

[sakluger]

Sent an offer to @nkdengineer: https://www.upwork.com/nx/wm/offer/102102495/

[sakluger]

Summarizing payment on this issue:

Contributor: @nkdengineer $500, sent offer via Upwork (https://www.upwork.com/nx/wm/offer/102102495/)
Contributor+: @rayane-djouah $500, paid via Upwork

@rayane-djouah please complete the BZ checklist.

[sakluger]

@nkdengineer please let me know once you've accepted the offer. @rayane-djouah bump on the BZ checklist.

[sakluger]

I completed payment to @nkdengineer. Now just waiting on the BZ checklist before we can close the issue.

[rayane-djouah]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• The PR that introduced the bug has been identified. Link to the PR: Use policy achAccount instead of reimbursementAccount in WorkspaceWorkflow #38395
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/38395/files#r1589418697
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
• Determine if we should create a regression test for this bug. Yes.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test proposal
Pre-requisite: The user should be logged in, have created a collect workspace and have connected a bank account.

• Go to Workspace > Workflows > Bank account.

• Tap on "Disconnect bank account" and confirm.

• Tap on the back arrow.

• Verify that the bank account is not displayed on the preview after the account has been disconnected.

• Do we agree 👍 or 👎

[sakluger]

Thanks!