[$500] Workspace - Some of the new worspace chats name is "Chat Report"

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.58-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Log in with a new expensifail account
2. Create a workspace
3. Invite 3 new expensifail members who doesn't have expensify account yet
4. Navigate to the LHN
5. Click on any WS chats named "Chat Report"

Expected Result:

Workspace chat name should appear with member name

Actual Result:

Some of the new worspace chats name is "Chat Report". It changes back if you click on it.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6433449_1711905664988.bandicam_2024-03-31_19-13-09-337.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01de6cc9a1328c3268
• Upwork Job ID: 1774955282860523520
• Last Price Increase: 2024-04-02

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[yuwenmemon]

They also show up has Hidden in the workspace

[yuwenmemon]

Seems like we're somehow not properly falling back on the email on staging. Definitely seems like a candidate for external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01de6cc9a1328c3268

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[AMohamedAakhil]

Proposal
Please re-state the problem that we are trying to solve in this issue.
Some of the new worspace chats name is "Chat Report"

What is the root cause of that problem?
Chat names not being refetched

What changes do you think we should make in order to solve the problem?

1. Invalidate chat names fetched, as workspace is created and members are invited.

What alternative solutions did you explore? (Optional)
NA

[melvin-bot]

📣 @AMohamedAakhil! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[AMohamedAakhil]

Contributor details
Your Expensify account email: a.aakhilmohamed@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0116333babf287853b

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[AMohamedAakhil]

Proposal
Please re-state the problem that we are trying to solve in this issue.
Some of the new worspace chats name is "Chat Report"

What is the root cause of that problem?
Chat names not being refetched

What changes do you think we should make in order to solve the problem?

Invalidate chat names fetched, as workspace is created and members are invited.
What alternative solutions did you explore? (Optional)
NA

[Pranav2612000]

Proposal

Please re-state the problem that we are trying to solve in this issue.

New Chats created on inviting new members to a workspace are called "Chat Reports"

What is the root cause of that problem?

On inviting a new member, we call addMembersToWorkspace (

App/src/libs/actions/Policy.ts

Line 1279 in 16525e6

function addMembersToWorkspace(invitedEmailsToAccountIDs: InvitedEmailsToAccountIDs, welcomeNote: string, policyID: string) {

)
which calls createPolicyExpenseChats (

App/src/libs/actions/Policy.ts

Line 1182 in 16525e6

function createPolicyExpenseChats(policyID: string, invitedEmailsToAccountIDs: InvitedEmailsToAccountIDs, hasOutstandingChildRequest = false): WorkspaceMembersChats {

).
In this function, we build an optimistic chat report for each user (

App/src/libs/actions/Policy.ts

Line 1212 in 16525e6

const optimisticReport = ReportUtils.buildOptimisticChatReport([sessionAccountID, cleanAccountID], undefined, CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT, policyID, cleanAccountID);

) with the reportName as undefined. Due to this, in buildOptimisticChatReport the default chat report name ( i.e. Chat Report ) is set

What changes do you think we should make in order to solve the problem?

To solve the problem, we can use the email as the reportName param to the buildOptimisticChatReport function call for each new member in createPolicyExpenseChat. This would look something like this -

const optimisticReport = ReportUtils.buildOptimisticChatReport([sessionAccountID, cleanAccountID], email, CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT, policyID, cleanAccountID);

What alternative solutions did you explore? (Optional)

NA

[yuwenmemon]

@Pranav2612000 Are you able to identify the PR in the latest Staging deploy that would be at the heart of your root cause?

[mollfpr]

@yuwenmemon Are you able to repro the issue? I can't reproduce the issue on the latest main or staging.

[yuwenmemon]

Yeah I'm able to reproduce on staging with these steps:

1. Create a new workspace
2. Invite 3 brand new accounts to that workspace (the accounts have not been created before)
3. Go to your Chats - you'll see 2/3 Workspace chats are "Chat Report" rather than the email of the user you just invited

[yuwenmemon]

Kapture.2024-04-01.at.22.05.27.mp4

[yuwenmemon]

We can do that, but how do you propose it would fix the issue described above?

[yuwenmemon]

I am inclined to believe this has been sitting around as a bug all along since I could reproduce it on both API code from a week ago and App code from a week ago.

So yeah, maybe what we could do is:

1. Move the relevant portions of this command to auth
2. In addition to sending the personal details of the newly created accounts, and blowing away the optimistic accountIDs, also update the policy expense chat to have the participants reflect the new set of accountIDs (i.e. replace the optimistic one with the real one)

Asking about this in Open Source here: https://expensify.slack.com/archives/C01GTK53T8Q/p1712188777239399

[melvin-bot]

@yuwenmemon, @kevinksullivan, @mollfpr Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@yuwenmemon, @kevinksullivan, @mollfpr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[kevinksullivan]

bumped yuwen's thread in slack for more input

[melvin-bot]

@yuwenmemon @kevinksullivan @mollfpr this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@yuwenmemon, @kevinksullivan, @mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kevinksullivan]

Adding to collect project per this convo

[kevinksullivan]

bumped in slack again

[melvin-bot]

@yuwenmemon, @kevinksullivan, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@yuwenmemon, @kevinksullivan, @mollfpr Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@yuwenmemon, @kevinksullivan, @mollfpr Still overdue 6 days?! Let's take care of this!

[yuwenmemon]

@Beamanator, Any thoughts on what I posted here a couple of weeks back?

[Beamanator]

Oofdaaaa - responded, sorry for the delay

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@yuwenmemon, @kevinksullivan, @mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[yuwenmemon]

Unable to reproduce as well - soooo... looks like this somehow got fixed by someone somewhere somehow 😅

[yuwenmemon]

Closing this out!