Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] mweb - IOU - Tapping pay elsewhere button in header grey out IOU preview for few seconds #39314

Closed
1 of 6 tasks
lanitochka17 opened this issue Mar 30, 2024 · 19 comments
Closed
1 of 6 tasks
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4464523
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap on a Workspace chat
  3. Tap plus icon --- request money
  4. Enter an amount and tap next
  5. Tap request
  6. Open newly created expense to open IOU report page
  7. Tap pay elsewhere button in header

Expected Result:

In IOU report page, tapping pay elsewhere button in header must not grey out IOU preview for few seconds

Actual Result:

In IOU report page, tapping pay elsewhere button in header grey out IOU preview for few seconds

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6432142_1711753915643.dp.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d1acc8625fd29f6e
  • Upwork Job ID: 1777821827439878144
  • Last Price Increase: 2024-04-09
  • Automatic offers:
    • Ollyws | Reviewer | 0
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 30, 2024

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

@chiragsalian FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@chiragsalian chiragsalian added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 1, 2024
@chiragsalian
Copy link
Contributor

chiragsalian commented Apr 1, 2024

I can reproduce this issue on web too. Its more easily reproducible when i set network speed to "slow 3g" in chrome developer tools. I have not verified but i suspect the issue is from the change in this PR - #33124. The optimistic data might not be set the same way as production.

imo not a blocker since this is a minor bug and only affects optimistic data. removing blocker label and demoting.

cc @robertjchen since I noticed you are working on this - #31345. Should the IOU preview be greyed out or not as the API processes PayMoneyRequest. I feel like perhaps it should not be greyed out but wanted to double-check with you.

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@robertjchen
Copy link
Contributor

Yep, not a blocker for sure- let me followup on the correct behavior.

Copy link

melvin-bot bot commented Apr 5, 2024

@chiragsalian Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
@robertjchen robertjchen added Weekly KSv2 and removed Daily KSv2 labels Apr 9, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 9, 2024
@robertjchen
Copy link
Contributor

Confirmed that it should NOT be greyed out 👍

@chiragsalian chiragsalian added the External Added to denote the issue can be worked on by a contributor label Apr 9, 2024
@melvin-bot melvin-bot bot changed the title mweb - IOU - Tapping pay elsewhere button in header grey out IOU preview for few seconds [$250] mweb - IOU - Tapping pay elsewhere button in header grey out IOU preview for few seconds Apr 9, 2024
Copy link

melvin-bot bot commented Apr 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01d1acc8625fd29f6e

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 9, 2024
Copy link

melvin-bot bot commented Apr 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 9, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Apr 9, 2024
@pac-guerreiro
Copy link
Contributor

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

@Ollyws
Copy link
Contributor

Ollyws commented Apr 11, 2024

Sure, go ahead @pac-guerreiro
🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Apr 11, 2024

Current assignee @chiragsalian is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

@Ollyws, @chiragsalian Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@chiragsalian
Copy link
Contributor

Sure go for it @pac-guerreiro. When you get the chance let us know your ETA and proposal.

@pac-guerreiro
Copy link
Contributor

@chiragsalian @lanitochka17

Currently I'm not able to reproduce this issue 😅 Can you check if this issue is still present?

@lanitochka17
Copy link
Author

Issue is not reproducible on the latest build 1.4.62-10

az_recorder_20240416_193013.mp4

@chiragsalian
Copy link
Contributor

Closing this issue since its not reproducible. If it reoccurs feel free to reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants