Blinking on chat switching #39040

perunt · 2024-03-27T11:05:39Z

Details

Fixed Issues

$ #38909 #38838
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test 1

Open a report screen.
Randomly select and open five different reports, ensuring each is viewed at least once to fetch data.
After opening all reports, cycle through them to check for any visual disruptions, such as blinking avatars or elements on the page.

Test 2

Go to FAB> +> Distance> Complete the IOU flow
Navigate to created Distance request
Go to details page and go back to Distance card page
Repeat the step 4 and take a not of map behavior

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

2024-03-27.13.11.24.mp4

Android: mWeb Chrome

2024-03-27.13.27.37.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-27.at.13.18.42.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-27.at.13.24.11.mov

MacOS: Chrome / Safari

Untitled.3.mov

MacOS: Desktop

Untitled.4.mov

melvin-bot · 2024-03-27T12:29:09Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-03-27T12:43:26Z

hey @perunt , can you please add the QA and Tests steps? Thank you 😄

hungvu193 · 2024-03-27T13:33:03Z

Does this also resolve this one: #38838?
cc @paultsimura

paultsimura · 2024-03-27T13:38:03Z

Does this also resolve this one: #38838? cc @paultsimura

Based on the contributors' RCA, this PR should fix it as well. Please link it in the fixed issues.

hungvu193 · 2024-03-27T13:39:46Z

Does this also resolve this one: #38838? cc @paultsimura

Based on the contributors' RCA, this PR should fix it as well. Please link it in the fixed issues.

Do you wanna take this one? Since you followed this one from start?

paultsimura · 2024-03-27T13:40:59Z

Does this also resolve this one: #38838? cc @paultsimura

Based on the contributors' RCA, this PR should fix it as well. Please link it in the fixed issues.

Do you wanna take this one? Since you followed this one from start?

I'd love to, thanks 🙇

hungvu193 · 2024-03-27T13:50:02Z

@paultsimura Let's raise on slack so some internal engineers can assign you 😄

paultsimura · 2024-03-27T14:28:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android15.32.mp4

Android: mWeb Chrome

chrome15.40.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-03-27.at.15.21.4115.22.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-03-27.at.15.35.2515.40.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-03-27.at.15.16.1515.16.mp4

MacOS: Desktop

Screen.Recording.2024-03-27.at.15.46.5115.47.mp4

paultsimura

LGTM ✔️

melvin-bot · 2024-03-27T14:51:15Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #38909 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

ikevin127 · 2024-03-27T15:34:05Z

src/pages/home/report/ReportActionsView.tsx

@@ -133,6 +133,10 @@ function ReportActionsView({
    }, [route]);

    const listID = useMemo(() => {


@perunt Would you kindly add a comment above the listID declaration describing its role and why it is passed down to the FlatList component as (React) key instead of passing it to the existing extraData array here ?

I also asked in #38838 (comment) as part of #38838 (issue).

Hey! Definitely, I'll put my comment up top so it's easier to spot. Thanks!

So, here's the deal: I need to make the whole list refresh itself from scratch. It's all about the virtualization thing the list does. Basically, this refresh trick is mostly needed when you're linking comments, especially when jumping from looking at a bunch of messages to just a few. The virtualization in FlatList gets a bit wonky when the amount of stuff shown shrinks as you move to a specific message. So, to keep everything looking right, we gotta refresh the whole list, not just poke the FlatList to update what it's already showing. So if we put it to extraData, the comment linking would lead to the wrong place in some specific cases

let me check your links, will also leave this info there

paultsimura · 2024-03-28T08:59:01Z

src/pages/home/report/ReportActionsView.tsx

    const listID = useMemo(() => {
        if (!reportActionID) {
-            // We only trigger a change of the list ID for comment linking to ensure proper positioning
+            // here we avoid of using it if we're not in the Comment Linking flow


Now this comment is a bit unclear. Let's change to this:

Suggested change

// here we avoid of using it if we're not in the Comment Linking flow

// Keep the old list ID since we're not in the Comment Linking flow

paultsimura

LGTM ✔️

paultsimura · 2024-03-28T12:02:29Z

@NikkiWines all yours
Could you please also assign me as a C+ to the corresponding issue?

NikkiWines

melvin-bot · 2024-03-28T18:46:19Z

@NikkiWines looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-03-28T18:52:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

NikkiWines · 2024-03-28T20:15:33Z

Lies.

OSBotify · 2024-03-29T02:28:35Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-02T11:04:51Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2024-08-27T08:21:50Z

src/pages/home/report/ReportActionsView.tsx

+        if (!reportActionID) {
+            // Keep the old list ID since we're not in the Comment Linking flow
+            return listOldID;
+        }


We missed the case where we switch from a report with comment linking to a report without comment linking, in this case we shouldn't use the same list id

reportActionID: 123 -> reportActionID: 555 => Use different id

reportActionID: 123 -> reportActionID: null => Use different id

reportActionID: null -> reportActionID: 123 => Use different id

reportActionID: null -> reportActionID: null => Use same id

(Coming from #45004)

fix ID

9a2561c

perunt marked this pull request as ready for review March 27, 2024 12:29

perunt requested a review from a team as a code owner March 27, 2024 12:29

melvin-bot bot removed the request for review from a team March 27, 2024 12:29

melvin-bot bot requested a review from hungvu193 March 27, 2024 12:29

paultsimura approved these changes Mar 27, 2024

View reviewed changes

melvin-bot bot requested a review from NikkiWines March 27, 2024 14:51

ikevin127 reviewed Mar 27, 2024

View reviewed changes

ikevin127 mentioned this pull request Mar 27, 2024

Hold for #38909 [$500] IOU - Map is blinking when navigate to Distance request #38838

Closed

6 tasks

move the comment to the top so it's more noticeable

5724807

paultsimura suggested changes Mar 28, 2024

View reviewed changes

mountiny assigned perunt Mar 28, 2024

update comment

8ec3050

paultsimura approved these changes Mar 28, 2024

View reviewed changes

NikkiWines approved these changes Mar 28, 2024

View reviewed changes

NikkiWines merged commit a3f777e into Expensify:main Mar 28, 2024
17 checks passed

melvin-bot bot added the Emergency label Mar 28, 2024

NikkiWines removed the Emergency label Mar 28, 2024

github-actions bot mentioned this pull request Mar 29, 2024

Deploy Checklist: New Expensify 2024-03-29 #39222

Closed

melvin-bot bot mentioned this pull request Apr 2, 2024

[HOLD for payment 2024-04-09] HIGH: [Performance] [$500] Eliminate 3x re-render on switching to new chat #38909

Closed

s77rt reviewed Aug 27, 2024

View reviewed changes

s77rt mentioned this pull request Aug 27, 2024

[HOLD for payment 2024-08-27] [$250] Clicking on new message doesn't navigate to the last message for 2nd comment link #45004

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blinking on chat switching #39040

Blinking on chat switching #39040

perunt commented Mar 27, 2024 •

edited

Loading

melvin-bot bot commented Mar 27, 2024

hungvu193 commented Mar 27, 2024

hungvu193 commented Mar 27, 2024

paultsimura commented Mar 27, 2024

hungvu193 commented Mar 27, 2024

paultsimura commented Mar 27, 2024

hungvu193 commented Mar 27, 2024

paultsimura commented Mar 27, 2024 •

edited

Loading

paultsimura left a comment

melvin-bot bot commented Mar 27, 2024

ikevin127 Mar 27, 2024

perunt Mar 28, 2024

perunt Mar 28, 2024

paultsimura Mar 28, 2024

perunt Mar 28, 2024

paultsimura left a comment

paultsimura commented Mar 28, 2024

NikkiWines left a comment

melvin-bot bot commented Mar 28, 2024

OSBotify commented Mar 28, 2024

NikkiWines commented Mar 28, 2024 •

edited

Loading

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

s77rt Aug 27, 2024

		@@ -133,6 +133,10 @@ function ReportActionsView({
		}, [route]);

		const listID = useMemo(() => {

	// here we avoid of using it if we're not in the Comment Linking flow
	// Keep the old list ID since we're not in the Comment Linking flow

Blinking on chat switching #39040

Blinking on chat switching #39040

Conversation

perunt commented Mar 27, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 27, 2024

hungvu193 commented Mar 27, 2024

hungvu193 commented Mar 27, 2024

paultsimura commented Mar 27, 2024

hungvu193 commented Mar 27, 2024

paultsimura commented Mar 27, 2024

hungvu193 commented Mar 27, 2024

paultsimura commented Mar 27, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

paultsimura left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 27, 2024

ikevin127 Mar 27, 2024

Choose a reason for hiding this comment

perunt Mar 28, 2024

Choose a reason for hiding this comment

perunt Mar 28, 2024

Choose a reason for hiding this comment

paultsimura Mar 28, 2024

Choose a reason for hiding this comment

perunt Mar 28, 2024

Choose a reason for hiding this comment

paultsimura left a comment

Choose a reason for hiding this comment

paultsimura commented Mar 28, 2024

NikkiWines left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 28, 2024

OSBotify commented Mar 28, 2024

NikkiWines commented Mar 28, 2024 • edited Loading

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

s77rt Aug 27, 2024

Choose a reason for hiding this comment

perunt commented Mar 27, 2024 •

edited

Loading

paultsimura commented Mar 27, 2024 •

edited

Loading

NikkiWines commented Mar 28, 2024 •

edited

Loading