Update Workspace Creation in NewDot to Create Collect Workspaces #38191

allgandalf · 2024-03-12T23:02:08Z

Details

We are moving away from free policies, this PR updates the current codebase to create collect policies by default .

Fixed Issues

$ #37153
PROPOSAL: #37153 (comment)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Go to Workspace Switcher
Create New Workspace
(Observe that now by default Collect workspace is created)

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: mWeb Safari

WhatsApp.Video.2024-03-13.at.4.52.34.AM.mp4

iOS: Native

WhatsApp.Video.2024-03-13.at.4.52.41.AM.mp4

MacOS: Chrome / Safari

WhatsApp.Video.2024-03-13.at.5.01.51.AM.mp4

Android: Native

simplescreenrecorder-2024-03-13_05.07.49.mp4

Android: mWeb Chrome

simplescreenrecorder-2024-03-13_04.57.36.mp4

MacOS: Desktop

WhatsApp.Video.2024-03-13.at.5.01.52.AM.mp4

melvin-bot · 2024-03-12T23:02:13Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-03-13T16:58:15Z

On it today

allroundexperts · 2024-03-13T20:38:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-26.at.4.32.23.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-03-26.at.4.31.42.PM.mov

iOS: Native

Screen.Recording.2024-03-26.at.4.30.05.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-26.at.4.29.11.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-26.at.4.22.16.PM.mov

MacOS: Desktop

Screen.Recording.2024-03-26.at.4.25.43.PM.mov

allroundexperts · 2024-03-13T21:13:08Z

BUG

Categories and more feature links do not work after a workspace is created.

Screen.Recording.2024-03-14.at.2.11.30.AM.mov

allgandalf · 2024-03-13T21:16:06Z

I guess categories for collect workspaces are not enabled by default 🤔, your account needs to be in beta (Not quite sure) Can you confirm this please @allroundexperts , if this isn't the case then i'll look into this bug tomorrow :)

allroundexperts · 2024-03-13T21:17:21Z

I guess categories for collect workspaces are not enabled by default 🤔, your account needs to be in beta (Not quite sure) Can you confirm this please @allroundexperts , if this isn't the case then i'll look into this bug tomorrow :)

If the beta is not enabled, why are we showing the menu items?

allroundexperts · 2024-03-13T21:20:26Z

BUG

The workspace disappears if categories page is opened 😕

Screen.Recording.2024-03-14.at.2.18.21.AM.mov

allgandalf · 2024-03-13T21:32:18Z

I see, i found one issue which was to enable access to all collect policies accesible #37151 asked for some clarity over there

Also did some digging, we need to have isPolicyExpenseChatEnabled return true from the BE

App/src/pages/workspace/PaidPolicyAccessOrNotFoundWrapper.tsx

Line 46 in 34930fe

    
           const shouldShowNotFoundPage = isEmptyObject(props.policy) || !props.policy?.id || !PolicyUtils.isPaidGroupPolicy(props.policy) || !props.policy.isPolicyExpenseChatEnabled;

trjExpensify · 2024-03-15T16:16:21Z

What are the next steps here, guys? It would be great if @allroundexperts could get through review today and into the hands of an internal secondary reviewer. Thanks!

allroundexperts · 2024-03-15T16:17:22Z

@trjExpensify This is pending on #38191 (comment)

allroundexperts · 2024-03-15T16:17:52Z

@GandalfGwaihir Do you think you'd be able to update this today?

allgandalf · 2024-03-15T16:19:14Z

Let me check what isPolicyExpenseChatEnabled returns in console and get back ASAP

allgandalf · 2024-03-15T16:30:25Z

isPolicyExpenseChatEnabled gets set to false over here @allroundexperts

isPolicyExpenseChatEnabled is returned by the BE right ?

Tagging @tgolen as he also has some context

allgandalf · 2024-03-15T16:33:49Z

This was the issue which sets isPolicyExpenseChatEnabled to true on creation of a collect policy on ND

allgandalf · 2024-03-15T16:49:56Z

Please refer

allgandalf · 2024-03-15T17:01:12Z

Also can verify that we can see Categories if we remove the isPolicyExpenseChatEnabled check:

Same with the workspace in workspace list @allroundexperts

allgandalf · 2024-03-18T19:24:35Z

Waiting for #37151 (comment) to be merged :)

allgandalf · 2024-03-19T19:54:50Z

still waiting

trjExpensify · 2024-03-20T11:13:39Z

@GandalfGwaihir that PR is now merged and on staging. Can you fix your conflicts today, and @allroundexperts can you resume the review?

allgandalf · 2024-03-20T14:10:59Z

@allroundexperts , tested it locally, things work fine now, can you update the checklist please :)

allroundexperts · 2024-03-20T14:13:08Z

I'll test this again today.

allgandalf · 2024-03-21T16:20:15Z

friendly bump @allroundexperts

allgandalf · 2024-03-21T17:11:45Z

Okay this is strange:

Getting error 500 while creating collect Workspace, I tested this PR yesterday and things worked smoothly, and when i tested this now again, i am getting the above error, does the same happen to you @allroundexperts

Also, one unit test is failing because of API call, any insights ? @trjExpensify @Gonals

trjExpensify · 2024-03-21T17:35:26Z

That isn't on my radar, sorry. What steps are you taking to create the workspace? If you paste that requestID in here, I can try and take a look.

luacmartins · 2024-03-21T17:37:23Z

These are the logs

luacmartins · 2024-03-21T17:41:43Z

@GandalfGwaihir please stop testing for now. We're aware of that issue and are working on it.

allgandalf · 2024-03-21T17:42:38Z

Yeah sure :)

Also please note that this was working smooth with collect worskpaces yesterday

trjExpensify · 2024-03-21T17:45:21Z

Dropping this here (internal link) for ease of finding it again.

allgandalf · 2024-03-21T18:26:35Z

@trjExpensify @luacmartins , actually this seems to be resolved, I am able to create the collect workspace successfully , You can check the unit test logs, my best guess is it had to do something with the api not working at that time :

But yeah, waiting for the resolution from your side, if it had to do with something in the BE

allgandalf · 2024-03-25T19:02:03Z

bump @allroundexperts for reviewers checklist

tgolen

The code changes look good. I'll leave it to @allroundexperts for continuing to test this.

allroundexperts

Works good!

allgandalf · 2024-03-27T12:33:45Z

friendly bump @techievivek, let's get this on staging before the week ends 💪

tgolen · 2024-03-27T13:42:08Z

I'll go ahead and merge this.

OSBotify · 2024-03-27T13:48:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-29T02:26:59Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-02T11:03:15Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allgandalf added 2 commits March 6, 2024 21:26

Update workspace creation to paid

9c2cf34

Merge branch 'Expensify:main' into issue37153

78781fa

allgandalf requested a review from a team as a code owner March 12, 2024 23:02

melvin-bot bot requested review from allroundexperts and removed request for a team March 12, 2024 23:02

tgolen mentioned this pull request Mar 13, 2024

[Remove Free Workspace Creation] Keep old NewDot clients from Creating Free Workspaces #37154

Closed

allgandalf mentioned this pull request Mar 13, 2024

[Remove Free Workspace Creation] Make all Collect Policies Created From NewDot Accessible In NewDot #37151

Closed

Merge branch 'Expensify:main' into issue37153

a6ea109

allgandalf added 2 commits March 20, 2024 19:25

Merge Main

48a3d70

Fix unit tests

776a819

Merge branch 'Expensify:main' into issue37153

dc6f310

allgandalf mentioned this pull request Mar 22, 2024

[HOLD for payment 2024-04-05] [$125] Workspace - Categories load without loading spinner #37904

Closed

6 tasks

Merge branch 'Expensify:main' into issue37153

0e1b166

tgolen approved these changes Mar 25, 2024

View reviewed changes

allroundexperts approved these changes Mar 26, 2024

View reviewed changes

melvin-bot bot requested a review from techievivek March 26, 2024 11:37

tgolen merged commit 0509f8d into Expensify:main Mar 27, 2024
15 of 16 checks passed

github-actions bot mentioned this pull request Mar 29, 2024

Deploy Checklist: New Expensify 2024-03-29 #39222

Closed

melvin-bot bot mentioned this pull request Apr 2, 2024

[HOLD for payment 2024-04-09] [$500] [Remove Free Workspace Creation] Update Workspace Creation in NewDot to Create Collect Workspaces #37153

Closed

Update Workspace Creation in NewDot to Create Collect Workspaces #38191

Update Workspace Creation in NewDot to Create Collect Workspaces #38191

Conversation

allgandalf commented Mar 12, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 12, 2024

allroundexperts commented Mar 13, 2024

allroundexperts commented Mar 13, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Mar 13, 2024

allgandalf commented Mar 13, 2024

allroundexperts commented Mar 13, 2024

allroundexperts commented Mar 13, 2024

allgandalf commented Mar 13, 2024 • edited Loading

trjExpensify commented Mar 15, 2024

allroundexperts commented Mar 15, 2024

allroundexperts commented Mar 15, 2024

allgandalf commented Mar 15, 2024

allgandalf commented Mar 15, 2024 • edited Loading

allgandalf commented Mar 15, 2024

allgandalf commented Mar 15, 2024

allgandalf commented Mar 15, 2024 • edited Loading

allgandalf commented Mar 18, 2024

allgandalf commented Mar 19, 2024

trjExpensify commented Mar 20, 2024

allgandalf commented Mar 20, 2024

allroundexperts commented Mar 20, 2024

allgandalf commented Mar 21, 2024

allgandalf commented Mar 21, 2024

trjExpensify commented Mar 21, 2024 • edited Loading

luacmartins commented Mar 21, 2024

luacmartins commented Mar 21, 2024

allgandalf commented Mar 21, 2024 • edited Loading

trjExpensify commented Mar 21, 2024

allgandalf commented Mar 21, 2024

allgandalf commented Mar 25, 2024

tgolen left a comment

Choose a reason for hiding this comment

allroundexperts left a comment

Choose a reason for hiding this comment

allgandalf commented Mar 27, 2024

tgolen commented Mar 27, 2024

OSBotify commented Mar 27, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

allgandalf commented Mar 12, 2024 •

edited

Loading

allroundexperts commented Mar 13, 2024 •

edited

Loading

allgandalf commented Mar 13, 2024 •

edited

Loading

allgandalf commented Mar 15, 2024 •

edited

Loading

allgandalf commented Mar 15, 2024 •

edited

Loading

trjExpensify commented Mar 21, 2024 •

edited

Loading

allgandalf commented Mar 21, 2024 •

edited

Loading