[HOLD for payment 2024-04-09] [$500] [Remove Free Workspace Creation] Update Workspace Creation in NewDot to Create Collect Workspaces

[tgolen]

• Held on [Wave Collect] [Remove Free Workspace Creation] - Update Notifications in OldDot #37149 so that the new notifications are in place on the server
• Held on [Remove Free Workspace Creation] Make all Collect Policies Created From NewDot Accessible In NewDot #37151 so that all collect policies created in NewDot are accessible in NewDot
• Should be coordinated to be released along with [Remove Free Workspace Creation] Make all Collect Policies Created From NewDot Accessible In NewDot #37151

This will make sure that any workspace created from NewDot is a collect workspace and not a free workspace.

• Change CONST.POLICY.TYPE.FREE to CONST.POLICY.TYPE.TEAM here, here, and here
• Update tests in SidebarFilterTest and PolicyTest to use CONST.POLICY.TYPE.TEAM

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016d89cd1132beada5
• Upwork Job ID: 1762127738310324224
• Last Price Increase: 2024-03-06
• Automatic offers:
• GandalfGwaihir | Contributor | 0

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[eucool]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update Workspace Creation in NewDot to Create Collect Workspaces

What is the root cause of that problem?

New request

What changes do you think we should make in order to solve the problem?

We need to change CONST.POLICY.TYPE.FREE to CONST.POLICY.TYPE.TEAM at:

App/src/libs/actions/Policy.ts

Line 1245 in 2254c66

type: CONST.POLICY.TYPE.FREE,

App/src/libs/actions/Policy.ts

Line 1306 in 2254c66

type: CONST.POLICY.TYPE.FREE,

And

App/src/libs/actions/Policy.ts

Line 1495 in 2254c66

type: CONST.POLICY.TYPE.FREE,

Also we need to Update tests in SidebarFilterTest and PolicyTest to use CONST.POLICY.TYPE.TEAM

App/tests/unit/SidebarFilterTest.js

Line 225 in 2254c66

type: CONST.POLICY.TYPE.FREE,

App/tests/actions/PolicyTest.js

Line 55 in 2254c66

expect(policy.type).toBe(CONST.POLICY.TYPE.FREE);

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016d89cd1132beada5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[ghost]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

New Feature Request as discussed in the comment

What changes do you think we should make in order to solve the problem?

We need to change CONST.POLICY.TYPE.FREE to CONST.POLICY.TYPE.TEAM here :

App/src/libs/actions/Policy.ts

Line 1245 in 2254c66

type: CONST.POLICY.TYPE.FREE,

and

App/src/libs/actions/Policy.ts

Line 1306 in 2254c66

type: CONST.POLICY.TYPE.FREE,

and

App/src/libs/actions/Policy.ts

Line 1495 in 2254c66

type: CONST.POLICY.TYPE.FREE,

and Also we need to Update tests in SidebarFilterTest and PolicyTest to use CONST.POLICY.TYPE.TEAM :

App/tests/unit/SidebarFilterTest.js

Line 225 in 2254c66

type: CONST.POLICY.TYPE.FREE,

and

App/tests/actions/PolicyTest.js

Line 55 in 2254c66

expect(policy.type).toBe(CONST.POLICY.TYPE.FREE);

What alternative solutions did you explore? (Optional)

N/A

[slafortune]

@allroundexperts I see this is still on hold, but have you had a chance to review either proposal?

[allroundexperts]

@slafortune I think @tgolen has pretty much shared all the pieces that are needed in the issue description. @godofoutcasts94's proposal is essentially a duplicate of what @codinggeek2023 proposed earlier. But even that proposal is just a duplicate of what @tgolen said here. I think we need a better proposal that has at-least a working demo.

[eucool]

Shall i attach a testing branch to my proposal ?

…

On Fri, Mar 1, 2024 at 3:48 PM Sibtain Ali ***@***.***> wrote: @slafortune <https://github.com/slafortune> I think @tgolen <https://github.com/tgolen> has pretty much shared all the pieces that are needed in the issue description. @godofoutcasts94 <https://github.com/godofoutcasts94>'s proposal <#37153 (comment)> is essentially a duplicate of what @codinggeek2023 <https://github.com/codinggeek2023> proposed <#37153 (comment)> earlier. But even that proposal is just a duplicate of what @tgolen <https://github.com/tgolen> said here <#37153 (comment)>. I think we need a better proposal that has at-least a working demo. — Reply to this email directly, view it on GitHub <#37153 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BFJXGI4L6S42ARPFRS2ESETYWBIWFAVCNFSM6AAAAABDXA6P26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZSHEYTCMJQHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ghost]

@slafortune I think @tgolen has pretty much shared all the pieces that are needed in the issue description. @godofoutcasts94's proposal is essentially a duplicate of what @codinggeek2023 proposed earlier. But even that proposal is just a duplicate of what @tgolen said here. I think we need a better proposal that has at-least a working demo.

Should I attach the working video?

[melvin-bot]

@slafortune, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[slafortune]

Still on hold

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allgandalf]

PR Up for review @allroundexperts :)

[slafortune]

Looks like we are waiting on 38191 to be merged 👍

[allgandalf]

PR was on hold for another BE PR, this should be merged by Tomorrow :) thanks @slafortune

[allgandalf]

PR was merged today 🍾

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update Workspace Creation in NewDot to Create Collect Workspaces #38191

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @GandalfGwaihir requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

@GandalfGwaihir - Paid ✅

@allroundexperts can you please complete the checklist?

[allroundexperts]

@slafortune This was a new feature and as such, a checklist is not needed here. We can add the following regression test though:

1. Open the app and click on the + icon in the LHN.
2. Select Create new workspace.
3. Open the workspaces page from settings.
4. Verify that the created workspace is of type collect.

Do we 👍 or 👎 ?

[slafortune]

@allroundexperts requires payment through NewDot Manual Requests -$500

[JmillsExpensify]

$500 approved for @allroundexperts