[$500] [Held requests] Expense preview turns to skeleton after approving & paying request offline

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.58-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• Admin and employee are in the Collect workspace.

1. [Employee] Request money from the workspace chat.
2. [Employee] Create two money requests.
3. [Employee] Hold one of the requests and leave the other one unheld.
4. [Admin] Go to expense report.
5. [Admin] Go offline.
6. [Admin] Click Approve button.
7. [Admin] Approve the unheld request only and pay with expensify for the unheld request.
8. [Admin] Go online.
9. [Admin] Return to the paid expense report.

Expected Result:

When returning online, the expense preview will not show skeleton loading.

Actual Result:

When returning online, the expense previews disappear and turn to skeleton loading.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6433424_1711916080941.20240401_041259.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b2d44a97bebec012
• Upwork Job ID: 1774828581241303040
• Last Price Increase: 2024-05-07

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b2d44a97bebec012

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[cead22]

This is a pretty involved flow, so I don't think we should block on it. @greg-schroeder let's take this through the normal bug process

[greg-schroeder]

Okay, pending proposals and added to #wave-collect

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mollfpr]

No proposals

[melvin-bot]

@cead22 @mollfpr @greg-schroeder this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[greg-schroeder]

Same as above

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

Waiting for porposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[skyweb331]

@MelvinBot I am investigating the issue. Will submit proposal soon.

[cead22]

No overdue. Proposal coming soon

[melvin-bot]

@cead22, @mollfpr, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

[skyweb331]

This is unable to reproduce.

[melvin-bot]

@cead22 @mollfpr @greg-schroeder this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@cead22, @mollfpr, @greg-schroeder Still overdue 6 days?! Let's take care of this!

[cead22]

@m-natarajan are you still able to reproduce this?

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

Seems CS is going to take this

[rezkiy37]

I've tried to reproduce the bug. I was not able to do it. Looks like it works properly. Can you try on your end?

Video

Bug.mp4

[greg-schroeder]

Hmm, I think it may have been fixed at some point. I'll close for now, but reopen if you disagree or are able to reproduce this.