Correctly update thread ancestors reply count #38658

bernhardoj · 2024-03-20T06:28:54Z

Details

Currently, we only update the thread direct parent reply data, so the thread ancestors reply count doesn't increase when we add a comment.

Fixed Issues

$ #38002
PROPOSAL: #38002 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open any chat
Create a multi-nested thread (either add a comment or create a task)
Keep going back to the parent chat
Verify each time you go back, the thread reply count is increased by 1
Delete the reply on the last thread
Keep going back to the parent chat
Verify each time you go back, the thread reply count is decreased by 1

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-20.at.14.15.38.mov

Android: mWeb Chrome

Screen.Recording.2024-03-20.at.14.11.48.mov

iOS: Native

Screen.Recording.2024-03-20.at.14.07.23.mov

iOS: mWeb Safari

Screen.Recording.2024-03-20.at.13.51.03.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-20.at.13.39.19.mov

MacOS: Desktop

Screen.Recording.2024-03-20.at.13.40.52.mov

melvin-bot · 2024-03-20T06:28:59Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-03-20T06:31:58Z

src/libs/actions/Task.ts

-        if (!isEmptyObject(optimisticParentReportData)) {
-            optimisticData.push(optimisticParentReportData);
-        }
+        optimisticParentReportData.forEach((parentReportData) => optimisticData.push(parentReportData));


I notice 1 issue when deleting a task from a thread. Even though we already optimistically update the reply count to 0, the BE then will set it again back to 1 even though the task is deleted from the thread.

Screen.Recording.2024-03-20.at.14.29.27.mov

cc @puneetlath Can you take a look at this bug. It seems this will require a backend fix.

src/libs/ReportUtils.ts

fedirjh · 2024-03-20T15:56:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2024-03-20.at.17.49.49.mp4

Android: mWeb Chrome

CleanShot.2024-03-20.at.18.22.08.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.Xs.-.2024-03-20.at.19.11.50.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.Xs.-.2024-03-20.at.19.20.40.mp4

MacOS: Chrome / Safari

CleanShot.2024-03-20.at.17.07.03.mp4

MacOS: Desktop

CleanShot.2024-03-20.at.17.15.04.mp4

fedirjh

Looks good to me. We have a bug with deleted tasks being calculated in the thread count,and it seems it needs a backend fix.

puneetlath · 2024-03-25T15:24:40Z

We have a bug with deleted tasks being calculated in the thread count,and it seems it needs a backend fix.

Has this been reported? If not, can you report it?

fedirjh · 2024-03-26T14:28:45Z

If not, can you report it?

@puneetlath I have report it : https://expensify.slack.com/archives/C049HHMV9SM/p1711463195704049

OSBotify · 2024-03-27T20:07:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-29T02:27:20Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-02T11:03:36Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

update all parent/ancestor thread data

5a71949

bernhardoj requested a review from a team as a code owner March 20, 2024 06:28

melvin-bot bot removed the request for review from a team March 20, 2024 06:28

melvin-bot bot requested a review from fedirjh March 20, 2024 06:28

bernhardoj commented Mar 20, 2024

View reviewed changes

bernhardoj added 3 commits March 20, 2024 14:44

fix type

cbdba9e

fix lint

4abbbd4

allow to include transaction thread

7e94513

bernhardoj commented Mar 20, 2024

View reviewed changes

src/libs/ReportUtils.ts Show resolved Hide resolved

fix lint

f5afda1

fedirjh approved these changes Mar 25, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath March 25, 2024 02:03

puneetlath approved these changes Mar 27, 2024

View reviewed changes

puneetlath merged commit 6c204ec into Expensify:main Mar 27, 2024
20 checks passed

github-actions bot mentioned this pull request Mar 29, 2024

Deploy Checklist: New Expensify 2024-03-29 #39222

Closed

melvin-bot bot mentioned this pull request Apr 2, 2024

[HOLD for payment 2024-04-09] [$500] LOW - Android-Thread-Incorrect number of replies displayed for multilevel thread when going back #38002

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correctly update thread ancestors reply count #38658

Correctly update thread ancestors reply count #38658

bernhardoj commented Mar 20, 2024

melvin-bot bot commented Mar 20, 2024

bernhardoj Mar 20, 2024

fedirjh Mar 25, 2024

fedirjh commented Mar 20, 2024 •

edited

Loading

fedirjh left a comment

puneetlath commented Mar 25, 2024

fedirjh commented Mar 26, 2024

OSBotify commented Mar 27, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

Correctly update thread ancestors reply count #38658

Correctly update thread ancestors reply count #38658

Conversation

bernhardoj commented Mar 20, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 20, 2024

bernhardoj Mar 20, 2024

Choose a reason for hiding this comment

fedirjh Mar 25, 2024

Choose a reason for hiding this comment

fedirjh commented Mar 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh left a comment

Choose a reason for hiding this comment

puneetlath commented Mar 25, 2024

fedirjh commented Mar 26, 2024

OSBotify commented Mar 27, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

fedirjh commented Mar 20, 2024 •

edited

Loading