Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] [$250] Thread - New message does not appear in main chat after returning from thread and sending text #39242

Closed
6 tasks done
lanitochka17 opened this issue Mar 29, 2024 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat
  3. Send a message
  4. Right click on the message > Reply in thread
  5. Send a reply
  6. Click on the link in header subtitle to return to main chat
  7. Send a message in the main chat

Expected Result:

The new message in Step 7 will appear in the chat view

Actual Result:

The new message in Step 7 does not appear in the chat view, but it shows in LHN. It only appears in the main chat after refreshing the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431590_1711719917502.missing_reply.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cc9654e48d69e950
  • Upwork Job ID: 1773825288715214848
  • Last Price Increase: 2024-03-29
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsb

@lanitochka17
Copy link
Author

@mountiny FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01cc9654e48d69e950

@melvin-bot melvin-bot bot changed the title Thread - New message does not appear in main chat after returning from thread and sending text [$500] Thread - New message does not appear in main chat after returning from thread and sending text Mar 29, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 29, 2024
@mountiny mountiny changed the title [$500] Thread - New message does not appear in main chat after returning from thread and sending text [$250] Thread - New message does not appear in main chat after returning from thread and sending text Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

Copy link

melvin-bot bot commented Mar 29, 2024

Upwork job price has been updated to $250

@mountiny
Copy link
Contributor

This seems odd and External to me. Curious if anyone can spot what introduced this

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Mar 29, 2024
@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 29, 2024
@mountiny
Copy link
Contributor

Made a revert of #38722 and confirmed the issue is resolved.

@rayane-djouah
Copy link
Contributor

Partial revert merged

@marcaaron
Copy link
Contributor

Seems like the linked PR is merged and on staging so gonna take the blocker off.

@marcaaron marcaaron removed the DeployBlockerCash This issue or pull request should block deployment label Apr 1, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 2, 2024

We can close this now I believe

@mountiny mountiny closed this as completed Apr 2, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 2, 2024
@melvin-bot melvin-bot bot changed the title [$250] Thread - New message does not appear in main chat after returning from thread and sending text [HOLD for payment 2024-04-09] [$250] Thread - New message does not appear in main chat after returning from thread and sending text Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-04-09] [$250] Thread - New message does not appear in main chat after returning from thread and sending text [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] [$250] Thread - New message does not appear in main chat after returning from thread and sending text Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment (Needs manual offer from BZ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants