Update thread headers and ancestry to deep link back to the original comment using comment linking #39454

rayane-djouah · 2024-04-02T22:15:30Z

Details

Update thread headers and ancestry to deep link back to the original comment using comment linking.

Fixed Issues

$ #38979
PROPOSAL: N/A

Tests

Test 1:

Go to chat.
Go offline.
Send a message.
Create a thread on the message.
Click on the parent "Thread" link.
Verify that the parent report is opened and the parent message is highlighted.

Test 2:

Go to chat.
Go offline.
Send a message.
Create a thread on the message.
Click on the parent "Thread" link.
Verify that the parent report is opened without skeleton loading (the parent message is not highlighted offline)

Test 3:

Open a report.
Create a task.
Go to task report.
Delete the task.
Click the room link under the header subtitle.
Verify that the parent will open without issue.

Test 4 (Web and mWeb only):

Open any report
Send some messages (around 6-7 messages)
Hover over the 3rd or 4th parent message and click on Reply in the thread
Click on <<user's from>> link in header
Hover over the same parent message (which is already highlighted)
Click on reply in a thread
Go back to the main chat by the back button browser or the back button in the header
Verify that all parent messages are displayed in the main chat after going back from the thread by clicking the header back button or browser back button

Test 5:

Go to any chat
Send a message
Right-click on the message > Reply in the thread
Send a reply
Click on the link in the header subtitle to return to main chat
Send a message in the main chat
Verify that the new message in Step 6 will appear in the chat view

Test 6:

Navigate to a report that has multiple messages
Mark a message at the bottom of the list unread
Scroll up to older message
Reply in the thread with one of the older messages
Click on the 'From' link on the thread header
Scroll up to older messages
'New message' button should be displayed

Verify that no errors appear in the JS console

Offline tests

Test 2

QA Steps

Same as "Tests"

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Recording.2024-04-05.070802.mp4

Android: mWeb Chrome

Recording.2024-04-05.024057.mp4

iOS: Native

Recording.2024-04-05.074510.mp4

iOS: mWeb Safari

Recording.2024-04-05.022119.mp4

Recording.2024-04-05.023447.mp4

MacOS: Chrome / Safari

Recording.2024-04-05.015422.mp4

MacOS: Desktop

Recording.2024-04-05.021151.mp4

…comment using comment linking

… until refresh, the cause of the bug: when we already have messages after the linked message, loadNewerChats and handleReportActionPagination are called and isFirstLinkedActionRender.current is set to false, but when the linked message is the last message in the report handleReportActionPagination is not called (based on hasNewestReportAction) and isFirstLinkedActionRender.current remains true.

…tle in a deleted report with messages

…itle in a deleted report with no messages

…stor message offline

…g from thread and sending text | Report - 'New message' button is not displayed when navigating to parent report | Chat - Parent msgs disappear after back from thread by clicking header/browser back button

rayane-djouah · 2024-04-04T23:10:59Z

All previous blockers are now fixed:

[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Task - Not here page shows up when opening room link under header subtitle in deleted task #39251 Fixed
[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Thread - App shows skeleton loading when clicking on parent/ancestor message offline #39264 Fixed
[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] [$250] Thread - New message does not appear in main chat after returning from thread and sending text #39242 Fixed
[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Report - 'New message' button is not displayed when navigating to parent report #39291 Fixed
[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Chat - Parent msgs disappear after back from thread by clicking header/browser back button #39277 Fixed

…o parent report

…deep-link-back-to-the-original-comment

melvin-bot · 2024-04-05T06:48:05Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/home/report/ReportActionsView.tsx

…deep-link-back-to-the-original-comment

rushatgabhane · 2024-04-09T20:04:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-04-10.at.02.04.46.mov

iOS: Native

Screen.Recording.2024-04-10.at.02.21.06.mov

iOS: mWeb Safari

Screen.Recording.2024-04-10.at.02.17.40.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-10.at.01.55.16.mov

Screen.Recording.2024-04-10.at.01.57.29.mov

MacOS: Desktop

Screen.Recording.2024-04-10.at.02.29.25.mov

melvin-bot · 2024-04-09T20:28:37Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #38979 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

OSBotify · 2024-04-10T00:24:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-10T17:46:21Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:55:14Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T19:34:27Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-18T04:32:12Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane · 2024-04-28T17:15:08Z

Hey, this PR caused a bug. More details here - #40087 (comment)

It has been handled but just FYI

rayane-djouah · 2024-06-17T19:37:49Z

The PR caused this bug: #41514
More details here: #41514 (comment)

ishpaul777 · 2024-08-30T18:32:55Z

src/pages/home/report/ReportActionsView.tsx

-            (reportActionID && indexOfLinkedAction > -1 && !hasNewestReportAction && !isLoadingOlderReportsFirstNeeded) ||
-            (!reportActionID && !hasNewestReportAction && !isLoadingOlderReportsFirstNeeded)
-        ) {
+        if ((reportActionID && indexOfLinkedAction > -1 && !isLoadingOlderReportsFirstNeeded) || (!reportActionID && !isLoadingOlderReportsFirstNeeded)) {


Coming from #45227, (Bz Checklist)

This PR introduced a regression, Detailed RCA can be found in this proposal #45227 (comment)

rayane-djouah added 4 commits April 2, 2024 23:14

Update thread headers and ancestry to deep link back to the original …

931ea45

…comment using comment linking

Fix: Not here page shows up when opening room link under header subti…

35e9511

…tle in a deleted report with messages

Fix: Not here page shows up when opening room link under header subt…

5f0581d

…itle in a deleted report with no messages

rayane-djouah mentioned this pull request Apr 3, 2024

[HOLD for payment 2024-04-25] [$250] HIGH: [Comment linking] Update thread headers / ancestry to deep link back to the original comment #38979

Closed

rayane-djouah added 2 commits April 4, 2024 23:38

Fix: Thread - App shows skeleton loading when clicking on parent/ance…

55495c7

…stor message offline

Fix: Thread - New message does not appear in main chat after returnin…

75bc459

…g from thread and sending text | Report - 'New message' button is not displayed when navigating to parent report | Chat - Parent msgs disappear after back from thread by clicking header/browser back button

rayane-djouah added 9 commits April 5, 2024 00:14

Fix lint error

14ae825

Prettier

97316f0

Fix: Report - 'New message' button is not displayed when navigating t…

2dfabdc

…o parent report

Merge branch 'Expensify:main' into Update-thread-headers-ancestry-to-…

e145914

…deep-link-back-to-the-original-comment

Fix: comment linking does not preserve message position on native

4f6f0e3

Fix: comment linking does not preserve message position

61d378a

Fix lint errors

ce32cad

Fix lint errors

2750dce

Prettier

45e1992

rayane-djouah marked this pull request as ready for review April 5, 2024 06:48

rayane-djouah requested a review from a team as a code owner April 5, 2024 06:48

melvin-bot bot requested review from rushatgabhane and removed request for a team April 5, 2024 06:48

rayane-djouah commented Apr 9, 2024

View reviewed changes

src/pages/home/report/ReportActionsView.tsx Show resolved Hide resolved

Merge branch 'Expensify:main' into Update-thread-headers-ancestry-to-…

73361a9

…deep-link-back-to-the-original-comment

rushatgabhane approved these changes Apr 9, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg April 9, 2024 21:00

jasperhuangg approved these changes Apr 10, 2024

View reviewed changes

jasperhuangg merged commit 6f52327 into Expensify:main Apr 10, 2024
17 checks passed

github-actions bot mentioned this pull request Apr 10, 2024

Deploy Checklist: New Expensify 2024-04-10 #40026

Closed

blimpich mentioned this pull request Apr 10, 2024

[HOLD for payment 2024-04-25] Chat - Not here page shows up when deleting message after returning from thread #40027

Closed

6 tasks

kbecciv mentioned this pull request Apr 10, 2024

[$500] Thread - Message sent after returning from thread is not shown after refreshing the page #40037

Closed

6 tasks

lanitochka17 mentioned this pull request Apr 11, 2024

[HOLD for payment 2024-04-25] iOS - Thread - Unable to send a message after returning from thread #40057

Closed

6 tasks

youssef-lr mentioned this pull request Apr 11, 2024

[HOLD for payment 2024-04-25] [$250] IOU - Blank page after returning to IOU report from thread and deleting the other request #40087

Closed

6 tasks

rayane-djouah mentioned this pull request Apr 11, 2024

Follow up to "Update thread headers ancestry to deep link back to the original comment" #40155

Merged

50 tasks

rayane-djouah mentioned this pull request Jun 17, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Chat - Unable to navigate to LHN, back button loops between WS details & main chat page #41514

Closed

6 tasks

bernhardoj mentioned this pull request Jul 11, 2024

[$250] IOU - Web - Loading spinner appears under expense every time open the expense page #45227

Closed

6 tasks

ishpaul777 reviewed Aug 30, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update thread headers and ancestry to deep link back to the original comment using comment linking #39454

Update thread headers and ancestry to deep link back to the original comment using comment linking #39454

rayane-djouah commented Apr 2, 2024 •

edited

Loading

rayane-djouah commented Apr 4, 2024

melvin-bot bot commented Apr 5, 2024

rushatgabhane commented Apr 9, 2024 •

edited

Loading

melvin-bot bot commented Apr 9, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 18, 2024

rushatgabhane commented Apr 28, 2024 •

edited

Loading

rayane-djouah commented Jun 17, 2024

ishpaul777 Aug 30, 2024

Update thread headers and ancestry to deep link back to the original comment using comment linking #39454

Update thread headers and ancestry to deep link back to the original comment using comment linking #39454

Conversation

rayane-djouah commented Apr 2, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rayane-djouah commented Apr 4, 2024

melvin-bot bot commented Apr 5, 2024

rushatgabhane commented Apr 9, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Apr 9, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 18, 2024

rushatgabhane commented Apr 28, 2024 • edited Loading

rayane-djouah commented Jun 17, 2024

ishpaul777 Aug 30, 2024

Choose a reason for hiding this comment

rayane-djouah commented Apr 2, 2024 •

edited

Loading

rushatgabhane commented Apr 9, 2024 •

edited

Loading

rushatgabhane commented Apr 28, 2024 •

edited

Loading