Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update thread headers and ancestry to deep link back to the original comment using comment linking #39454

Merged
merged 16 commits into from
Apr 10, 2024
Merged

Update thread headers and ancestry to deep link back to the original comment using comment linking #39454

merged 16 commits into from
Apr 10, 2024

Commits on Apr 2, 2024

  1. Update thread headers and ancestry to deep link back to the original … 

    …comment using comment linking
    @rayane-djouah
    rayane-djouah committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    931ea45 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Fix: when linking the last message, New sent message is not displayed… 

    … until refresh, the cause of the bug: when we already have messages after the linked message, loadNewerChats and handleReportActionPagination are called and isFirstLinkedActionRender.current is set to false, but when the linked message is the last message in the report handleReportActionPagination is not called (based on hasNewestReportAction) and isFirstLinkedActionRender.current remains true.
    @rayane-djouah
    rayane-djouah committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9d56c09 View commit details
    Browse the repository at this point in the history

  2. Fix: Not here page shows up when opening room link under header subti… 

    …tle in a deleted report with messages
    @rayane-djouah
    rayane-djouah committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    35e9511 View commit details
    Browse the repository at this point in the history

  3. Fix: Not here page shows up when opening room link under header subt… 

    …itle in a deleted report with no messages
    @rayane-djouah
    rayane-djouah committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5f0581d View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Fix: Thread - App shows skeleton loading when clicking on parent/ance… 

    …stor message offline
    @rayane-djouah
    rayane-djouah committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    55495c7 View commit details
    Browse the repository at this point in the history

  2. Fix: Thread - New message does not appear in main chat after returnin… 

    …g from thread and sending text | Report - 'New message' button is not displayed when navigating to parent report | Chat - Parent msgs disappear after back from thread by clicking header/browser back button
    @rayane-djouah
    rayane-djouah committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    75bc459 View commit details
    Browse the repository at this point in the history

  3. Fix lint error

    @rayane-djouah
    rayane-djouah committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    14ae825 View commit details
    Browse the repository at this point in the history

  4. Prettier

    @rayane-djouah
    rayane-djouah committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    97316f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Fix: Report - 'New message' button is not displayed when navigating t… 

    …o parent report
    @rayane-djouah
    rayane-djouah committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2dfabdc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'Expensify:main' into Update-thread-headers-ancestry-to-… 

    …deep-link-back-to-the-original-comment
    @rayane-djouah
    rayane-djouah authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e145914 View commit details
    Browse the repository at this point in the history

  3. Fix: comment linking does not preserve message position on native

    @rayane-djouah
    rayane-djouah committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    4f6f0e3 View commit details
    Browse the repository at this point in the history

  4. Fix: comment linking does not preserve message position

    @rayane-djouah
    rayane-djouah committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    61d378a View commit details
    Browse the repository at this point in the history

  5. Fix lint errors

    @rayane-djouah
    rayane-djouah committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ce32cad View commit details
    Browse the repository at this point in the history

  6. Fix lint errors

    @rayane-djouah
    rayane-djouah committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2750dce View commit details
    Browse the repository at this point in the history

  7. Prettier

    @rayane-djouah
    rayane-djouah committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    45e1992 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Merge branch 'Expensify:main' into Update-thread-headers-ancestry-to-… 

    …deep-link-back-to-the-original-comment
    @rayane-djouah
    rayane-djouah authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    73361a9 View commit details
    Browse the repository at this point in the history