perf: Reduce heavy operations in Request Money flow #39063

TMisiukiewicz · 2024-03-27T14:23:17Z

Details

Fixed Issues

$ #39133
PROPOSAL:

Tests

Steps for Scan tab

Upload a receipt/take a photo
Press Next

Steps for Manual tab

Go to "Manual tab"
Fill the amount
Press "Next"

Steps for Distance tab

Go to Distance tab
Fill the Start and Stop
Press "Next"

Request money from workspace - test it in Scan/Manual/Distance tabs

Tap Global Create
Tap Request Money
Follow the steps for Scan/Manual/Distance
Type "workspace" in search and verify it is not blocking UI while typing
Tap the workspace name
Verify you've been moved to the next step smoothly

Split - workspace - test it in Scan/Manual/Distance tabs

Tap Global Create
Tap Request Money
Follow the steps for Scan/Manual/Distance
Type "workspace" in search and verify it is not blocking UI while typing
Press "Split" next to the workspace name and press "Next"
Verify you've been moved to the next step smoothly and workspace name is visible in the "Split with"

Split - users - test it in Scan/Manual/Distance tabs

Tap Global Create
Tap Request Money
Follow the steps for Scan/Manual/Distance
Press "Split" next to at least two users
Press "Next"
Verify you've been moved to the next step and users are visible in the "Split with"

Send money

Tap Global Create
Tap Send Money
Type any existing user name/email in search and verify it is not blocking UI while typing
Tap the user name
Verify you've been moved to the next step smoothly

Request from DM - test it in Scan/Manual/Distance tabs

Open a DM
Open a create menu
Press "Request money"
Follow the steps for Scan/Manual
Verify you've been moved to the next step

Send money from DM - test it in Scan/Manual/Distance tabs

Open a DM
Open a create menu
Press "Send money"
Fill the amount of money
Verify you've been moved to the next step

Request from workspace chat - test it in Scan/Manual/Distance tabs

Open a workspace chat
Open a create menu
Press "Request money"
Follow the steps for Scan/Manual/Distance
Verify you've been moved to the next step

Split bill from workspace chat - test it in Scan/Manual/Distance tabs

Open a workspace chat
Open a create menu
Press "Split bill"
Follow the steps for Scan/Manual/Distance
Verify you've been moved to the next step

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

Steps for Scan tab

Upload a receipt/take a photo
Press Next

Steps for Manual tab

Go to "Manual tab"
Fill the amount
Press "Next"

Steps for Distance tab

Go to Distance tab
Fill the Start and Stop
Press "Next"

Request money from workspace - test it in Scan/Manual/Distance tabs

Tap Global Create
Tap Request Money
Follow the steps for Scan/Manual/Distance
Type "workspace" in search and verify it is not blocking UI while typing
Tap the workspace name
Verify you've been moved to the next step smoothly

Split - workspace - test it in Scan/Manual/Distance tabs

Tap Global Create
Tap Request Money
Follow the steps for Scan/Manual/Distance
Type "workspace" in search and verify it is not blocking UI while typing
Press "Split" next to the workspace name and press "Next"
Verify you've been moved to the next step smoothly and workspace name is visible in the "Split with"

Split - users - test it in Scan/Manual/Distance tabs

Tap Global Create
Tap Request Money
Follow the steps for Scan/Manual/Distance
Press "Split" next to at least two users
Press "Next"
Verify you've been moved to the next step and users are visible in the "Split with"

Send money

Tap Global Create
Tap Send Money
Type any existing user name/email in search and verify it is not blocking UI while typing
Tap the user name
Verify you've been moved to the next step smoothly

Request from DM - test it in Scan/Manual/Distance tabs

Open a DM
Open a create menu
Press "Request money"
Follow the steps for Scan/Manual
Verify you've been moved to the next step

Send money from DM - test it in Scan/Manual/Distance tabs

Open a DM
Open a create menu
Press "Send money"
Fill the amount of money
Verify you've been moved to the next step

Request from workspace chat - test it in Scan/Manual/Distance tabs

Open a workspace chat
Open a create menu
Press "Request money"
Follow the steps for Scan/Manual/Distance
Verify you've been moved to the next step

Split bill from workspace chat - test it in Scan/Manual/Distance tabs

Open a workspace chat
Open a create menu
Press "Split bill"
Follow the steps for Scan/Manual/Distance
Verify you've been moved to the next step

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

ANDROID.mov

Android: mWeb Chrome

ANDROID.WEB.mov

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOS.WEB.mp4

MacOS: Chrome / Safari

WEB.mov

MacOS: Desktop

DESKTOP.mov

…workspace

melvin-bot · 2024-03-28T08:43:21Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2024-03-28T09:28:29Z

Seeking a C+ to address this immediately

mountiny

@akinwale @TMisiukiewicz Could you update the test steps to test all the various money reqeust flows?

Request money - manual, scan, distance
Send money
Split request
Test the same from within DM chat, IOU report or workspace chat
Test Split with workspace

src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

mountiny · 2024-03-28T09:35:50Z

src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

+})(
+    memo(
+        MoneyTemporaryForRefactorRequestParticipantsSelector,
+        (prevProps, nextProps) =>


Are we sure we dont have to add more checks for this memo?

Updated the memo with additional check for betas. The only non-checked props now are

callback functions

Onyx prop: reports

I think check for reports would need a deep equality comparision, which might be a costy operation

akinwale · 2024-03-28T09:38:05Z

src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

+        MoneyTemporaryForRefactorRequestParticipantsSelector,
+        (prevProps, nextProps) =>
+            _.isEqual(prevProps.participants, nextProps.participants) &&
+            prevProps.didScreenTransitionEnd === nextProps.didScreenTransitionEnd &&


@TMisiukiewicz Is there a particular reason we're checking didScreenTransitionEnd here, especially as the event never fires on Android?

in this page, didScreenTransitionEnd is used to prevent generating options unless the transition ended, to avoid doing heavy calculations while animation is happening. Without checking it, we'd infinitely get stuck on the skeleton

akinwale · 2024-03-28T09:44:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

39063-android-native.mp4

Android: mWeb Chrome

39063-android-chrome.mp4

iOS: Native

39063-ios-native.mp4

iOS: mWeb Safari

39063-ios-safari.mp4

MacOS: Chrome / Safari

39063-web.mp4

MacOS: Desktop

39063-desktop.mp4

akinwale · 2024-03-28T10:11:01Z

@TMisiukiewicz The search term "Workspac" doesn't return results, but this is happening on main as well. Is this something we want to fix here, @mountiny?

Screen.Recording.2024-03-28.at.11.02.41.mp4

TMisiukiewicz · 2024-03-28T11:03:56Z

@akinwale @mountiny this should be fixed once we apply the filtering from #37909 in this screen

akinwale

LGTM.

TMisiukiewicz · 2024-03-28T13:44:39Z

@mountiny test steps are up to date now

mountiny

Ok thank you, lets try this one!

melvin-bot · 2024-03-28T22:11:10Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-03-28T22:17:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mountiny · 2024-03-28T22:27:25Z

Tests were passing

OSBotify · 2024-03-29T02:28:50Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-02T11:05:06Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

TMisiukiewicz added 3 commits March 26, 2024 14:44

Merge remote-tracking branch 'upstream/main' into perf/request-money-…

23def11

…workspace

Merge branch 'main' into perf/request-money-workspace

21ccc39

decouple search in server from update search value and memoize component

7adff95

mountiny assigned TMisiukiewicz Mar 27, 2024

TMisiukiewicz marked this pull request as ready for review March 28, 2024 08:43

TMisiukiewicz requested a review from a team as a code owner March 28, 2024 08:43

melvin-bot bot requested review from akinwale and removed request for a team March 28, 2024 08:43

mountiny removed the request for review from akinwale March 28, 2024 09:28

mountiny requested a review from akinwale March 28, 2024 09:32

mountiny reviewed Mar 28, 2024

View reviewed changes

akinwale reviewed Mar 28, 2024

View reviewed changes

akinwale approved these changes Mar 28, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny March 28, 2024 13:37

add memo check for betas

74ff9d1

mountiny approved these changes Mar 28, 2024

View reviewed changes

mountiny merged commit 7603719 into Expensify:main Mar 28, 2024
16 checks passed

melvin-bot bot added the Emergency label Mar 28, 2024

mountiny removed the Emergency label Mar 28, 2024

github-actions bot mentioned this pull request Mar 29, 2024

Deploy Checklist: New Expensify 2024-03-29 #39222

Closed

melvin-bot bot mentioned this pull request Apr 2, 2024

[HOLD for payment 2024-04-09] [$500] [Performance] Reduce the amount of expensive getOptions calls in Request Money flow #39133

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: Reduce heavy operations in Request Money flow #39063

perf: Reduce heavy operations in Request Money flow #39063

TMisiukiewicz commented Mar 27, 2024 •

edited

Loading

melvin-bot bot commented Mar 28, 2024

mountiny commented Mar 28, 2024

mountiny left a comment

mountiny Mar 28, 2024

TMisiukiewicz Mar 28, 2024

akinwale Mar 28, 2024 •

edited

Loading

TMisiukiewicz Mar 28, 2024

akinwale commented Mar 28, 2024 •

edited

Loading

akinwale commented Mar 28, 2024

TMisiukiewicz commented Mar 28, 2024

akinwale left a comment

TMisiukiewicz commented Mar 28, 2024

mountiny left a comment

melvin-bot bot commented Mar 28, 2024

OSBotify commented Mar 28, 2024

mountiny commented Mar 28, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

perf: Reduce heavy operations in Request Money flow #39063

perf: Reduce heavy operations in Request Money flow #39063

Conversation

TMisiukiewicz commented Mar 27, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 28, 2024

mountiny commented Mar 28, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny Mar 28, 2024

Choose a reason for hiding this comment

TMisiukiewicz Mar 28, 2024

Choose a reason for hiding this comment

akinwale Mar 28, 2024 • edited Loading

Choose a reason for hiding this comment

TMisiukiewicz Mar 28, 2024

Choose a reason for hiding this comment

akinwale commented Mar 28, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

akinwale commented Mar 28, 2024

TMisiukiewicz commented Mar 28, 2024

akinwale left a comment

Choose a reason for hiding this comment

TMisiukiewicz commented Mar 28, 2024

mountiny left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 28, 2024

OSBotify commented Mar 28, 2024

mountiny commented Mar 28, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

TMisiukiewicz commented Mar 27, 2024 •

edited

Loading

akinwale Mar 28, 2024 •

edited

Loading

akinwale commented Mar 28, 2024 •

edited

Loading