Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Composer flickers when using header markdown #39258

Closed
1 of 6 tasks
lanitochka17 opened this issue Mar 29, 2024 · 16 comments
Closed
1 of 6 tasks

Chat - Composer flickers when using header markdown #39258

lanitochka17 opened this issue Mar 29, 2024 · 16 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open a chat
  2. Start typing # followed by any letter (Preferebly upper case letter)

Expected Result:

Composer should not flicker

Actual Result:

Composer flickers for a second while typing the letter followed by #

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431621_1711720400855.38152.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@thienlnam thienlnam assigned thienlnam and unassigned pecanoro Mar 29, 2024
@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 29, 2024
@thienlnam
Copy link
Contributor

Not a blocker, added to the main tracking issue

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@pecanoro
Copy link
Contributor

pecanoro commented Apr 1, 2024

@thienlnam Even if not a deploy blocker, who is fixing this anyhow? And why unassigning me?

@pecanoro pecanoro self-assigned this Apr 1, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@thienlnam
Copy link
Contributor

SWM is fixing these in order of priority of the tracking issue - I unassigned since this came from the live-markdown PR we just merged and since this is lower on the priority list it might be a while until we get to this

@pecanoro
Copy link
Contributor

pecanoro commented Apr 2, 2024

@thienlnam Ahh got it! I don't mind reviewing the PR so I get to learn how this works, so I would love to stay assigned!

@pecanoro pecanoro added Weekly KSv2 and removed Daily KSv2 labels Apr 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
@pecanoro
Copy link
Contributor

Still no update, agency is working on higher priority issues for markdown

@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2024
@pecanoro
Copy link
Contributor

Still no update, agency is working on higher priority issues for markdown

@melvin-bot melvin-bot bot removed the Overdue label Apr 25, 2024
@melvin-bot melvin-bot bot added the Overdue label May 3, 2024
@pecanoro
Copy link
Contributor

pecanoro commented May 6, 2024

Still no update, agency is working on higher priority issues for markdown

@pecanoro pecanoro closed this as completed May 6, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 6, 2024
@pecanoro pecanoro reopened this May 6, 2024
@thienlnam
Copy link
Contributor

@BartoszGrajdek Do you think you could add this one to your list?

@BartoszGrajdek
Copy link
Contributor

I believe @Skalakid was working on this 👀

@BartoszGrajdek
Copy link
Contributor

But I can't reproduce it anymore, are you sure this bug is still happening? @thienlnam

@thienlnam
Copy link
Contributor

Ah yeah I can't reproduce either, this was probably fixed in one of our version bumps - @pecanoro feel free to close if you are also unable to reproduce

@pecanoro
Copy link
Contributor

pecanoro commented May 8, 2024

Same, closing!

@pecanoro pecanoro closed this as completed May 8, 2024
@Skalakid
Copy link
Contributor

Skalakid commented May 9, 2024

I fixed that in #40128 in similar issue, so the problem is gone :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants