[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Thread - Group chat thread header shows unavailable workspace icon

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat.
3. Create a group chat.
4. Send a message in group chat.
5. Right click on message > Reply in thread.

Expected Result:

Group chat thread header will not show unavailable workspace icon.

Actual Result:

Group chat thread header shows unavailable workspace icon.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6431606_1711720106647.bandicam_2024-03-29_21-45-01-561.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[ZhenjaHorbach]

In fact, this doesn't look like a regression and as an unaccounted case

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread - Group chat thread header shows unavailable workspace icon

What is the root cause of that problem?

The main problem with issue is that when we try to get icon for our header we use SubscriptAvatar which always uses 2 images

App/src/pages/home/HeaderView.tsx

Lines 250 to 254 in fc683cb

	<SubscriptAvatar
	mainAvatar={icons[0]}
	secondaryAvatar={icons[1]}
	size={defaultSubscriptSize}
	/>

Because group thread Fits under isWorkspaceThread condition

App/src/libs/ReportUtils.ts

Lines 4805 to 4807 in c77c635

	if (isWorkspaceThread(report)) {
	return true;
	}

What changes do you think we should make in order to solve the problem?

To fix this issue we can use MultipleAvatars for group threads

For this we need create new function isGroupThread

function isGroupThread(report: OnyxEntry<Report>): boolean {
    return isThread(report) && isChatReport(report) && getChatType(report) === CONST.REPORT.CHAT_TYPE.GROUP;
}

And then return false for shouldReportShowSubscript when it's group chat

if (isGroupThread(report)) {
    return false;
}

App/src/libs/ReportUtils.ts

Lines 4805 to 4807 in c77c635

	if (isWorkspaceThread(report)) {
	return true;
	}

And then update getIcons and add

			**if(isGroupThread(report)){
				const parentReportAction = ReportActionsUtils.getParentReportAction(report);
				const memberIcon = {
								source: UserUtils.getAvatar(personalDetails?.[parentReportAction.actorAccountID ?? -1]?.avatar ?? '', parentReportAction.actorAccountID ?? -1),
								id: parentReportAction.actorAccountID,
								type: CONST.ICON_TYPE_AVATAR,
								name: personalDetails?.[parentReportAction.actorAccountID ?? -1]?.displayName ?? '',
								fallbackIcon: personalDetails?.[parentReportAction.actorAccountID ?? -1]?.fallbackIcon,
				};

				return [memberIcon];
			}**

What alternative solutions did you explore? (Optional)

NA

[NikkiWines]

Hmm, I'm not able to reproduce this on staging but I also see a different group icon to begin with 🤔

Screen.Recording.2024-03-29.at.10.49.23.mov

[ZhenjaHorbach]

Staging:
After creating a chat and then a thread

[dylanexpensify]

@NikkiWines I don't think this is a deploy blocker, but what do you think? Attempting reproduction now

[dylanexpensify]

Could reproduce 👍

[NikkiWines]

I still can't reproduce it 😢 @dylanexpensify @ZhenjaHorbach are either of you able to reproduce the bug on prod? If not, let's identify what PR introduced the changes and whether or not it's a regression or just a mishandled edge case.

[ZhenjaHorbach]

I still can't reproduce it 😢 @dylanexpensify @ZhenjaHorbach are either of you able to reproduce the bug on prod? If not, let's identify what PR introduced the changes and whether or not it's a regression or just a mishandled edge case.

This is not reproduced on production
But it's easy on staging
And I think this issue is related to this PR)
#37458

[marcaaron]

Thanks @NikkiWines. Gonna jump in here.

[marcaaron]

QA re-testing now.

[kavimuru]

This issue is fixed

39247.mp4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix Split Scan flow for Group Chats #39276

If no regressions arise, payment will be issued on 2024-04-09. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
• [@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@marcaaron] Determine if we should create a regression test for this bug.
• [@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix Split Scan flow for Group Chats #39276

If no regressions arise, payment will be issued on 2024-04-15. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
• [@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@marcaaron] Determine if we should create a regression test for this bug.
• [@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@marcaaron, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dylanexpensify]

Hmm, @marcaaron is there anyone we need to pay here?

[s77rt]

No payment is due here. This can be closed