[$500] Chat - The cursor appears before the last letter in the compose box when pasting

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.58.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1. Send a multiline message in any chat
2. Hover over the message
3. Click on the "..." button
4. Click on "Copy to clipboard"
5. Paste it inside the compose box

Expected Result:

The cursor should appear after the last letter

Actual Result:

The cursor appears before the last letter in the compose box when copy/pasting multiline text

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bandicam.2024-03-29.16-46-01-107.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01500831e0ec092b01
• Upwork Job ID: 1774859672126918656
• Last Price Increase: 2024-04-01

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

We think this bug might be related to #vip-vsb

[m-natarajan]

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[thienlnam]

Not a blocker - added to the main tracking issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01500831e0ec092b01

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - The cursor appears before the last letter in the compose box when pasting

What is the root cause of that problem?

The main problem is that we use window.getSelection in conjunction with div

https://github.com/Expensify/react-native-live-markdown/blob/main/src/web/cursorUtils.ts#L113-L125

https://github.com/Expensify/react-native-live-markdown/blob/main/src/MarkdownTextInput.web.tsx#L537-L559

As result when we try to get range.legth we ignore each line break, so we have an offset (-1 for each new line)

What changes do you think we should make in order to solve the problem?

To fix this issue we can use span instead of div

https://github.com/Expensify/react-native-live-markdown/blob/main/src/MarkdownTextInput.web.tsx#L537

And plus to save using styles for divs we need update display to block

https://github.com/Expensify/react-native-live-markdown/blob/main/src/MarkdownTextInput.web.tsx#L212-L223

I found a slightly similar problem here
https://stackoverflow.com/questions/63480153/window-getselection-baseoffset-is-wrong

Screen.Recording.2024-04-02.at.09.40.16.mov

What alternative solutions did you explore? (Optional)

Alternatively, we can update the result of window.getSelection()
and add the necessary offsets depending on what line we are on

[BartoszGrajdek]

This issue is already being handled in a PR by @Skalakid #39177 (comment) @thienlnam please assign him to this task

[ntdiary]

This issue is already being handled in a PR by @Skalakid #39177 (comment) @thienlnam please assign him to this task

un-assign myself. :)

[MitchExpensify]

I think @Skalakid needs to comment here for us to assign them

[Skalakid]

Hi, I'm Michał from SWM, an expert agency. Please assign me to this task

[BartoszGrajdek]

We should be able to close this one @thienlnam