[Pay meow][$500] [Held requests] Pay with Expensify button does not include amount after approving held request #39342

m-natarajan · 2024-03-31T22:27:01Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

issue found when validating #33124
Version Number: 1.4.58-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

Admin and employee are in the Collect workspace.

[Employee] Request money from the workspace chat.
[Employee] Create a money request
[Employee] Hold the request.
[Admin] Go to expense report.
[Admin] Click Approve button.
[Admin] Approve all the request.

Expected Result:

After approving all the held request, Pay with Expensify button will update to include the total amount (this is the case when approving two requests where one of the requests is held).

Actual Result:

After approving all the held request, Pay with Expensify button does not include the total amount. It only includes the total amount after visiting the transaction thread.

Workaround:

unknonw

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6433521_1711916993122.20240401_041807.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e05ae27f1f02458c
Upwork Job ID: 1774870331469250560
Last Price Increase: 2024-04-01
Automatic offers:

hoangzinh | Reviewer | 0

melvin-bot · 2024-03-31T22:27:13Z

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2024-03-31T22:27:14Z

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions · 2024-03-31T22:27:16Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

nkdengineer · 2024-04-01T07:14:23Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

After approving all the held request, Pay with Expensify button does not include the total amount. It only includes the total amount after visiting the transaction thread.

What is the root cause of that problem?

We set the formattedAmount prop as empty string if all transactions are held. After we approve the money request, the hold reason isn't cleared in transaction so this check is still true and Pay with Expensify button doesn't include amount.

When we open the transaction thread report, OpenReport is called and it returns the hold reason of transaction as empty. It leads this check is false and then the amount appears after going back from transaction thread report.

App/src/components/MoneyReportHeader.tsx

Line 155 in c848cb6

    
           formattedAmount={!ReportUtils.hasOnlyHeldExpenses(moneyRequestReport.reportID) ? displayedAmount : ''}

What changes do you think we should make in order to solve the problem?

Since all hold transactions will be un-held after we approve the money request, we can add the check approve report here to display the amount if the report is approved

formattedAmount={(!ReportUtils.hasOnlyHeldExpenses(moneyRequestReport.reportID) || ReportUtils.isReportApproved(moneyRequestReport))? displayedAmount : ''}

App/src/components/MoneyReportHeader.tsx

Line 155 in c848cb6

    
           formattedAmount={!ReportUtils.hasOnlyHeldExpenses(moneyRequestReport.reportID) ? displayedAmount : ''}

App/src/components/MoneyReportHeader.tsx

Line 187 in c848cb6

    
           formattedAmount={!ReportUtils.hasOnlyHeldExpenses(moneyRequestReport.reportID) ? displayedAmount : ''}

What alternative solutions did you explore? (Optional)

In approveMoneyRequest function, we can set the hold comment of all transactions to empty in optimisticData and then

revert it to the current hold comment in failureData

App/src/libs/actions/IOU.ts

Line 4609 in c848cb6

    
           function approveMoneyRequest(expenseReport: OnyxTypes.Report | EmptyObject, full?: boolean) {

Alternatively, we can hide the approve button if all requests are held

allgandalf · 2024-04-01T17:35:47Z

App/src/components/ProcessMoneyReportHoldMenu.tsx

Lines 52 to 54 in 4e6bd2d

    
           const onSubmit = (full: boolean) => { 
        
               if (isApprove) { 
        
                   IOU.approveMoneyRequest(moneyRequestReport, full);

Proposal

Please re-state the problem that we are trying to solve in this issue.

After we approve a money request, we don't see the amount in pay with expensify button.

What is the root cause of that problem?

After the recent PR, we can approve held requests as well

Now when we approve a held request we essentially call submit in ProcessMoneyReportHoldMenu:

App/src/components/ProcessMoneyReportHoldMenu.tsx

Lines 52 to 54 in 4e6bd2d

    
           const onSubmit = (full: boolean) => { 
        
               if (isApprove) { 
        
                   IOU.approveMoneyRequest(moneyRequestReport, full);

Here we check if the request is a approve one, and if yes then we call approveMoneyRequest and we pass the second parameter as full now we take full variable from the below:

App/src/components/ProcessMoneyReportHoldMenu.tsx

Lines 69 to 70 in 4e6bd2d

    
           onFirstOptionSubmit={() => onSubmit(false)} 
        
           onSecondOptionSubmit={() => onSubmit(true)}

Now you can see that as approve is a first option we set the value of full as false, this same value is passed to approveMoneyRequest and we never really approve these request, as we will only approve requests if we pass the first option as true.

What changes do you think we should make in order to solve the problem?

We need to update the submit function to always pass true if we have to approve a request:
The full condition was passed for some other case IMO and we just used it for approve request as well:

const onSubmit = (full: boolean) => {
        if (isApprove) {
            IOU.approveMoneyRequest(moneyRequestReport, true);
        } else if (chatReport && paymentType) {
            IOU.payMoneyRequest(paymentType, chatReport, moneyRequestReport, full);
        }
        onClose();
    };

What alternative solutions did you explore? (Optional)

If the first and second options are used to determine whether to approve full or partial transaction, then we can have a check of how many buttons exist, if only one button exists then we should update the approveMoneyRequest such that it will pass true if we have only one button and will pass full is we have 2 options

neil-marcellini · 2024-04-01T18:36:51Z

I think the problem should be described a bit differently, based on the following from the PR where this issue was found.

Whenever all money requests are on hold the total amount on approve/pay button shouldn't be displayed and it should redirect the user to modal with just one confirmation button asking to pay the full amount - since there are no "unheld" requests

The expected result is that the pay button should not display the amount when all requests are on hold.
The actual result is that it displays the amount after viewing the transaction thread.

neil-marcellini · 2024-04-01T18:37:48Z

@BartoszGrajdek are you around to help fix this?

neil-marcellini · 2024-04-01T18:38:41Z

@robertjchen would you be willing to take this over since you reviewed the PR and have the most context? I'll keep working on it until I hear otherwise.

robertjchen · 2024-04-01T18:42:40Z

sounds good, I can take it! This can definitely be handled by contributors 👍

melvin-bot · 2024-04-01T18:43:58Z

Job added to Upwork: https://www.upwork.com/jobs/~01e05ae27f1f02458c

melvin-bot · 2024-04-01T18:44:03Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

hoangzinh · 2024-04-03T17:21:19Z

@nkdengineer @GandalfGwaihir Thanks for proposals, everyone

@GandalfGwaihir I don't think your proposal has correct RCA. Moreover, your solution doesn't look good. It might cause calculate incorrect totalAmount here in case of partial approve
@nkdengineer's proposal looks good to me. RCA is correct and his alternative solution looks good. I just want to add a recommended is that, we only "set the hold comment of all transactions to empty in optimisticData" when [Admin] approves all requests

Link to selected proposal #39342 (comment)

🎀👀🎀 C+ reviewed

melvin-bot · 2024-04-03T17:21:28Z

Current assignee @robertjchen is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

robertjchen · 2024-04-03T18:49:52Z

Looks good to me as well, let's move forward with @nkdengineer 's proposal 👍

melvin-bot · 2024-04-03T18:50:14Z

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-04-03T18:50:16Z

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

nkdengineer · 2024-04-04T07:49:12Z

@hoangzinh The PR is here.

melvin-bot · 2024-04-29T18:40:16Z

This issue has not been updated in over 15 days. @robertjchen, @hoangzinh, @mallenexpensify, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

nkdengineer · 2024-04-30T09:34:05Z

@mallenexpensify The PR is deployed to production last month. Can you please add weekly label again and I think we're ready for payment here? Thanks.

mallenexpensify · 2024-05-01T00:38:02Z

Contributor: @nkdengineer paid $500 via Upwork
Contributor+: @hoangzinh paid $500 via Upwork.

@nkdengineer can you please accept the job and reply here once you have?

PR hit production on 4/22, automation failed here, I updated labels and such.

nkdengineer · 2024-05-02T15:42:54Z

@mallenexpensify Offer accepted, thanks 🙏

mallenexpensify · 2024-05-03T01:47:34Z

@nkdengineer paid, updated main payment comment above.

@hoangzinh can you fill out the BZ checklist? Looks like it didn't auto-post here, pasted below

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@] The PR that introduced the bug has been identified. Link to the PR:
[@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@] Determine if we should create a regression test for this bug.
[@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@bz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:l

melvin-bot · 2024-05-07T01:16:27Z

@robertjchen, @hoangzinh, @mallenexpensify, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

hoangzinh · 2024-05-07T15:55:25Z

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR: [WAVE7] Hold Requests: Approving/Paying expense reports with held requests #33124
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/33124/files#r1592713021
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

Precondition: Create a collect workspace and invite some users as employee

Sign in as an Employee in the above collect workspace
[Employee] Create two requests in the workspace chat
[Employee] Go to transaction thread report of a request and hold the request
[Employee] Submit the report
Sign in as an Admin in the above collect workspace
[Admin] Go to expense report and click on approve button
[Admin] Approve all requests
[Admin] Verify that the "Pay with Expensify" button appears and it includes the total amount

Do we agree 👍 or 👎

mallenexpensify · 2024-05-09T17:44:42Z

Thanks @hoangzinh , TestRail GH created

https://github.com/Expensify/Expensify/issues/394735

m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 31, 2024

melvin-bot bot assigned mallenexpensify Mar 31, 2024

melvin-bot bot assigned neil-marcellini Mar 31, 2024

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 31, 2024

github-actions bot mentioned this issue Mar 31, 2024

Deploy Checklist: New Expensify 2024-03-29 #39222

Closed

melvin-bot bot mentioned this issue Apr 1, 2024

[HOLD for payment 2024-04-09] [Held Requests] Approving/Paying expense reports with held requests #31345

Closed

robertjchen added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 1, 2024

robertjchen assigned robertjchen and unassigned neil-marcellini Apr 1, 2024

robertjchen added the External Added to denote the issue can be worked on by a contributor label Apr 1, 2024

melvin-bot bot changed the title ~~Hold request - Pay with Expensify button does not include amount after approving held request~~ [$500] Hold request - Pay with Expensify button does not include amount after approving held request Apr 1, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 1, 2024

melvin-bot bot assigned hoangzinh Apr 1, 2024

robertjchen assigned nkdengineer Apr 3, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 3, 2024

nkdengineer mentioned this issue Apr 4, 2024

Clear hold reason of all transactions when the admin approves all requests #39579

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 4, 2024

melvin-bot bot removed the Weekly KSv2 label Apr 29, 2024

melvin-bot bot added the Monthly KSv2 label Apr 29, 2024

mallenexpensify added Daily KSv2 and removed Reviewing Has a PR in review Monthly KSv2 labels May 1, 2024

mallenexpensify changed the title ~~[$500] [Held requests] Pay with Expensify button does not include amount after approving held request~~ [Pay meow][$500] [Held requests] Pay with Expensify button does not include amount after approving held request May 1, 2024

melvin-bot bot added the Overdue label May 6, 2024

hoangzinh mentioned this issue May 7, 2024

[WAVE7] Hold Requests: Approving/Paying expense reports with held requests #33124

Merged

50 tasks

melvin-bot bot removed the Overdue label May 7, 2024

mallenexpensify closed this as completed May 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Pay meow][$500] [Held requests] Pay with Expensify button does not include amount after approving held request #39342

[Pay meow][$500] [Held requests] Pay with Expensify button does not include amount after approving held request #39342

m-natarajan commented Mar 31, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Mar 31, 2024

melvin-bot bot commented Mar 31, 2024

github-actions bot commented Mar 31, 2024

nkdengineer commented Apr 1, 2024 •

edited

Loading

allgandalf commented Apr 1, 2024 •

edited

Loading

neil-marcellini commented Apr 1, 2024

neil-marcellini commented Apr 1, 2024

neil-marcellini commented Apr 1, 2024

robertjchen commented Apr 1, 2024

melvin-bot bot commented Apr 1, 2024

melvin-bot bot commented Apr 1, 2024

hoangzinh commented Apr 3, 2024

melvin-bot bot commented Apr 3, 2024

robertjchen commented Apr 3, 2024

melvin-bot bot commented Apr 3, 2024

melvin-bot bot commented Apr 3, 2024

nkdengineer commented Apr 4, 2024

melvin-bot bot commented Apr 29, 2024

nkdengineer commented Apr 30, 2024

mallenexpensify commented May 1, 2024 •

edited

Loading

nkdengineer commented May 2, 2024

mallenexpensify commented May 3, 2024

melvin-bot bot commented May 7, 2024

hoangzinh commented May 7, 2024

mallenexpensify commented May 9, 2024

[Pay meow][$500] [Held requests] Pay with Expensify button does not include amount after approving held request #39342

[Pay meow][$500] [Held requests] Pay with Expensify button does not include amount after approving held request #39342

Comments

m-natarajan commented Mar 31, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Mar 31, 2024

melvin-bot bot commented Mar 31, 2024

github-actions bot commented Mar 31, 2024

nkdengineer commented Apr 1, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

allgandalf commented Apr 1, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

neil-marcellini commented Apr 1, 2024

neil-marcellini commented Apr 1, 2024

neil-marcellini commented Apr 1, 2024

robertjchen commented Apr 1, 2024

melvin-bot bot commented Apr 1, 2024

melvin-bot bot commented Apr 1, 2024

hoangzinh commented Apr 3, 2024

melvin-bot bot commented Apr 3, 2024

robertjchen commented Apr 3, 2024

melvin-bot bot commented Apr 3, 2024

melvin-bot bot commented Apr 3, 2024

nkdengineer commented Apr 4, 2024

melvin-bot bot commented Apr 29, 2024

nkdengineer commented Apr 30, 2024

mallenexpensify commented May 1, 2024 • edited Loading

nkdengineer commented May 2, 2024

mallenexpensify commented May 3, 2024

melvin-bot bot commented May 7, 2024

hoangzinh commented May 7, 2024

BugZero Checklist:

Regression Test Proposal

mallenexpensify commented May 9, 2024

m-natarajan commented Mar 31, 2024 •

edited by melvin-bot bot

Loading

nkdengineer commented Apr 1, 2024 •

edited

Loading

allgandalf commented Apr 1, 2024 •

edited

Loading

mallenexpensify commented May 1, 2024 •

edited

Loading