Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-11] [HOLD for payment 2024-05-20] [Wave Collect] [Xero] [Import Flow] Create the Tracking Categories Page #39732

Closed
lakchote opened this issue Apr 5, 2024 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@lakchote
Copy link
Contributor

lakchote commented Apr 5, 2024

You need to build the page following the steps outlined here.

This will be worked on by SWM engineers, see Slack discussion here.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

Issue OwnerCurrent Issue Owner: @jliexpensify
@lakchote lakchote added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 5, 2024
@jliexpensify
Copy link
Contributor

Hi @lakchote - would this need to go to Internal for an engineer to work on, or are you happy for Contributors to tackle it? Thanks!

@lakchote
Copy link
Contributor Author

Hi @lakchote - would this need to go to Internal for an engineer to work on, or are you happy for Contributors to tackle it? Thanks!

Hi Jason! I've updated detail in the issue's body. Thanks!

@jliexpensify
Copy link
Contributor

Awesome, thanks Lucien - have left a message for SWM.

@filip-solecki
Copy link
Contributor

Hi! I am Filip from SWM and I'd like to work on this issue!

@lakchote lakchote changed the title [Wave Collect] [Xero] [Import Flow] Create the Tracking Categories Page [HOLD #39727] [Wave Collect] [Xero] [Import Flow] Create the Tracking Categories Page Apr 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 19, 2024
@jliexpensify
Copy link
Contributor

Not overdue! Any updates @filip-solecki?

@melvin-bot melvin-bot bot removed the Overdue label Apr 23, 2024
@filip-solecki
Copy link
Contributor

I will be working on this today or tomorrow as I had to jump to new Onboarding flow

@mananjadhav
Copy link
Collaborator

I am working on the PR and I have some open questions here and here ?

@lakchote
Copy link
Contributor Author

lakchote commented May 2, 2024

I am working on the PR and I have some open questions here and here ?

Answered you on Slack here

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 Overdue labels May 6, 2024
@trjExpensify
Copy link
Contributor

Looks like the PR deployed to staging 9 hours ago. There shouldn't be a hold in the title of this issue, right? Removing that.

@trjExpensify trjExpensify changed the title [HOLD #39727] [Wave Collect] [Xero] [Import Flow] Create the Tracking Categories Page [Wave Collect] [Xero] [Import Flow] Create the Tracking Categories Page May 9, 2024
@lakchote
Copy link
Contributor Author

lakchote commented May 9, 2024

Looks like the PR deployed to staging 9 hours ago. There shouldn't be a hold in the title of this issue, right? Removing that.

Yes, you're right. I've explained why this was merged here.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 13, 2024
@melvin-bot melvin-bot bot changed the title [Wave Collect] [Xero] [Import Flow] Create the Tracking Categories Page [HOLD for payment 2024-05-20] [Wave Collect] [Xero] [Import Flow] Create the Tracking Categories Page May 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-20. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@filip-solecki] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 17, 2024
Copy link

melvin-bot bot commented May 18, 2024

Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 19, 2024
@jliexpensify
Copy link
Contributor

@lakchote can I confirm that no payment is needed here?

  • @filip-solecki is from an agency
  • I see @fedirjh assigned to the PR but I don't see a review
  • @mananjadhav mentioned in a previous GH that this project is being billed all together

Is that correct?

@lakchote
Copy link
Contributor Author

@lakchote can I confirm that no payment is needed here?

  • @filip-solecki is from an agency
  • I see @fedirjh assigned to the PR but I don't see a review
  • @mananjadhav mentioned in a previous GH that this project is being billed all together

Is that correct?

Exactly, no payment needed here for @filip-solecki and @fedirjh.

As Filip was OOO, Manan took the lead on it to finish it in time.
For Fedirjh, no review was done.

I'm going to assign @mananjadhav for this issue, to reflect that, thanks!

@jliexpensify
Copy link
Contributor

Ok great, thanks! In that case - I think @mananjadhav is requesting one payment for the entirety of this project, is that correct?

Let me know if you need a Payment Summary - otherwise I'll close this out when I get online tomorrow.

Copy link

melvin-bot bot commented May 20, 2024

Payment Summary

Upwork Job

BugZero Checklist (@jliexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@jliexpensify
Copy link
Contributor

I believe Manan is including this as part of a larger invoice, so I'm going to close this out. There was no Upworks job.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 4, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-05-20] [Wave Collect] [Xero] [Import Flow] Create the Tracking Categories Page [HOLD for payment 2024-06-11] [HOLD for payment 2024-05-20] [Wave Collect] [Xero] [Import Flow] Create the Tracking Categories Page Jun 4, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jun 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

  • @mananjadhav requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jun 4, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants