-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wave Collect][Xero] Import tracking categories #41441
Conversation
src/pages/workspace/accounting/xero/XeroTrackingCategoryConfigurationPage.tsx
Outdated
Show resolved
Hide resolved
Design-wise this looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COST_CENTERS: 'cost centers', | ||
REGION: 'region', | ||
}, | ||
TRACKING_CATEGORY_OPTIONS: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These shouldn't be hardcoded, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will be hardcoded yes.
Got it. We'll be adding this in future. But at the moment I think it should show blank here then? @trjExpensify @lakchote ? |
Reviewer Checklist
Screenshots/VideosAndroid: mWeb ChromeiOS: NativeScreen.Recording.2024-05-07.at.01.14.59.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lakchote LGTM if you agree with #41441 (comment)
It was meant for @rushatgabhane to help him enable mapping options.
Report field will be added once we'll port I'd move in favour of showing blank there in the meantime. |
Thanks for the comment @lakchote. I'll push an update in a while for the Report field. |
@rushatgabhane @lakchote Added a fix to show blank for the report field. I didn't refactor too much because we are anyway going remove it later. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
I have merged by mistake (since we're on merge freeze). Since it's behind beta, and it should not influence any user behaviour we don't need to revert it. I've created a new |
🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.72-0 🚀
|
Tell us about PR Pre-props: bandicam.2024-05-09.14-15-22-495.mp4 |
@lanitochka17 Did you try the steps mentioned in the pre-requisites? Please find attached video on navigating through Xero. You should see Demo Company when you create a new account on Xero, and use that for syncing when you test it. xero-tracking-categories-setup.mov |
@mananjadhav Thanks for sharing the video again. I have a question, How to verify the PR step 6 and 8.d and e? Is this can only be done internally? |
You should be able to view this in the application data onyxdb in Chrom Dev tools. I've added a note in the steps along with the screenshot. |
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.72-1 🚀
|
Details
Fixed Issues
$ #39732
PROPOSAL:
Tests
Pre-requisite:
xero-tracking-categories-setup.mov
Steps
Tracking Categories
Import
toggle switch.Import
to On, in the data you can verify thatpolicy_<policyID>.connections.xero.config.importTrackingCategories
is set to true. On switching off, it is set to false.Map Xero cost centers to
andMap Xero regions to
.a. You should see the title of the page as the
Map Xero <fieldname> to
.b. You should see two options
Xero contact default
andTags
as two menu items.c. On selecting any one of the options, you should be redirected back to the tracking categories page, and the selected option should show up against each field title.
d. In
policy_<policyID>.connections.xero.mappings.trackingCategory_<trackingCategoryId>
you should see the selected value , ie,DEFAULT
forXero contact default
andTAG
forTags
.e. The trackingCategoryId should be based on the
id
field ofpolicy_<policyID>.connections.xero.trackingCategories.name
matched to cost centers and regions respectively.For all the data verification related info, go to Chrom Dev Tools -> Application -> Storage -> OnyxDB -> Search for your policy_. Check out the data in the connections object as shown in the screenshot below.
Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android-xero-tracking-categories.mov
Android: mWeb Chrome
mweb-chrome-xero-tracking-categories.mov
iOS: Native
ios-xero-tracking-categories.mov
iOS: mWeb Safari
mweb-safari-xero-tracking-categories.mov
MacOS: Chrome / Safari
web-xero-tracking-categories.mov
MacOS: Desktop
desktop-xero-tracking-categories.mov