Threads - Nothing happens when Clicking Profile picture in detail of Group Chat thread

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.60-12
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): dave0123seife+hl5@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to any Group chat.
2. Start a thread
3. Click on the header of the thread to go to the Details page
4. Hover over the profile picture. Notice that there is a Pointer Cursor.
5. Click on the Profile Picture. Notice that nothing happens when clicking.

Expected Result:

If there is a pointer cursor. Clicking the profile must display the picture in full size.

Actual Result:

Clicking the profile does nothing even if there is a Pointer cursor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6437755_1712223237696.Thread_Profile_Picture.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Threads - Nothing happens when Clicking Profile picture in detail of Group Chat thread

What is the root cause of that problem?

Here we prevent navigation to REPORT_AVATAR page for group chats

What changes do you think we should make in order to solve the problem?

Remove this condition or update the check to icons.length > 1

What alternative solutions did you explore? (Optional)

Add prop disabled={isGroupChat} for PressableWithoutFocus component

[allgandalf]

This feature is still in development and the decision to return early was done intentionally c.c. @marcaaron

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Threads - Nothing happens when Clicking Profile picture in detail of Group Chat

What is the root cause of that problem?

The main problem with issue is that we have removed the ability to open an icon if it is a group chat

App/src/pages/ReportDetailsPage.tsx

Lines 218 to 222 in 0e6dba4

	<RoomHeaderAvatars
	icons={icons}
	reportID={report?.reportID}
	isGroupChat={ReportUtils.isGroupChat(report)}
	/>

https://github.com/Expensify/App/blob/0e6dba4fe604421dd30103b9a065deea3460b870/src/components/RoomHeaderAvatars.tsx#L21C9-L23C10

What changes do you think we should make in order to solve the problem?

To fix this issue we can update this condition and add ability to press when it's group chat thread

isGroupChat={ReportUtils.isGroupChat(report) && !ReportUtils.isThread(report)}

What alternative solutions did you explore? (Optional)

As alternative we can change cursor when it's group chat

style={[styles.noOutline, isGroupChat && styles.cursorDefault]}

App/src/components/RoomHeaderAvatars.tsx

Line 45 in 0e6dba4

style={styles.noOutline}

[greg-schroeder]

This might be expected - can you confirm this comment #39760 (comment) @marcaaron? <3

[marcaaron]

Yes, not a bug we just didn't add it yet. We should add it. But let's get the feature mostly done first.

[melvin-bot]

Current assignee @greg-schroeder is eligible for the NewFeature assigner, not assigning anyone new.

[greg-schroeder]

Okay this is held right now, will check for updates weekly on group chat progress

[greg-schroeder]

Held

[greg-schroeder]

Held

[greg-schroeder]

@marcaaron do you know if "Front End PR 2" is done yet?

[marcaaron]

Oh sorry, yes, it's been done for quite a while 🥲

[marcaaron]

We actually have an open issue for this already here someone is working on it. Gonna close this one out.