-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [HOLD for payment 2024-05-02] [Guided Setup] Implement the Stage 1 onboarding flow #39969
Comments
Triggered auto assignment to @kadiealexander ( |
Triggered auto assignment to @johncschuster ( |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-02. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Issue is ready for payment but no BZ is assigned. @joekaufmanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks! |
Payment Summary
BugZero Checklist (@joekaufmanexpensify)
|
@mountiny @francoisl @hoangzinh I see this comment, was there a regression from this issue? |
Based on this comment #40907 (comment), I think it's a false alarm. |
Got it, thanks for confirming! In that case, only payment needed here is $250 to @hoangzinh for C+ review via upwork. |
Job added to Upwork: https://www.upwork.com/jobs/~01dbadd33848f9de2a |
Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new. |
@hoangzinh offer for $250 sent! |
For regression test, I don't think we need to add that here piecemeal. I see a whole suite of manual tests in the design doc for us to pass to applause. |
Accepted. Thanks @joekaufmanexpensify |
@hoangzinh $250 sent and contract ended! |
Upwork job closed. |
All set, thanks everyone! |
Implementation issue for the Onboarding Stage 1 project
The design doc is here https://docs.google.com/document/d/1sxG_RV5HTFHgdCsJUDNpqSGs09W_OPLBKbNYQfu3FHw/edit. For more details on the implementation, please read the detailed section of the document.
This is implemented by SWM.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @The text was updated successfully, but these errors were encountered: