Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve last comment text in LHN when a message contains text + attachment #40014

Closed
tgolen opened this issue Apr 10, 2024 · 5 comments
Closed

Improve last comment text in LHN when a message contains text + attachment #40014

tgolen opened this issue Apr 10, 2024 · 5 comments
Assignees
@tgolen @johncschuster
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@tgolen
Copy link
Contributor

tgolen commented Apr 10, 2024 •
edited by melvin-bot bot
Loading

Steps:

  1. open a report
  2. Write a draft message (text: "This is an image").
  3. Add an attachment and send

Expected result:

LHN shows the report subtitle as "This is an image [Attachment]"

Actual Result:

LHN shows the report subtitle as "[Attachment]"

cc @rayane-djouah

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015f80610e08ecb358
  • Upwork Job ID: 1778077257994952704
  • Last Price Increase: 2024-04-10
@tgolen tgolen added Engineering Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Apr 10, 2024
@tgolen tgolen self-assigned this Apr 10, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015f80610e08ecb358

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @akinwale (Internal)

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 10, 2024
@tgolen tgolen mentioned this issue Apr 10, 2024
Merged
50 tasks
@tgolen tgolen added Weekly KSv2 and removed Daily KSv2 labels Apr 10, 2024
@rayane-djouah
Copy link
Contributor

👍

@tgolen tgolen added the Reviewing Has a PR in review label Apr 11, 2024
@akinwale akinwale removed their assignment Apr 13, 2024
@tgolen
Copy link
Contributor Author

tgolen commented May 3, 2024

This has been fixed and this issue can be closed.

@tgolen tgolen closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgolen tgolen

@johncschuster johncschuster

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tgolen @akinwale @johncschuster @rayane-djouah