[Performance] [Tracking] Individual chat messages are slow to render

[marcaaron]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

• Tap on a chat

Expected Result:

• When chat loads the entire visible area is filled with messages instantly

Actual Result:

• When items first render only a subset of them render and each "batch" of items is slightly delayed and one message renders after the other in a staggered fashion

Workaround:

Wait for the messages to appear awkwardly.

Platform:

All platforms, but the effects are felt differently depending on the platform.

Here's an example of what this looks like on various platforms...

Web:

iOS:

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @lschurr (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[lschurr]

@marcaaron should this be assigned to you? Or should it be auto-assigned to Eng?

[MelvinBot]

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lschurr]

Adding Eng before posting to External..

[Luke9389]

Ok, I see no reason not to make this external. Let's see what proposals our contributors come up with.

[MelvinBot]

Triggered auto assignment to @SofiedeVreese (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[marcaaron]

@lschurr auto assign to eng is perfect thanks!

[SofiedeVreese]

Removing @Luke9389 's assignment.

Posted to Upwork: https://www.upwork.com/jobs/~011974a9e078cd37d9

Adding Exported label now.

[MelvinBot]

Triggered auto assignment to @deetergp (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[SofiedeVreese]

As I'm out of office tomorrow, I'm going to unassign myself and re-add the External label.

[marcaaron]

@deetergp yes, that's the idea @rdjuric had. I think maybe we can create a new issue for it.

[mallenexpensify]

Job is closed/removed in Upwork (also checked and Help Wanted label is on this issue. hahahahah, just saw you JUST took them off Marc)

[rdjuric]

@deetergp yes, that's the idea @rdjuric had. I think maybe we can create a new issue for it.

@marcaaron I opened a issue for this #4258

[marcaaron]

@rdjuric nice! Thanks for that.

[MelvinBot]

@marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[marcaaron]

We're making some pretty interesting progress with this issue and it's starting to become clear that any list item components using withOnyx are going to take a long time to render since they'll always be blocked and "waiting for data" from Onyx. By leveraging the Context API we can avoid creating a new connection and get that time back. Exploring it in this PR.

[marcaaron]

So, I think chat switching is starting to approach something resembling an acceptable amount of time. Check out these latest videos which are release builds off main + the changes in the last PR I linked above...

iOS

iOS.Chat.Switch.-.after.improvements.mov

Android

Android.Chat.Switch.-.After.Improvements.mp4

Android looks slightly slower than iOS still (and is a little janky or something at one part) but whatever we are doing is working. 🍻

[quinthar]

Whoa! How do I get a taste of this?

…

On Mon, Aug 2, 2021, 9:43 PM Marc Glasser ***@***.***> wrote: So, I *think* chat switching is starting to approach something resembling an acceptable amount of time. Check out these latest videos which are *release* builds off main + the changes in the last PR I linked above... *iOS* https://user-images.githubusercontent.com/32969087/127958695-935956fc-9268-4866-bef2-28fffd42577f.mov *Android* https://user-images.githubusercontent.com/32969087/127958741-0177a936-c80f-484c-99ee-37a580adc876.mp4 Android looks slightly slower than iOS still (and is a little janky or something at one part) but whatever we are doing is working. 🍻 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4022 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNURYBFONN6TNXSNFLM3T25XX3ANCNFSM5AKI2SMQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[MelvinBot]

@marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@marcaaron 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[marcaaron]

Ok found a couple more improvements in these two PRs:

#4573
#4538

I think once they are merged we can close this issue.

[MelvinBot]

@marcaaron Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

@marcaaron Still overdue 6 days?! Let's take care of this!

[marcaaron]

Going to close this for now as the last of the changes are on staging. I'm not sure what else we can do to improve the individual loading of chat messages and they seem to load pretty fast for now.