[$250] Web - Chat - "No activity yet" is seen under a thread with replies

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.62-13
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Invite a member
4. Open workspace chat with the invited member
5. Send a message
6. Reply in thread of the sent message and send a few messages
7. Refresh the page
8. Click on search icon
9. Look under the thread report of the search results

Expected Result:

The last sent message in the thread should be seen under the thread report

Actual Result:

"No activity yet" is seen under the thread report even if there are a few messages sent

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6452165_1713346173913.bandicam_2024-04-17_12-20-31-133.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01069d56029ee01976
• Upwork Job ID: 1783056830918737920
• Last Price Increase: 2024-04-24
• Automatic offers:
• FitseTLT | Contributor | 0

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[kbecciv]

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - "No activity yet" is seen under a thread with replies

What is the root cause of that problem?

We are not passing lastMessageTextFromReport

App/src/libs/OptionsListUtils.ts

Line 1753 in 21ee1a3

reportOption.alternateText = getAlternateText(reportOption, {showChatPreviewLine, forcePolicyNamePreview});

So it will be set to no activity here

App/src/libs/OptionsListUtils.ts

Line 550 in 21ee1a3

return lastMessageTextFromReport.length > 0 ? option.lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');

What changes do you think we should make in order to solve the problem?

We need to pass it as

reportOption.alternateText = getAlternateText(reportOption, {
                lastMessageTextFromReport: getLastMessageTextForReport(ReportUtils.getReport(reportOption.reportID)),
                showChatPreviewLine,
                forcePolicyNamePreview,
            });

Or Alternatively we can make the check on option?.lastMessageText?.length here

App/src/libs/OptionsListUtils.ts

Line 550 in 21ee1a3

return lastMessageTextFromReport.length > 0 ? option.lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');

        return option?.lastMessageText && option?.lastMessageText?.length > 0 ? option.lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');

What alternative solutions did you explore? (Optional)

[melvin-bot]

@miljakljajic Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01069d56029ee01976

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[miljakljajic]

Added the external label and wave collect.

[tienifr]

Or Alternatively we can make the check on option?.lastMessageText?.length here

we also can safely remove lastMessageTextFromReport

[melvin-bot]

📣 @toffee121! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Valliappan21]

Contributor details
Your Expensify account email: valliappan21@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01de7dd2268ad24360

Have resolved this issue, can i submit the screen recording of the result

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Nuka02]

Contributor details
Your Expensify account email: ajdinnukic02@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01f64de1b86d612b5f

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Nuka02]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - "No activity yet" is seen under a thread with replies

What is the root cause of that problem?

Parameter for the last message from thread is not passed to the function getAlternateText, so the default value for lastMessageTextFromReport is being used (which is an empty string). Since that default value is not fulfilling the requirement in an if statement, it is returning phrasekey noActivityYet.

What changes do you think we should make in order to solve the problem?

More viable option is to not pass parameter lastMessageTextFromReport at all, since the object that is passed to the function already has the last message value. So, better option would be to change the if statement inside a function to check if the object contains the last message option. That way, we will not be passing the same value to the function twice. (In an object and as a separate value).

What alternative solutions did you explore? (Optional)

We could pass the parameter lastMessageTextFromReport to the function call.

[melvin-bot]

@miljakljajic, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

[Valliappan21]

@miljakljajic, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

Have resolved the issue,
What is the next process to do after sharing upworks profile link

[allroundexperts]

@FitseTLT's proposal looks good to me. I agree with @tienifr that removing lastMessageTextFromReport from report is a better option.

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[toffee121]

Two months ago, my Upwrok account was deactivated. So can't I work at your company without an Upwork account? Toffee Fernsby..

…

On Tue, Apr 30, 2024 at 8:30 PM melvin-bot[bot] ***@***.***> wrote: Triggered auto assignment to @francoisl <https://github.com/francoisl>, see https://stackoverflow.com/c/expensify/questions/7972 for more details. — Reply to this email directly, view it on GitHub <#40345 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BHLG2ZMXDCZLIMSK7FD2H5TY76FFTAVCNFSM6AAAAABGLFXP5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBVGIYDGMJWGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[toffee121]

I accept!

…

On Wed, May 1, 2024 at 12:48 AM melvin-bot[bot] ***@***.***> wrote: 📣 @FitseTLT <https://github.com/FitseTLT> 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link <https://www.upwork.com/nx/wm/offer/> Upwork job <https://www.upwork.com/jobs/~01069d56029ee01976> Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct <https://github.com/Expensify/App/blob/main/CODE_OF_CONDUCT.md> | Contributing <https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md> 📖 — Reply to this email directly, view it on GitHub <#40345 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BHLG2ZNUOISSM4S6OOFPKJTY77DNNAVCNFSM6AAAAABGLFXP5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBVHE2TQMRZGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[melvin-bot]

@francoisl @miljakljajic @allroundexperts @FitseTLT this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[toffee121]

Yes, I am working on it.

…

On Thu, May 2, 2024 at 2:04 AM melvin-bot[bot] ***@***.***> wrote: @francoisl <https://github.com/francoisl> @miljakljajic <https://github.com/miljakljajic> @allroundexperts <https://github.com/allroundexperts> @FitseTLT <https://github.com/FitseTLT> this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! — Reply to this email directly, view it on GitHub <#40345 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BHLG2ZLN3A3ZHG53ETQ6UYTZAEVBXAVCNFSM6AAAAABGLFXP5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYHA2TKMBZGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[toffee121]

Could you please provide me with information regarding the procedure for submitting an application and being considered for a position at your company?

…

On Thu, May 2, 2024 at 4:20 PM Toffee Fernsby ***@***.***> wrote: Yes, I am working on it. On Thu, May 2, 2024 at 2:04 AM melvin-bot[bot] ***@***.***> wrote: > @francoisl <https://github.com/francoisl> @miljakljajic > <https://github.com/miljakljajic> @allroundexperts > <https://github.com/allroundexperts> @FitseTLT > <https://github.com/FitseTLT> this issue was created 2 weeks ago. Are we > close to approving a proposal? If not, what's blocking us from getting this > issue assigned? Don't hesitate to create a thread in #expensify-open-source > to align faster in real time. Thanks! > > — > Reply to this email directly, view it on GitHub > <#40345 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BHLG2ZLN3A3ZHG53ETQ6UYTZAEVBXAVCNFSM6AAAAABGLFXP5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYHA2TKMBZGE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[francoisl]

Hi @toffee121, there seems to be some confusion here, this issue has been assigned to FitseTLT so you don't need to waste your time working on it. Reviewing https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md should help clarify how you can contribute moving forward. Thanks!

[FitseTLT]

Payment Overdue @miljakljajic . The linked PR was deployed to production 2 weeks ago.

[melvin-bot]

This issue has not been updated in over 15 days. @francoisl, @miljakljajic, @allroundexperts, @FitseTLT eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[FitseTLT]

Bump @miljakljajic for payment

[JmillsExpensify]

@miljakljajic payment summary (and payments) please.

[miljakljajic]

@allroundexperts is owed 250 for their work reviewing this PR

@FitseTLT - paid you in Upwork.

[JmillsExpensify]

$250 approved for @allroundexperts