[$250] Sign up - "Welcome to Expensify" modal not appears on a new account

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2616817
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Create new account
2. Copy the Magic link from email and change it to staging
3. Open a new tab and navigate to the staging magic link
4. Navigate to the original tab

Expected Result:

The user is logged in with the new account, therefore the engagement modal "Welcome to Expensify" should be displayed - SEE THIS COMMENT FOR MODAL

Actual Result:

The user is logged in with the new account but the engagement modal "Welcome to Expensify" is not displayed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6453334_1713427876198.bandicam_2024-04-18_11-03-28-542.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e55bf0be53bd1320
• Upwork Job ID: 1785452321885933568
• Last Price Increase: 2024-04-30

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The welcome to expensify modal doesn't show.

What is the root cause of that problem?

There are a couple of root causes of this issue.

The modal doesn't show because the isFirstTimeNewExpensifyUser is undefined.

App/src/libs/actions/Welcome.ts

Lines 61 to 63 in 9b839f4

	if (!isFirstTimeNewExpensifyUser) {
	return;
	}

First, isOnboardingFlowStatusKnownPromise promise is never reset. So, if it's resolved once, logging out and logging in as a new user will pass the promise immediately.

Second, isAbleToDetermineOnboardingStatus doesn't wait for isFirstTimeNewExpensifyUser data to be ready.

App/src/libs/actions/Welcome.ts

Lines 43 to 44 in 9b839f4

	function isAbleToDetermineOnboardingStatus({onAble, onNotAble}: DetermineOnboardingStatusProps) {
	const hasRequiredOnyxKeysBeenLoaded = [hasProvidedPersonalDetails, hasSelectedPurpose].every((value) => value !== undefined);

Last, isFirstTimeNewExpensifyUser is returned as false even for a new user.

What changes do you think we should make in order to solve the problem?

1. Reset isOnboardingFlowStatusKnownPromise promise and other data when signing out. We did this before but the code was removed.

function resetRequiredDataCheck() {
    isOnboardingFlowStatusKnownPromise = new Promise<void>((resolve) => {
        resolveOnboardingFlowStatus = resolve;
    });
    hasProvidedPersonalDetails = undefined;
    isFirstTimeNewExpensifyUser = undefined;
}

Call it in Session.cleanupSession

2. Add isFirstTimeNewExpensifyUser to hasRequiredOnyxKeysBeenLoaded array
   

   App/src/libs/actions/Welcome.ts

   Line 44 in 9b839f4

   const hasRequiredOnyxKeysBeenLoaded = [hasProvidedPersonalDetails, hasSelectedPurpose].every((value) => value !== undefined);

3. Call isAbleToDetermineOnboardingStatus({onAble: resolveOnboardingFlowStatus}); in isFirstTimeNewExpensifyUser onyx callback.

App/src/libs/actions/Welcome.ts

Lines 119 to 130 in 9b839f4

	Onyx.connect({
	key: ONYXKEYS.NVP_IS_FIRST_TIME_NEW_EXPENSIFY_USER,
	initWithStoredValues: false,
	callback: (value) => {
	// If isFirstTimeNewExpensifyUser was true do not update it to false. We update it to false inside the Welcome.show logic
	// More context here https://github.com/Expensify/App/pull/16962#discussion_r1167351359
	isFirstTimeNewExpensifyUser = value ?? undefined;
	checkOnReady();
	},
	});

4. Fix in the BE to return correct isFirstTimeNewExpensifyUser value.

But since the comment here mentioning that isFirstTimeNewExpensifyUser is going to be removed, maybe we can skip 2-4.

App/src/libs/actions/Welcome.ts

Lines 60 to 63 in 9b839f4

	// Remove once Stage 1 Onboarding Flow is ready
	if (!isFirstTimeNewExpensifyUser) {
	return;
	}

[jliexpensify]

@izarutskaya to me, this doesn't seem like a bug - a Magic link is designed to allow you to sign in. @bernhardoj curious to get your thoughts, as you've given a proposal already.

[bernhardoj]

@jliexpensify the welcome modal doesn't show too if the user sign up normally with magic code input.

[jliexpensify]

Yep, that's what i thought - so this isn't a bug right? It's working as intended.

[bernhardoj]

Hmm, I think welcome modal should be shown for new user, right?

is it different now?

[jliexpensify]

I'm not sure if anything has changed, but let me clarify what I think the intended behaviour should be, based off the repro steps:

1. Create new account = see Welcome Modal
2. Copy the Magic Link from email = Welcome Modal should still be active, as Magic Link is not used
3. Change the URL to staging = Welcome Modal should still be active, as Magic Link is not used
4. Open a new tab and navigate to the staging Magic Link = at this point, since we've clicked on the staging Magic Link, this "validates" or "activates" the new account.
5. Navigate to the original tab = user should now be logged in, and no Welcome Modal is shown as the Magic Link has already been clicked on and their account is "activated"

So are you saying that the Modal should still be shown at step 4? What I think is the Magic Link has now been used at that step, so the Welcome Modal should be bypassed.

[bernhardoj]

Hmm, maybe we are talking about a different welcome modal. The modal I'm thinking is this one,

I see that we are going to replace it with onboarding modal, but the root cause of the issue will still persist and potentially trigger a false alarm that the user already completes the onboarding flow even though they are not yet, but I don't know yet what would happen with that.

[jliexpensify]

You're right, it's actually not very clear which Welcome Modal @izarutskaya is talking about. My assumption is this one, as it's the only one in the video:

@izarutskaya can you confirm which Welcome Modal? If it's the Onboarding Modal, then we need to change this GH body and re-test, and then we can move forward.

[jliexpensify]

Bump @izarutskaya

[jliexpensify]

Bump @izarutskaya to address this comment - I have posted in Slack here.

[izarutskaya]

Hello @jliexpensify
Sorry for waiting, I mean this Welcome Modal (Previously it looked like in this comment #40432 (comment)). Thank you

[jliexpensify]

Got it - so you're actually referring to something completely different to @bernhardoj and myself.

I'm going to loop in @Expensify/design to review this one - maybe @dubielzyk-expensify can confirm if this and/or this are meant to pop up with the described flow.

[dubielzyk-expensify]

Interesting. I believe we're killing this modal in favor of Stage 2 Onboarding.

We will wanna make sure they see the new onboarding flow and this new welcome modal.

So if I understand this bug correctly, we'll still wanna make sure they see the latest modal with the video.

cc @MitchExpensify and @Expensify/design in case they disagree

[jliexpensify]

Awesome, I thought so - thanks Jon. Once we get confirmation, happy to update the GH body with the screenshot/info and get this posted Externally.

[MitchExpensify]

We will wanna make sure they see the new onboarding flow and #40432 (comment).

Agree this is our goal

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e55bf0be53bd1320

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[jliexpensify]

Updated GH, assigned to External. @bernhardoj did you need to make adjustments to your proposal?

[bernhardoj]

The root cause is already fixed in the new onboarding modal PR. I can see the onboarding modal after signing up.

[jliexpensify]

Nice, thank you! I'll close this now.