[HOLD for payment 2024-05-30] Loading loop when opening a chat

[janicduplessis]

Version Number: 1.4.62-14
Reproducible in staging?: No
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs:
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1713403457450239?thread_ts=1713358946.087599&cid=C05LX9D6E07

Action Performed:

Open the #social chat

Expected Result:

The chat loads

Actual Result:

The chat keeps loading in a loop

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

screen-20240417-181842.mp4

Profile_trace_for_1.4.62-14.cpuprofile

logs-2024-04-18_01_17_59.162 (1).txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01be52de22fd67ac4a
• Upwork Job ID: 1785306670485327873
• Last Price Increase: 2024-04-30
• Automatic offers:
• rojiphil | Contributor | 0

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[janicduplessis]

This is the slack thread investigating the issue https://expensify.slack.com/archives/C05LX9D6E07/p1713454764509159. I narrowed it down to API errors that we can see in the logs (jsonCode: 666) for GetNewerActions and GetOlderActions. I wasn't able to reproduce the exact same behavior as the video, but I was able to reproduce those methods being called in a loop when they fail.

The solution is to handle pagination errors properly, this is implemented here #40610

[melvin-bot]

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

[dannymcclain]

Not overdue, we've just been discussing this on the PR.

[dannymcclain]

PR is still in the works. Looks like it's getting close though!

[janicduplessis]

PR is ready!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01be52de22fd67ac4a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[muttmuure]

Oh, I didn't realize that @Gonals was already reviewing.

[muttmuure]

Sorry

[melvin-bot]

Triggered auto assignment to @NickTooker (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[mountiny]

@NickTooker Could you please confirm if this copy sounds fine to you:

You can see at the bottom, if there is an issue loading more messages, we would show an error to the user with option to retry the request maybe once they get better connection.

There was an error loading more messages is the copy now. Thanks!

[janicduplessis]

We should also check the Spanish version of the copy

Se produjo un error al cargar más mensajes.
Inténtalo de nuevo

[NickTooker]

Confirmed on my end!

[mountiny]

@janicduplessis Can you please follow these instructions regarding the translations and post in the open source channel? Thanks!

[melvin-bot]

@janicduplessis, @rojiphil, @dannymcclain, @NickTooker, @mountiny, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@janicduplessis @rojiphil @dannymcclain @NickTooker @mountiny @muttmuure this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[mountiny]

This is looking good, we can make it weekly now, the PR has been merged

[mountiny]

This was deployed last week so I think we just need to pay this out to @rojiphil $250

[rojiphil]

@muttmuure Gentle bump on payment step here. Thanks

[rojiphil]

@muttmuure Bump on payment step as referenced here. Thanks

[muttmuure]

Handling

[muttmuure]

@rojiphil paid $250